From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE741C433F5 for ; Mon, 11 Apr 2022 08:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243308AbiDKIx5 (ORCPT ); Mon, 11 Apr 2022 04:53:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243620AbiDKIx4 (ORCPT ); Mon, 11 Apr 2022 04:53:56 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A833EABC for ; Mon, 11 Apr 2022 01:51:41 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id t1so4222683wra.4 for ; Mon, 11 Apr 2022 01:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=IXFXkZ/zIPR/vpj7KNO5NDwB6CMm+azUma0NGH5YVgU=; b=DU1x7RrLRqhM32z2qCQqJ8a/bsJ1Es12ZQaw54KzV/aumf31lk1TLA1cpv4cZI8Ml0 I+PBZQ513P+Kl+A/cS98JJNei9ccl78hSmxjsg7XW11/rh3t9Ybra6WILnO2jHnWVw03 d99k42th8WeHxcw1YDHY+O1+QzALwhvy3AH1pZW142gprxVanbAPJMWDcfOlCMCwxITt 0bDMQgwZrIbdNbhNstZ0ncbZD4ArqB/X32ZlX0JK3qVtYtPbKZ7UwF7Z7vjQOIhIkgsF hcglTWYerpYvHtIhiNnQjyVGp4qBPBlKNsdrpzUAw6LdVPJPh8vkURTvWG+uDP3P+36m kpSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IXFXkZ/zIPR/vpj7KNO5NDwB6CMm+azUma0NGH5YVgU=; b=SsumOniNyBSBpCP7NdQsi0FBc801yUX/bCJcRGNpmorKeNyT9kssQs1Xc76j859Yca gKQ/9cRYcuGm3pvXPUEXT6pjuZ7sEW3l8+GpFvaf/2LgzONb0nc+hjCc2iPUlW8/tIha DVOgMOAsBIG1tG9zCoPr66tUEBMXDnI4iBAkIkdrT037zIt06dgGy167iuiSqWv9Ifjg 6byJ/7p5Tk3m/qake8K7zfnCiXbrPGRwBlaOaWaXbMwW4iC2je3vYXDSrgcCpQsm10jy nZcW6ETr2njMGmNOB8Zq8zYUfXoxTgy+OEl1Xq4okIVo+SK6t5h5eKs0AsR4Fd7XU4wK UU3w== X-Gm-Message-State: AOAM5327vVQD+eZvx+aWYP6ob+d9jEMR+tS8ADX0VnkLsdltbWf2BoUy KvVg92JZJs0MB+8HkyiHGViz7Q== X-Google-Smtp-Source: ABdhPJwBIvnDClmMj7lyqH8WolBn46vICihfyKzrStW5W+VTLqQQ9byyWSgWtWbeDhcHuG4qEqGRgQ== X-Received: by 2002:a05:6000:15cb:b0:207:97e4:e445 with SMTP id y11-20020a05600015cb00b0020797e4e445mr11520814wry.672.1649667100481; Mon, 11 Apr 2022 01:51:40 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id y15-20020a056000168f00b002057a9f9f5csm30881650wrd.31.2022.04.11.01.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 01:51:39 -0700 (PDT) Date: Mon, 11 Apr 2022 10:51:38 +0200 From: LABBE Corentin To: John Keeping Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 08/33] crypto: rockchip: better handle cipher key Message-ID: References: <20220401201804.2867154-1-clabbe@baylibre.com> <20220401201804.2867154-9-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le Mon, Apr 04, 2022 at 12:31:11PM +0100, John Keeping a écrit : > On Fri, Apr 01, 2022 at 08:17:39PM +0000, Corentin Labbe wrote: > > The key should not be set in hardware too much in advance, this will > > fail it 2 TFM with different keys generate alternative requests. > > The key should be stored and used just before doing cipher operations. > > > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > > Signed-off-by: Corentin Labbe > > --- > > drivers/crypto/rockchip/rk3288_crypto.h | 1 + > > drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 10 +++++++--- > > 2 files changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockchip/rk3288_crypto.h > > index 8b1e15d8ddc6..826508e4a0c3 100644 > > --- a/drivers/crypto/rockchip/rk3288_crypto.h > > +++ b/drivers/crypto/rockchip/rk3288_crypto.h > > @@ -245,6 +245,7 @@ struct rk_ahash_rctx { > > struct rk_cipher_ctx { > > struct rk_crypto_info *dev; > > unsigned int keylen; > > + u32 key[AES_MAX_KEY_SIZE / 4]; > > Should this be u8? It's only ever memcpy'd so the fact the registers > are 32-bit is irrelevant. > > (Also a very minor nit: this should probably be aligned in the same was > as the above two variables.) Yes, it could be u8 and I will fix the alignement. Regards