From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7BAC433EF for ; Tue, 12 Apr 2022 02:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbiDLChk (ORCPT ); Mon, 11 Apr 2022 22:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233008AbiDLChj (ORCPT ); Mon, 11 Apr 2022 22:37:39 -0400 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A70D19C31 for ; Mon, 11 Apr 2022 19:35:20 -0700 (PDT) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-de48295467so19451420fac.2 for ; Mon, 11 Apr 2022 19:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=27t0/Qo4lvhMaM3TOiDm3Op0HQcIUZVxhkHZUsq/h+k=; b=Tx/Tmmv9cHXeVpqxCWqj5GsiGQfPuyPwy4ZJMqCZoCmjSIUC2mrhsAqTGh697Gst1L QFHWj6TLIKNnv8EJk8n/SO9zlOHUFgyrE3AOsDxCbR9fhedJk6tQYkJnoew1SfXL19IW iJb7r8PL73g+YsrPSvfbkQyH0Ug3gUohwbGfcH+uEV5vxkngt2D9/qreYYvdETlrj2fz tzpN451OGElP9tZrzg5+SE2DuAg3kiloaUDwSZSNxbvkbwOeF3N0y7bAWuW9ByPM2WC6 5H3rpSpxUBsmzS+pXakv/NZVpPCRpjDXT6ME0mbbGumtz4FVeQru8tPLQe832jmxBi+P F3jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=27t0/Qo4lvhMaM3TOiDm3Op0HQcIUZVxhkHZUsq/h+k=; b=1UjJs32FCTv0iBMJ+mwsxD0qsFaccA09F1M2HW+s3CecSBDKacR6mcGEaWw5+tdZ9z CdDENpDt6zx4MzUqLLLUG5VRQbmEaH3r2KEgBn+WanH6rPd9gHV6LjKXMtC5TCOAOUaf aLleA+UB9Yl/BK59LIvuE+Ft8eSNleL146BgFUbLRGgX7y6kA7qPkt7zCiNz11q8HytP MD22q9gRj2NPy6caJJawCgWDEYvgfF0+g3SNBtvdEPfRhayA/srPy//+B1I9s0tVM7QZ QHheP7ZgkF8uu5Z8ZwMy3yutjerNtnQH5YmqHPS9w3R3dn1Oct53OrLseKFvbx0Gib/Q 2Dmg== X-Gm-Message-State: AOAM530kog9m3GBEnrmp6uP0ZFDNV2+2I77Udfsew6gBGELPyt/DgkJA 2OlqfqMje8AMyjyN3yvwF14kgAieT5R3hGKM X-Google-Smtp-Source: ABdhPJw/w+OlcERZQK/Rj6XF2LKTmJs8sqZLOUp33SNe35UFdg2B00DCfvuhLcn2uIV4Glaep/a58w== X-Received: by 2002:a05:6870:f104:b0:da:b3f:3248 with SMTP id k4-20020a056870f10400b000da0b3f3248mr1138491oac.248.1649730919742; Mon, 11 Apr 2022 19:35:19 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id i28-20020a056870891c00b000de777f1a41sm12756872oao.46.2022.04.11.19.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 19:35:18 -0700 (PDT) Date: Mon, 11 Apr 2022 21:35:17 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Vladimir Zapolskiy , Vinod Koul , Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sm8450: fix interconnects property of UFS node Message-ID: References: <20220310221934.1560729-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 05 Apr 12:38 CDT 2022, Dmitry Baryshkov wrote: > On Tue, 5 Apr 2022 at 20:17, Bjorn Andersson wrote: > > > > On Tue 05 Apr 08:38 PDT 2022, Dmitry Baryshkov wrote: > > > > > On 11/03/2022 01:19, Vladimir Zapolskiy wrote: > > > > All interconnect device tree nodes on sm8450 are 2-cells, however in > > > > UFS node they are handled as 1-cells, fix it. > > > > > > > > Fixes: aa2d0bf04a3c ("arm64: dts: qcom: sm8450: add interconnect nodes") > > > > Signed-off-by: Vladimir Zapolskiy > > > > > > Reviewed-by: Dmitry Baryshkov > > > > > > Bjorn, could you please this pick for the -rc kernel? > > > > > > > The change is obviously correct, but what difference does this change > > make with the current implementation? > > it makes interconnect paths probe correctly. All NoC have > #interconnec-cells = <2> now. > But there's no code in the UFS driver that calls of_icc_get(), so what does this actually do? (Other than correcting the dtb for the day when we add that support to the driver). Regards, Bjorn > > > > Regards, > > Bjorn > > > > > > --- > > > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > index 0cd5af8c03bd..bbd38b55e976 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > @@ -1376,8 +1376,8 @@ ufs_mem_hc: ufshc@1d84000 { > > > > iommus = <&apps_smmu 0xe0 0x0>; > > > > - interconnects = <&aggre1_noc MASTER_UFS_MEM &mc_virt SLAVE_EBI1>, > > > > - <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_UFS_MEM_CFG>; > > > > + interconnects = <&aggre1_noc MASTER_UFS_MEM 0 &mc_virt SLAVE_EBI1 0>, > > > > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_UFS_MEM_CFG 0>; > > > > interconnect-names = "ufs-ddr", "cpu-ufs"; > > > > clock-names = > > > > "core_clk", > > > > > > > > > -- > > > With best wishes > > > Dmitry > > > > -- > With best wishes > Dmitry