* [PATCH v9 0/2] Add lpass pin control support for audio on sc7280 based targets
@ 2022-04-13 14:44 Srinivasa Rao Mandadapu
2022-04-13 14:44 ` [PATCH v9 1/2] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset Srinivasa Rao Mandadapu
2022-04-13 14:44 ` [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Srinivasa Rao Mandadapu
0 siblings, 2 replies; 6+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-04-13 14:44 UTC (permalink / raw)
To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders,
swboyd, judyhsiao
Cc: Srinivasa Rao Mandadapu
This patch set is to add lpass pin control support for Audio over I2S,
wcd codec and digital mics.
This patch set depends on:
-- Lpass-lpi pinctrl patches [https://patchwork.kernel.org/project/alsa-devel/list/?series=623951&archive=both&state=*]
Changes Since V8:
-- Modify label and node names to lpass specific.
-- Sort nodes as per node names and kind of nodes like pinctrl and device nodes.
Changes Since V7:
-- Sort mi2s pincontrol nodes as per node name.
-- Fix typo errors.
Changes Since V6:
-- Move amp_en node to corresponding consumer patch.
-- Update label and node names.
-- Remove redundant drive-strengths.
-- Remove herobrine crd specific mi2s configuration.
Changes Since V5:
-- Remove redundant function property in amp_en node.
-- Move board specific properties of lpass pin control node to board specific file.
-- Remove redundant properties in pin control nodes.
-- Move wcd938x codec reset and CTIA/OMTP pin control patches to other series.
Changes Since V4:
-- Add primary and secondary I2S pinmux nodes for herobrine specific targets.
Changes Since V3:
-- Add pinctrl nodes for wcd codec reset and CTIA/OMTP headset selection.
Changes Since V2:
-- Move lpass pin control node to main dtsi file.
-- Sort nodes alphabetically.
-- Remove redundant wcd reset gpio nodes.
-- Remove redundant input-enable field in dmic pin control nodes.
-- Update amp_en node.
-- Fix typo errors.
-- Modify node names.
-- Create patches on latest kernel.
Changes Since V1:
-- Merge pinmux and pinconf properties in amp_en and wcd pin reset node.
-- Split common i2s pin control nodes to functionality specific nodes.
-- Move board specific properties to board specific dtsi file.
-- Update dmic pin control node name.
Srinivasa Rao Mandadapu (2):
arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset
arm64: dts: qcom: sc7280: add lpass lpi pin controller node
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 98 +++++++++++++++++++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 147 +++++++++++++++++++++++++++++++
2 files changed, 245 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v9 1/2] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset 2022-04-13 14:44 [PATCH v9 0/2] Add lpass pin control support for audio on sc7280 based targets Srinivasa Rao Mandadapu @ 2022-04-13 14:44 ` Srinivasa Rao Mandadapu 2022-04-13 17:19 ` Matthias Kaehlcke 2022-04-13 14:44 ` [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Srinivasa Rao Mandadapu 1 sibling, 1 reply; 6+ messages in thread From: Srinivasa Rao Mandadapu @ 2022-04-13 14:44 UTC (permalink / raw) To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree, linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu Add pinmux nodes for primary and secondary I2S for SC7280 based platforms. Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 14 +++++++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 40 ++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index ecbf2b8..1fc94b5 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -359,6 +359,20 @@ bias-disable; }; +&mi2s1_data0 { + drive-strength = <6>; + bias-disable; +}; + +&mi2s1_sclk { + drive-strength = <6>; + bias-disable; +}; + +&mi2s1_ws { + drive-strength = <6>; +}; + &pm7325_gpios { key_vol_up_default: key-vol-up-default { pins = "gpio6"; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index f0b64be..6e6cfeda 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -3522,6 +3522,46 @@ function = "edp_hot"; }; + mi2s0_data0: mi2s0-data0 { + pins = "gpio98"; + function = "mi2s0_data0"; + }; + + mi2s0_data1: mi2s0-data1 { + pins = "gpio99"; + function = "mi2s0_data1"; + }; + + mi2s0_mclk: mi2s0-mclk { + pins = "gpio96"; + function = "pri_mi2s"; + }; + + mi2s0_sclk: mi2s0-sclk { + pins = "gpio97"; + function = "mi2s0_sck"; + }; + + mi2s0_ws: mi2s0-ws { + pins = "gpio100"; + function = "mi2s0_ws"; + }; + + mi2s1_data0: mi2s1-data0 { + pins = "gpio107"; + function = "mi2s1_data0"; + }; + + mi2s1_sclk: mi2s1-sclk { + pins = "gpio106"; + function = "mi2s1_sck"; + }; + + mi2s1_ws: mi2s1-ws { + pins = "gpio108"; + function = "mi2s1_ws"; + }; + pcie1_clkreq_n: pcie1-clkreq-n { pins = "gpio79"; function = "pcie1_clkreqn"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v9 1/2] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset 2022-04-13 14:44 ` [PATCH v9 1/2] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset Srinivasa Rao Mandadapu @ 2022-04-13 17:19 ` Matthias Kaehlcke 0 siblings, 0 replies; 6+ messages in thread From: Matthias Kaehlcke @ 2022-04-13 17:19 UTC (permalink / raw) To: Srinivasa Rao Mandadapu Cc: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree, linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao, Venkata Prasad Potturu On Wed, Apr 13, 2022 at 08:14:06PM +0530, Srinivasa Rao Mandadapu wrote: > Add pinmux nodes for primary and secondary I2S for SC7280 based platforms. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node 2022-04-13 14:44 [PATCH v9 0/2] Add lpass pin control support for audio on sc7280 based targets Srinivasa Rao Mandadapu 2022-04-13 14:44 ` [PATCH v9 1/2] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset Srinivasa Rao Mandadapu @ 2022-04-13 14:44 ` Srinivasa Rao Mandadapu 2022-04-13 17:25 ` Matthias Kaehlcke 1 sibling, 1 reply; 6+ messages in thread From: Srinivasa Rao Mandadapu @ 2022-04-13 14:44 UTC (permalink / raw) To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree, linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu Add LPASS LPI pinctrl node required for Audio functionality on sc7280 based platforms. Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 84 ++++++++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 +++++++++++++++++++++++++++++++ 2 files changed, 191 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 1fc94b5..110d9e9 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -359,6 +359,90 @@ bias-disable; }; +&lpass_dmic01 { + clk { + drive-strength = <8>; + }; +}; + +&lpass_dmic01_sleep { + clk { + drive-strength = <2>; + bias-disable; + }; + + data { + pull-down; + }; +}; + +&lpass_dmic23 { + clk { + drive-strength = <8>; + }; +}; + +&lpass_dmic23_sleep { + clk { + drive-strength = <2>; + bias-disable; + }; + + data { + pull-down; + }; +}; + +&lpass_rx_swr { + clk { + drive-strength = <2>; + slew-rate = <1>; + bias-disable; + }; + + data { + drive-strength = <2>; + slew-rate = <1>; + bias-bus-hold; + }; +}; + +&lpass_rx_swr_sleep { + clk { + drive-strength = <2>; + bias-pull-down; + }; + + data { + drive-strength = <2>; + bias-pull-down; + }; +}; + +&lpass_tx_swr { + clk { + drive-strength = <2>; + slew-rate = <1>; + bias-disable; + }; + + data { + slew-rate = <1>; + bias-bus-hold; + }; +}; + +&lpass_tx_swr_sleep { + clk { + drive-strength = <2>; + bias-pull-down; + }; + + data { + bias-bus-hold; + }; +}; + &mi2s1_data0 { drive-strength = <6>; bias-disable; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 6e6cfeda..50fea0e 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -1987,6 +1987,113 @@ qcom,bcm-voters = <&apps_bcm_voter>; }; + lpass_tlmm: pinctrl@33c0000 { + compatible = "qcom,sc7280-lpass-lpi-pinctrl"; + reg = <0 0x033c0000 0x0 0x20000>, + <0 0x03550000 0x0 0x10000>; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&lpass_tlmm 0 0 15>; + + #clock-cells = <1>; + + lpass_dmic01: lpass-dmic01 { + clk { + pins = "gpio6"; + function = "dmic1_clk"; + }; + + data { + pins = "gpio7"; + function = "dmic1_data"; + }; + }; + + lpass_dmic01_sleep: lpass-dmic01-sleep { + clk { + pins = "gpio6"; + function = "dmic1_clk"; + }; + + data { + pins = "gpio7"; + function = "dmic1_data"; + }; + }; + + lpass_dmic23: lpass-dmic23 { + clk { + pins = "gpio8"; + function = "dmic2_clk"; + }; + + data { + pins = "gpio9"; + function = "dmic2_data"; + }; + }; + + lpass_dmic23_sleep: lpass-dmic23-sleep { + clk { + pins = "gpio8"; + function = "dmic2_clk"; + }; + + data { + pins = "gpio9"; + function = "dmic2_data"; + }; + }; + + lpass_rx_swr: lpass-rx-swr { + clk { + pins = "gpio3"; + function = "swr_rx_clk"; + }; + + data { + pins = "gpio4", "gpio5"; + function = "swr_rx_data"; + }; + }; + + lpass_rx_swr_sleep: lpass-rx-swr-sleep { + clk { + pins = "gpio3"; + function = "swr_rx_clk"; + }; + + data { + pins = "gpio4", "gpio5"; + function = "swr_rx_data"; + }; + }; + + lpass_tx_swr: lpass-tx-swr { + clk { + pins = "gpio0"; + function = "swr_tx_clk"; + }; + + data { + pins = "gpio1", "gpio2", "gpio14"; + function = "swr_tx_data"; + }; + }; + + lpass_tx_swr_sleep: lpass-tx-swr-sleep { + clk { + pins = "gpio0"; + function = "swr_tx_clk"; + }; + + data { + pins = "gpio1", "gpio2", "gpio14"; + function = "swr_tx_data"; + }; + }; + }; + gpu: gpu@3d00000 { compatible = "qcom,adreno-635.0", "qcom,adreno"; reg = <0 0x03d00000 0 0x40000>, -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node 2022-04-13 14:44 ` [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Srinivasa Rao Mandadapu @ 2022-04-13 17:25 ` Matthias Kaehlcke 2022-04-14 13:17 ` Srinivasa Rao Mandadapu 0 siblings, 1 reply; 6+ messages in thread From: Matthias Kaehlcke @ 2022-04-13 17:25 UTC (permalink / raw) To: Srinivasa Rao Mandadapu Cc: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree, linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao, Venkata Prasad Potturu On Wed, Apr 13, 2022 at 08:14:07PM +0530, Srinivasa Rao Mandadapu wrote: > Add LPASS LPI pinctrl node required for Audio functionality on sc7280 > based platforms. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 84 ++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 +++++++++++++++++++++++++++++++ > 2 files changed, 191 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 6e6cfeda..50fea0e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1987,6 +1987,113 @@ > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > + lpass_tlmm: pinctrl@33c0000 { > + compatible = "qcom,sc7280-lpass-lpi-pinctrl"; > + reg = <0 0x033c0000 0x0 0x20000>, > + <0 0x03550000 0x0 0x10000>; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&lpass_tlmm 0 0 15>; > + > + #clock-cells = <1>; > + > + lpass_dmic01: lpass-dmic01 { For the node names the 'lpass-' prefix is redundant as you remarked earlier, since they are inside the 'lpass_tlmm' node. It's only useful for the labels, which can be used in other .dts[i] files where the context might not be evident. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node 2022-04-13 17:25 ` Matthias Kaehlcke @ 2022-04-14 13:17 ` Srinivasa Rao Mandadapu 0 siblings, 0 replies; 6+ messages in thread From: Srinivasa Rao Mandadapu @ 2022-04-14 13:17 UTC (permalink / raw) To: Matthias Kaehlcke Cc: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree, linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao, Venkata Prasad Potturu On 4/13/2022 10:55 PM, Matthias Kaehlcke wrote: Thanks for your time Matthias!!! > On Wed, Apr 13, 2022 at 08:14:07PM +0530, Srinivasa Rao Mandadapu wrote: >> Add LPASS LPI pinctrl node required for Audio functionality on sc7280 >> based platforms. >> >> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> >> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> >> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 84 ++++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 +++++++++++++++++++++++++++++++ >> 2 files changed, 191 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 6e6cfeda..50fea0e 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -1987,6 +1987,113 @@ >> qcom,bcm-voters = <&apps_bcm_voter>; >> }; >> >> + lpass_tlmm: pinctrl@33c0000 { >> + compatible = "qcom,sc7280-lpass-lpi-pinctrl"; >> + reg = <0 0x033c0000 0x0 0x20000>, >> + <0 0x03550000 0x0 0x10000>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + gpio-ranges = <&lpass_tlmm 0 0 15>; >> + >> + #clock-cells = <1>; >> + >> + lpass_dmic01: lpass-dmic01 { > For the node names the 'lpass-' prefix is redundant as you remarked > earlier, since they are inside the 'lpass_tlmm' node. It's only useful > for the labels, which can be used in other .dts[i] files where the > context might not be evident. Okay. will do accordingly. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-14 13:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-04-13 14:44 [PATCH v9 0/2] Add lpass pin control support for audio on sc7280 based targets Srinivasa Rao Mandadapu 2022-04-13 14:44 ` [PATCH v9 1/2] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset Srinivasa Rao Mandadapu 2022-04-13 17:19 ` Matthias Kaehlcke 2022-04-13 14:44 ` [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Srinivasa Rao Mandadapu 2022-04-13 17:25 ` Matthias Kaehlcke 2022-04-14 13:17 ` Srinivasa Rao Mandadapu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).