From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E47C433FE for ; Wed, 13 Apr 2022 17:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231996AbiDMR2A (ORCPT ); Wed, 13 Apr 2022 13:28:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237542AbiDMR1u (ORCPT ); Wed, 13 Apr 2022 13:27:50 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF63D3633E for ; Wed, 13 Apr 2022 10:25:28 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id 12so2498773pll.12 for ; Wed, 13 Apr 2022 10:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CfH4hnYZTKDMMLfceQBqDJ1Kg4COwkEciCmvmaOTXik=; b=Z0GuslnytN5UVYPRl1aE84EU2zbabfasrf2onFpdaxU5HKo+AmsJJFcyYnF+Ofjdz3 LKTKbR2Hzao8aj+o52QTtP/H4WySHcDKAZtbUX+/r5U1L1pfVGx+2HY9XbLrb67mo/29 bWtVpUIgafnEz9CbcTZciiTiszvdChdYpr3gc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CfH4hnYZTKDMMLfceQBqDJ1Kg4COwkEciCmvmaOTXik=; b=p9WB9nJVuHa1kDE9ibW6RqS8IzTtexux3sgGXMjM1SQ7wQL+8fpt35blFe5mzijJ1E OpfjRtIsVPQJ1lr7c43P4pUNELekuWK0JygXvvw5Wvl+qjPHSt2WidkEyOg9gvtmVxY8 mOyjn0BGYxV93bCMZ0ydnAEvkESAQEdC+qujpEhU101r9uD+iI8EY+pHoQDRpdC4mRCD Y0fKv57tfwP7nDr0bKkvHYfUq/Uh8YUD9xXz+ohhFFElmxm0bXrNPcVXhjnCGg+i09Hb XkZ4sg2T8lecK/xuaUJmrYHE4bAq+BerAe+ddjZZftdwmjYXmrDTKFaQM9uedyjcsU2/ aVwQ== X-Gm-Message-State: AOAM532ip953UcFiAJkaeshYchWLy88esWt3gFYWVZZbn9LzbgAiTYsZ W8J8bfIAEj2ydqdAz3WlHvRNsg== X-Google-Smtp-Source: ABdhPJzg20qb9a+Ybr7TF4ypEki2FuEqdvc/xuJbZLJAsHcRCb8z666rTPDEit0AaJ/bngQEhb9v4A== X-Received: by 2002:a17:902:c3c4:b0:158:85b8:1459 with SMTP id j4-20020a170902c3c400b0015885b81459mr10287875plj.10.1649870728392; Wed, 13 Apr 2022 10:25:28 -0700 (PDT) Received: from localhost ([2620:15c:202:201:6a4f:9277:743f:c648]) by smtp.gmail.com with UTF8SMTPSA id f19-20020a056a00229300b004fb157f136asm44017370pfe.153.2022.04.13.10.25.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 10:25:28 -0700 (PDT) Date: Wed, 13 Apr 2022 10:25:26 -0700 From: Matthias Kaehlcke To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, Venkata Prasad Potturu Subject: Re: [PATCH v9 2/2] arm64: dts: qcom: sc7280: add lpass lpi pin controller node Message-ID: References: <1649861047-7811-1-git-send-email-quic_srivasam@quicinc.com> <1649861047-7811-3-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1649861047-7811-3-git-send-email-quic_srivasam@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 13, 2022 at 08:14:07PM +0530, Srinivasa Rao Mandadapu wrote: > Add LPASS LPI pinctrl node required for Audio functionality on sc7280 > based platforms. > > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 84 ++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 +++++++++++++++++++++++++++++++ > 2 files changed, 191 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 6e6cfeda..50fea0e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1987,6 +1987,113 @@ > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > + lpass_tlmm: pinctrl@33c0000 { > + compatible = "qcom,sc7280-lpass-lpi-pinctrl"; > + reg = <0 0x033c0000 0x0 0x20000>, > + <0 0x03550000 0x0 0x10000>; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&lpass_tlmm 0 0 15>; > + > + #clock-cells = <1>; > + > + lpass_dmic01: lpass-dmic01 { For the node names the 'lpass-' prefix is redundant as you remarked earlier, since they are inside the 'lpass_tlmm' node. It's only useful for the labels, which can be used in other .dts[i] files where the context might not be evident.