From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 947FFC433F5
	for <linux-devicetree@archiver.kernel.org>; Wed, 13 Apr 2022 17:45:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233587AbiDMRr2 (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Wed, 13 Apr 2022 13:47:28 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54262 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234745AbiDMRr2 (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Wed, 13 Apr 2022 13:47:28 -0400
Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 313962E9DA
        for <devicetree@vger.kernel.org>; Wed, 13 Apr 2022 10:45:04 -0700 (PDT)
Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236])
        by mx2.smtp.larsendata.com (Halon) with ESMTPS
        id 742f4b48-bb51-11ec-9ac0-0050568cd888;
        Wed, 13 Apr 2022 17:45:05 +0000 (UTC)
Received: from mailproxy2.cst.dirpod3-cph3.one.com (mailproxy2.pub.dirpod3-cph3.one.com [104.37.34.119])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        (Authenticated sender: sam@ravnborg.org)
        by mail01.mxhotel.dk (Postfix) with ESMTPSA id 519B3194BE0;
        Wed, 13 Apr 2022 19:45:03 +0200 (CEST)
Date:   Wed, 13 Apr 2022 19:44:59 +0200
X-Report-Abuse-To: abuse@mxhotel.dk
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: panel-timing: Define a single type
 for properties
Message-ID: <YlcMG0sxMG0AXb4y@ravnborg.org>
References: <20220413140016.3131013-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220413140016.3131013-1-robh@kernel.org>
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

Hi Rob,

On Wed, Apr 13, 2022 at 09:00:15AM -0500, Rob Herring wrote:
> It's not good practice to define multiple types for the same property, so
> factor out the type reference making the properties always an uint32-array
> with a length of 1 or 3 items.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Looks good,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Let me know if we shall take it in drm-misc.

	Sam