From: Rob Herring <robh@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP}
Date: Wed, 20 Apr 2022 10:14:50 -0500 [thread overview]
Message-ID: <YmAjamb4yIqieK/N@robh.at.kernel.org> (raw)
In-Reply-To: <20220420130205.89435-1-nuno.sa@analog.com>
On Wed, 20 Apr 2022 15:02:05 +0200, Nuno Sá wrote:
> We should not break overlay notifications on NOTIFY_{OK|STOP}
> otherwise we might break on the first fragment. We should only stop
> notifications if a *real* errno is returned by one of the listeners.
>
> Fixes: a1d19bd4cf1fe ("of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> v2:
> * Only break fragment notification in case errno is returned from
> notifier;
> * Massaged commit message accordingly.
>
> drivers/of/overlay.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2022-04-20 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 13:02 [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP} Nuno Sá
2022-04-20 15:14 ` Rob Herring [this message]
2022-04-20 15:53 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmAjamb4yIqieK/N@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=nuno.sa@analog.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).