From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF128C433F5 for ; Wed, 20 Apr 2022 15:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238205AbiDTPRl (ORCPT ); Wed, 20 Apr 2022 11:17:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349438AbiDTPRj (ORCPT ); Wed, 20 Apr 2022 11:17:39 -0400 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BED7DD65 for ; Wed, 20 Apr 2022 08:14:52 -0700 (PDT) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-e2afb80550so2270863fac.1 for ; Wed, 20 Apr 2022 08:14:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nWb9/WVcEmPo0bmd0sYdCPiStj4lXNH3Dz8pZCqL0gA=; b=22QwxSAYVjtDrLlQQvtp2ZMyJ36mMJlWcWbt7O6eKJxjzkiFRraBg4T5tMmCasN0Iy FfB/1W3ua8HkWgE1LY6fMDWOUUc19XcTWsyJzfeI3HCpRJXgbaCRHkU11zRfEHyU31Jf BEbreYMJjZETIR/7/4XXS63y8dogTGx+aeMFhDxhY9C0qfrOqN5XsjuDoX52Uv1ri0x6 Zl2Op3MVSIsOcq3BU0ar59lv7kzu5L6A5vsOlXTYCtaLKMuU1OWJWAOZVt/fitcRNQ9R GhQw6yhyNo3B6M8KzAYAZOcNeLow8nGZ/pektjI2V8jUis/Vz3sM3y+oxaVooX0KXs6g r69w== X-Gm-Message-State: AOAM532mO35Wn69uJPCZvwzFbWoyQ04T0ugKSE8hVNmscY4HfLxY9JY7 UdNa4h8cMChY4oa/skaT3URBzYWwMQ== X-Google-Smtp-Source: ABdhPJy41IcHpp6ofMSowmRS91xupevqsvIOc6LmYXB03RMmUr76sz2uvzOiypeJo/pAL3vbkG/ffQ== X-Received: by 2002:a05:6870:d785:b0:d2:823a:94df with SMTP id bd5-20020a056870d78500b000d2823a94dfmr1770673oab.93.1650467692037; Wed, 20 Apr 2022 08:14:52 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 5-20020a9d0105000000b005fbe5093eb0sm6614626otu.54.2022.04.20.08.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 08:14:51 -0700 (PDT) Received: (nullmailer pid 1317456 invoked by uid 1000); Wed, 20 Apr 2022 15:14:50 -0000 Date: Wed, 20 Apr 2022 10:14:50 -0500 From: Rob Herring To: Nuno =?iso-8859-1?Q?S=E1?= Cc: Rob Herring , devicetree@vger.kernel.org, Pantelis Antoniou , Frank Rowand Subject: Re: [PATCH v2] of: overlay: do not break notify on NOTIFY_{OK|STOP} Message-ID: References: <20220420130205.89435-1-nuno.sa@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220420130205.89435-1-nuno.sa@analog.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 20 Apr 2022 15:02:05 +0200, Nuno Sá wrote: > We should not break overlay notifications on NOTIFY_{OK|STOP} > otherwise we might break on the first fragment. We should only stop > notifications if a *real* errno is returned by one of the listeners. > > Fixes: a1d19bd4cf1fe ("of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove") > Signed-off-by: Nuno Sá > --- > v2: > * Only break fragment notification in case errno is returned from > notifier; > * Massaged commit message accordingly. > > drivers/of/overlay.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Applied, thanks!