devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Puranjay Mohan <p-mohan@ti.com>
Cc: linux-kernel@vger.kernel.org, nm@ti.com,
	devicetree@vger.kernel.org, grygorii.strashko@ti.com,
	vigneshr@ti.com, mathieu.poirier@linaro.org, kishon@ti.com,
	linux-remoteproc@vger.kernel.org, bjorn.andersson@linaro.org,
	rogerq@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/6] soc: ti: pruss: Add helper function to enable OCP master ports
Date: Thu, 21 Apr 2022 09:51:10 +0300	[thread overview]
Message-ID: <YmD+3svXUIHiX6DJ@atomide.com> (raw)
In-Reply-To: <20220418123004.9332-6-p-mohan@ti.com>

* Puranjay Mohan <p-mohan@ti.com> [220418 12:35]:
> From: Suman Anna <s-anna@ti.com>
> +/**
> + * pruss_cfg_ocp_master_ports() - configure PRUSS OCP master ports
> + * @pruss: the pruss instance handle
> + * @enable: set to true for enabling or false for disabling the OCP master ports
> + *
> + * This function programs the PRUSS_SYSCFG.STANDBY_INIT bit either to enable or
> + * disable the OCP master ports (applicable only on SoCs using OCP interconnect
> + * like the OMAP family). Clearing the bit achieves dual functionalities - one
> + * is to deassert the MStandby signal to the device PRCM, and the other is to
> + * enable OCP master ports to allow accesses outside of the PRU-ICSS. The
> + * function has to wait for the PRCM to acknowledge through the monitoring of
> + * the PRUSS_SYSCFG.SUB_MWAIT bit when enabling master ports. Setting the bit
> + * disables the master access, and also signals the PRCM that the PRUSS is ready
> + * for Standby.

Looks OK to me, some comments regarding runtime PM though for future patching
though.

Eventually we may want to handle this in drivers/bus/ti-sysc.c so it gets toggled
based on runtime PM. The PRUSS sysc register seems to be just a new variant of
sysc_regbits_omap4_simple with the standby and status bits added.

If using runtime PM for the PRUSS instance is not suitable for managing the
standby and status bits, then some comments should be added describing why
finer grained control is needed for these bits beyond runtime PM.

As far as I'm concerned, these can be done in separate changes, no need to update
this patch.

Regards,

Tony

  reply	other threads:[~2022-04-21  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18 12:29 [PATCH v2 0/6] Introduce PRU platform consumer API Puranjay Mohan
2022-04-18 12:29 ` [PATCH v2 1/6] soc: ti: pruss: Add pruss_get()/put() API Puranjay Mohan
2022-04-18 12:30 ` [PATCH v2 2/6] soc: ti: pruss: Add pruss_{request,release}_mem_region() API Puranjay Mohan
2022-04-18 12:30 ` [PATCH v2 3/6] soc: ti: pruss: Add pruss_cfg_read()/update() API Puranjay Mohan
2022-04-18 12:30 ` [PATCH v2 4/6] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Puranjay Mohan
2022-04-18 12:30 ` [PATCH v2 5/6] soc: ti: pruss: Add helper function to enable OCP master ports Puranjay Mohan
2022-04-21  6:51   ` Tony Lindgren [this message]
2022-04-18 12:30 ` [PATCH v2 6/6] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX Puranjay Mohan
2022-09-12 14:20   ` Romain Naour
2022-09-14 13:15     ` Roger Quadros
2022-09-15  8:27       ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmD+3svXUIHiX6DJ@atomide.com \
    --to=tony@atomide.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=nm@ti.com \
    --cc=p-mohan@ti.com \
    --cc=rogerq@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).