From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD834C433F5 for ; Thu, 21 Apr 2022 16:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbiDUQrM (ORCPT ); Thu, 21 Apr 2022 12:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232178AbiDUQrM (ORCPT ); Thu, 21 Apr 2022 12:47:12 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 456ED48E7A for ; Thu, 21 Apr 2022 09:44:21 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id u5so2361146pjr.5 for ; Thu, 21 Apr 2022 09:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ELrSMlHFtMr5kTiuEuv+v5IwZOU2TDWewVy3+3i8s+E=; b=KGbMcRgRVToQtVkjHO4X6veWbWQOAwSpRFDSPahDREaw8P+kwEX/89n3V0OTGM0Uou QbptTZV5mKecQo+7kf5FNr38e6rFYigrGzUj5VaSUqI8lb5cZqDw2g4YmggdZo44oKOI 7sHzHDXx8zsaJpLGIa8AwryBhmTFDvgOFG7oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ELrSMlHFtMr5kTiuEuv+v5IwZOU2TDWewVy3+3i8s+E=; b=r5P3RzPpUzUlItpMKbtybjQkjspLdvOQCN/zb8/tpVWhjh0W7TYVOH7bqYyzCx7K4V BGO0W62Knf33hTNSyW+jMvwS3u1DIA8Q55ciVuxYgb/8BjK5Af/xosSeU0orfVRLq0c9 ha4y0EgkFXta9raAQJ3TNn7ws5wC+f2blL291oS9CVzLQSDawuB0N6s0W/2my2gEzP5C Wl7AhEEgsjk+IVv0reeCDwaz13pNTynJGeBUdbcM3WHg6CcyEo+L712MQhjnj+TkfJfc oLDSAQ1IdD2s8G+vM+m0Ab8c1v38eElADIBTwDwL915p+t9yXTeAVYJIqVaNsBKmrnWh Ho9Q== X-Gm-Message-State: AOAM533JxEpAOgL13WRanYHVIUHKSukmj2GRN0V5nmVWQCU+b6WLAXiW 9PyIMa+XmO+8GZbYEyxRfNfCOQ== X-Google-Smtp-Source: ABdhPJxfPWDW/DraNE8nAfBADhJNDVA05IUQjX3jYZ2vzr+l27XEwmhTSGKXVZCxzJBPThn6PPI/Gw== X-Received: by 2002:a17:902:f789:b0:156:5f56:ddff with SMTP id q9-20020a170902f78900b001565f56ddffmr403635pln.116.1650559460787; Thu, 21 Apr 2022 09:44:20 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d426:5807:a72:7b27]) by smtp.gmail.com with UTF8SMTPSA id y21-20020a631815000000b0039fcedd7bedsm24624449pgl.41.2022.04.21.09.44.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 09:44:20 -0700 (PDT) Date: Thu, 21 Apr 2022 09:44:18 -0700 From: Matthias Kaehlcke To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, Venkata Prasad Potturu Subject: Re: [PATCH v9 04/12] arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0 and CRD 2.0 Message-ID: References: <1650552459-21077-1-git-send-email-quic_srivasam@quicinc.com> <1650552459-21077-5-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1650552459-21077-5-git-send-email-quic_srivasam@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 21, 2022 at 08:17:31PM +0530, Srinivasa Rao Mandadapu wrote: > arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0 and CRD 2.0 nit: and IDP boards? > Add wcd9385 codec node for audio use case on sc7280 based platforms > of revision 3 and 4 (aka CRD 1.0 and 2.0). > Add tlmm gpio property for switching CTIA/OMTP Headset. > > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu > --- > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 8 +++++ > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 50 ++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > index 344338a..462d655 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > @@ -87,6 +87,14 @@ ap_ts_pen_1v8: &i2c13 { > pins = "gpio51"; > }; > > +&wcd938x { > + pinctrl-names = "default", "sleep", "us_euro_hs_sel"; > + pinctrl-0 = <&wcd_reset_n>; > + pinctrl-1 = <&wcd_reset_n_sleep>; > + pinctrl-2 = <&us_euro_hs_sel>; Which driver is supposed to select 'us_euro_hs_sel'? I suppose 'us_euro_hs_sel' should always be configured in the same way, so you probably want this: pinctrl-names = "default", "sleep"; pinctrl-0 = <&wcd_reset_n>, <&us_euro_hs_sel>; pinctrl-1 = <&wcd_reset_n_sleep>, <&us_euro_hs_sel>; > + us-euro-gpios = <&tlmm 81 GPIO_ACTIVE_HIGH>; > +}; > + > &tlmm { > tp_int_odl: tp-int-odl { > pins = "gpio7"; > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 6cb5fc4..b711ad0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -20,6 +20,34 @@ > serial1 = &uart7; > }; > > + wcd938x: audio-codec-1 { > + compatible = "qcom,wcd9385-codec"; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&wcd_reset_n>; > + pinctrl-1 = <&wcd_reset_n_sleep>; > + > + reset-gpios = <&tlmm 83 GPIO_ACTIVE_HIGH>; > + > + qcom,rx-device = <&wcd_rx>; > + qcom,tx-device = <&wcd_tx>; > + > + vdd-rxtx-supply = <&vreg_l18b_1p8>; > + vdd-io-supply = <&vreg_l18b_1p8>; > + vdd-buck-supply = <&vreg_l17b_1p8>; > + vdd-mic-bias-supply = <&vreg_bob>; > + > + qcom,micbias1-microvolt = <1800000>; > + qcom,micbias2-microvolt = <1800000>; > + qcom,micbias3-microvolt = <1800000>; > + qcom,micbias4-microvolt = <1800000>; > + > + qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 > + 500000 500000 500000>; > + qcom,mbhc-headset-vthreshold-microvolt = <1700000>; > + qcom,mbhc-headphone-vthreshold-microvolt = <50000>; > + #sound-dai-cells = <1>; > + }; > + > gpio-keys { > compatible = "gpio-keys"; > label = "gpio-keys"; > @@ -678,6 +706,28 @@ > function = "gpio"; > bias-pull-down; > }; > + > + us_euro_hs_sel: us-euro-hs-sel { > + pins = "gpio81"; > + function = "gpio"; > + bias-pull-down; > + drive-strength = <2>; > + }; This config is only used by the CRD, move it to sc7280-crd-r3.dts > + > + wcd_reset_n: wcd-reset-n { > + pins = "gpio83"; > + function = "gpio"; > + drive-strength = <8>; > + output-high; > + }; > + > + wcd_reset_n_sleep: wcd-reset-n-sleep { > + pins = "gpio83"; > + function = "gpio"; > + drive-strength = <8>; > + bias-disable; > + output-low; > + }; > }; > > &remoteproc_wpss { > -- > 2.7.4 >