From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0692C433F5 for ; Thu, 21 Apr 2022 21:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346896AbiDUWC1 (ORCPT ); Thu, 21 Apr 2022 18:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442261AbiDUWC0 (ORCPT ); Thu, 21 Apr 2022 18:02:26 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6D994ECE2; Thu, 21 Apr 2022 14:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=c0TEmygZCtd+n0FX1o8Qr5nSlGas+Hdc6UmjMRNu/Gc=; b=5DNfXsm5ExHsM60ji21p30uJuI fvi96AqvXveUD5bsgMTDTU5YJ5eSTcbyXUtHXrZ33qmOUATizHZWghIjfI8uoNzn3a3Jc8RPcl7Ou iijYrRvqqt4f3vMipgJkc7Dzm5OCpdAU1amAxsrPdQSNORdN9vP/xYKWQ9Qy5rVfJLIc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nhepk-00Grma-Oc; Thu, 21 Apr 2022 23:59:28 +0200 Date: Thu, 21 Apr 2022 23:59:28 +0200 From: Andrew Lunn To: Sean Anderson Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Shawn Guo , Rob Herring , Michael Walle , Krzysztof Kozlowski , Li Yang , linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: Re: [PATCH 3/8] dt-bindings: nvmem: sfp: Add TA_PROG_SFP supply Message-ID: References: <20220421175657.1259024-1-sean.anderson@seco.com> <20220421175657.1259024-4-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421175657.1259024-4-sean.anderson@seco.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 21, 2022 at 01:56:52PM -0400, Sean Anderson wrote: > The TA_PROG_SFP supply must be enabled to program the fuses, and > disabled to read the fuses (such as at power-on-reset). On many boards, > this supply is controlled by a jumper. The user must manually insert or > remove it at the appropriate time in the programming process. However, > on other boards this supply is controlled by and FPGA or a GPIO. In > these cases, the driver can automatically enabled and disable it as > necessary. > > Signed-off-by: Sean Anderson > --- > > .../devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml > index 54086f50157d..e7d1232fcd41 100644 > --- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml > +++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml > @@ -32,6 +32,11 @@ properties: > clock-names: > const: sfp > > + ta-prog-sfp-supply: > + description: > + The TA_PROG_SFP supply. It will be enabled for programming and disabled > + for reading. > + Doesn't there need to be some indication what this is? Is it a GPIO, or maybe a regulator? Andrew