From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
xinlei.lee@mediatek.com, lee.jones@linaro.org,
robh+dt@kernel.org, matthias.bgg@gmail.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rex-bc.chen@mediatek.com,
jitao.shi@mediatek.com,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192
Date: Fri, 22 Apr 2022 18:57:04 +0200 [thread overview]
Message-ID: <YmLeYOOCNciqhykt@orome> (raw)
In-Reply-To: <20220421134808.sqnecvysuzlgdsz5@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Thu, Apr 21, 2022 at 03:48:08PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> > Il 18/04/22 14:20, xinlei.lee@mediatek.com ha scritto:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add interrupts property of pwm for MediaTek MT8192 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Hello Xinlei,
> > the pwm-mtk-disp.c driver does not support interrupts.
> >
> > Please add interrupts support to the driver first, and only then
> > add that in the dt-bindings.
>
> in my understanding the linux driver state and the binding documentation
> are somewhat independent. Here I'd say adding the irq information to dt
> without the driver supporting it is fine.
Agreed. I've applied this along with the rest. It doesn't have Rob's or
Krzysztof's stamp of approval, but it's a trivial change and looks fine
to me.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-22 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 12:20 [PATCH v6,0/5] Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format xinlei.lee
2022-04-18 12:20 ` [PATCH v6,1/5] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
2022-04-18 12:20 ` [PATCH v6,2/5] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
2022-04-18 12:20 ` [PATCH v6,3/5] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
2022-04-18 12:20 ` [PATCH v6,4/5] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
2022-04-18 12:20 ` [PATCH v6,5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192 xinlei.lee
2022-04-21 10:17 ` [PATCH v6, 5/5] " AngeloGioacchino Del Regno
2022-04-21 13:48 ` Uwe Kleine-König
2022-04-22 16:57 ` Thierry Reding [this message]
2022-04-22 16:55 ` [PATCH v6,0/5] Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmLeYOOCNciqhykt@orome \
--to=thierry.reding@gmail.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jitao.shi@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).