From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5FDC433EF for ; Fri, 22 Apr 2022 22:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233912AbiDVWj3 (ORCPT ); Fri, 22 Apr 2022 18:39:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233601AbiDVWie (ORCPT ); Fri, 22 Apr 2022 18:38:34 -0400 Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5003327BD03 for ; Fri, 22 Apr 2022 14:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=LwlU40XotA1nBo9aBTZeYjcwTzaZNnyNJyXy4ofmuGM=; b=XGd/ddQUlgsno2GCtZUjjFWT7z0Qkeg0mlhyS9u7n+/+DLi6vbcc1T2zLAQk+ul4hcIMiXUAT4Fhw kjJfzlXGSB7dHUPx4Y8TVII/C5aKlb+VJ9BAQLK2zoTMWGlxF6jCOwkojS6atrd1GSyJJaS/QHPLUl Fp0hcofdNEHV1nnFRXG33I7HMaQdpFsJ8p4gXhMtmhCnOGSnhI7Bl6S4YT8dADRA26kVgXkxRiZbRF Jdf2JMFhpSLmkWHr5Cn1Q6Yn3Mqul+TBWxbzZXXO1Rr9onCvzzHW7Gf1KJuI3LTSlgmfpgZdfYo2DF ioHI6532Xk498ayoYQ5JCiCEa/qv4Dw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=LwlU40XotA1nBo9aBTZeYjcwTzaZNnyNJyXy4ofmuGM=; b=hGYf4mv/zZqNcNNgXkkau7R0O+Yxaws+yRBN2v84NNowMoCpjcTp0rQk/tJXmBynNhqIGs5QQBPDC JqbN9hwAQ== X-HalOne-Cookie: 49d5a337dfd7411a6073e858fb795eaf22434d3f X-HalOne-ID: bf8828c3-c269-11ec-be69-d0431ea8bb03 Received: from mailproxy1.cst.dirpod4-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id bf8828c3-c269-11ec-be69-d0431ea8bb03; Fri, 22 Apr 2022 18:26:38 +0000 (UTC) Date: Fri, 22 Apr 2022 20:26:36 +0200 From: Sam Ravnborg To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Laurent Pinchart , Lucas Stach , Maxime Ripard , Peng Fan , Rob Herring , Robby Cai , Robert Foss , Thomas Zimmermann , devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: display: bridge: ldb: Implement simple NXP i.MX8M LDB bridge Message-ID: References: <20220418145105.76986-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220418145105.76986-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, I read the patch once more. On Mon, Apr 18, 2022 at 04:51:04PM +0200, Marek Vasut wrote: > The i.MX8MP contains two syscon registers which are responsible Here it says i.MX8MP > for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding > which represents this serializer as a bridge. > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Maxime Ripard > Cc: Peng Fan > Cc: Rob Herring > Cc: Robby Cai > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > V2: - Consistently use fsl,imx8mp-ldb as compatible > - Drop items: from compatible: > - Replace minItems with maxItems in clocks: > - Drop quotes from clock-names const: ldb > - Rename syscon to fsl,syscon > - Use generic name of ldb-lvds in example > --- > .../bindings/display/bridge/nxp,ldb.yaml | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml > new file mode 100644 > index 0000000000000..f3182566eb316 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml > @@ -0,0 +1,96 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/nxp,ldb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M DPI to LVDS bridge chip Here it says i.MX8M > + > +maintainers: > + - Marek Vasut > + > +description: | > + The i.MX8MP contains two syscon registers which are responsible Here it says i.MX8MP > + for configuring the on-SoC DPI-to-LVDS serializer. This describes > + those registers as bridge within the DT. > + > +properties: > + compatible: > + const: fsl,imx8mp-ldb Here it says fsl,imx8mp It looks a little inconsistent, I guess the title needs a fix. a-b stands with the title fixed. Sam > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ldb > + > + fsl,syscon: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: A phandle to media block controller. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for DPI input. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for LVDS Channel-A output (panel or bridge). > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for LVDS Channel-B output (panel or bridge). > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - clocks > + - fsl,syscon > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + bridge { > + compatible = "fsl,imx8mp-ldb"; > + clocks = <&clk IMX8MP_CLK_MEDIA_LDB>; > + clock-names = "ldb"; > + fsl,syscon = <&media_blk_ctrl>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + ldb_from_lcdif2: endpoint { > + remote-endpoint = <&lcdif2_to_ldb>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + ldb_lvds_ch0: endpoint { > + remote-endpoint = <&ldb_to_lvdsx4panel>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + > + ldb_lvds_ch1: endpoint { > + }; > + }; > + }; > + }; > -- > 2.35.1