From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F13C433EF for ; Fri, 22 Apr 2022 22:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232584AbiDVWZe (ORCPT ); Fri, 22 Apr 2022 18:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbiDVWZI (ORCPT ); Fri, 22 Apr 2022 18:25:08 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 021EA2A7429; Fri, 22 Apr 2022 14:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XSpt1IJ1KFQ65bi+jyiXwQSZangsC0Zf0U2JxFg+R7I=; b=ELivqPkObppEztRJnsptUc9UsI akAJaMckp1HEg+hvy+lMYW1VvCWv6w8Hrj8Loib1tTVEkcEWgzuKU18Top0de6EDDJlXIQIls4rne 6cOONwv2lRxXV3V0PDQ1YY8gESxsggllQvE+ylPsNrqH/vOexLMRLZ3+X2FfSbJ3dj5w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nhzuM-00H2Yn-4L; Fri, 22 Apr 2022 22:29:38 +0200 Date: Fri, 22 Apr 2022 22:29:38 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next 0/5] net: ipqess: introduce Qualcomm IPQESS driver Message-ID: References: <20220422180305.301882-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422180305.301882-1-maxime.chevallier@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Apr 22, 2022 at 08:03:00PM +0200, Maxime Chevallier wrote: > Hello everyone, > > This series introduces a new driver, for the Qualcomm IPQESS Ethernet > Controller, found on the IPQ4019. > > The driver itself is pretty straightforward, but has lived out-of-tree > for a while. I've done my best to clean-up some outdated API calls, but > some might remain. > > This controller is somewhat special, since it's part of the IPQ4019 SoC > which also includes an QCA8K switch, and uses the IPQESS controller for > the CPU port. Does it exist in a form where it is not connected to a switch? As Florian has suggested, if we assume frames are always going to/coming from a switch, we can play around with the frame format a little. A dummy tag could be added to the head or tail of the frame, which the MAC driver then uses. That gives us a more normal structure. Andrew