* [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node
@ 2022-04-21 14:19 Srinivasa Rao Mandadapu
2022-04-21 16:20 ` Doug Anderson
2022-04-23 15:58 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-04-21 14:19 UTC (permalink / raw)
To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel, quic_rohkumar, srinivas.kandagatla, dianders,
swboyd, judyhsiao, quic_rjendra
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
Add ldo_l17b in pm7325 regulator, which is required for
wcd codec vdd buck supply.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index b833ba1..17d0c05 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -113,6 +113,11 @@
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
+ vreg_l17b_1p8: ldo17 {
+ regulator-min-microvolt = <1700000>;
+ regulator-max-microvolt = <1900000>;
+ };
+
vdd_px_wcd9385:
vdd_txrx:
vddpx_0:
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node
2022-04-21 14:19 [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node Srinivasa Rao Mandadapu
@ 2022-04-21 16:20 ` Doug Anderson
2022-04-22 9:35 ` Srinivasa Rao Mandadapu
2022-04-23 15:58 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2022-04-21 16:20 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
quic_rohkumar, Srinivas Kandagatla, Stephen Boyd, Judy Hsiao,
Rajendra Nayak, Venkata Prasad Potturu
Hi,
On Thu, Apr 21, 2022 at 7:20 AM Srinivasa Rao Mandadapu
<quic_srivasam@quicinc.com> wrote:
>
> Add ldo_l17b in pm7325 regulator, which is required for
> wcd codec vdd buck supply.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
The ${SUBJECT} should probably mention qcard somehow? Right now your
patch subject makes it sound like this applies to all sc7280 boards,
but this only affects those including the qcard dtsi file.
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index b833ba1..17d0c05 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -113,6 +113,11 @@
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> + vreg_l17b_1p8: ldo17 {
> + regulator-min-microvolt = <1700000>;
> + regulator-max-microvolt = <1900000>;
All the other regulators in this file specify:
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
Why doesn't yours?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node
2022-04-21 16:20 ` Doug Anderson
@ 2022-04-22 9:35 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 5+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-04-22 9:35 UTC (permalink / raw)
To: Doug Anderson
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
quic_rohkumar, Srinivas Kandagatla, Stephen Boyd, Judy Hsiao,
Rajendra Nayak, Venkata Prasad Potturu
Thanks for your time Doug!!!
On 4/21/2022 9:50 PM, Doug Anderson wrote:
> Hi,
>
> On Thu, Apr 21, 2022 at 7:20 AM Srinivasa Rao Mandadapu
> <quic_srivasam@quicinc.com> wrote:
>> Add ldo_l17b in pm7325 regulator, which is required for
>> wcd codec vdd buck supply.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
> The ${SUBJECT} should probably mention qcard somehow? Right now your
> patch subject makes it sound like this applies to all sc7280 boards,
> but this only affects those including the qcard dtsi file.
Okay. Will update the subject accordingly.
>
>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> index b833ba1..17d0c05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> @@ -113,6 +113,11 @@
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> };
>>
>> + vreg_l17b_1p8: ldo17 {
>> + regulator-min-microvolt = <1700000>;
>> + regulator-max-microvolt = <1900000>;
> All the other regulators in this file specify:
>
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>
> Why doesn't yours?
Okay. Will add initial mode.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node
2022-04-21 14:19 [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node Srinivasa Rao Mandadapu
2022-04-21 16:20 ` Doug Anderson
@ 2022-04-23 15:58 ` Bjorn Andersson
2022-04-25 5:17 ` Srinivasa Rao Mandadapu
1 sibling, 1 reply; 5+ messages in thread
From: Bjorn Andersson @ 2022-04-23 15:58 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, robh+dt, linux-arm-msm, devicetree, linux-kernel,
quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao,
quic_rjendra, Venkata Prasad Potturu
On Thu 21 Apr 09:19 CDT 2022, Srinivasa Rao Mandadapu wrote:
> Add ldo_l17b in pm7325 regulator, which is required for
> wcd codec vdd buck supply.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index b833ba1..17d0c05 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -113,6 +113,11 @@
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> + vreg_l17b_1p8: ldo17 {
> + regulator-min-microvolt = <1700000>;
> + regulator-max-microvolt = <1900000>;
Can you confirm that this doesn't need to be in HPM mode?
Thanks,
Bjorn
> + };
> +
> vdd_px_wcd9385:
> vdd_txrx:
> vddpx_0:
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node
2022-04-23 15:58 ` Bjorn Andersson
@ 2022-04-25 5:17 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 5+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-04-25 5:17 UTC (permalink / raw)
To: Bjorn Andersson
Cc: agross, robh+dt, linux-arm-msm, devicetree, linux-kernel,
quic_rohkumar, srinivas.kandagatla, dianders, swboyd, judyhsiao,
quic_rjendra, Venkata Prasad Potturu
On 4/23/2022 9:28 PM, Bjorn Andersson wrote:
Thanks for your time Bjorn!!
> On Thu 21 Apr 09:19 CDT 2022, Srinivasa Rao Mandadapu wrote:
>
>> Add ldo_l17b in pm7325 regulator, which is required for
>> wcd codec vdd buck supply.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> index b833ba1..17d0c05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> @@ -113,6 +113,11 @@
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> };
>>
>> + vreg_l17b_1p8: ldo17 {
>> + regulator-min-microvolt = <1700000>;
>> + regulator-max-microvolt = <1900000>;
> Can you confirm that this doesn't need to be in HPM mode?
HPM mode included and sent V2 patch.
>
> Thanks,
> Bjorn
>
>> + };
>> +
>> vdd_px_wcd9385:
>> vdd_txrx:
>> vddpx_0:
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-25 5:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-21 14:19 [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node Srinivasa Rao Mandadapu
2022-04-21 16:20 ` Doug Anderson
2022-04-22 9:35 ` Srinivasa Rao Mandadapu
2022-04-23 15:58 ` Bjorn Andersson
2022-04-25 5:17 ` Srinivasa Rao Mandadapu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).