From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10BBC433F5 for ; Mon, 25 Apr 2022 07:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231397AbiDYIBh (ORCPT ); Mon, 25 Apr 2022 04:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236082AbiDYIBW (ORCPT ); Mon, 25 Apr 2022 04:01:22 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C48CE27CC1 for ; Mon, 25 Apr 2022 00:58:14 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id ay11-20020a05600c1e0b00b0038eb92fa965so11926732wmb.4 for ; Mon, 25 Apr 2022 00:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+bRYkBAn8sJsc8S2sn1YixNkNlBLK97NL9Q4uOqNbl8=; b=x6WtLuYWYuF97BgnCNc9JW0y/6GvCi2/ay6eRQNC9ttlaB8lhAbKfcDwpy37nGsXY4 2U6CQsQLXByP3D/B9vOuWvUgDAsCSFYbYPXCwvL0xFnCOSkatlifKdOKSsXwQy2VEqr6 uwvUOcmk9sRh5M4iDm2ZsIgYhTzI/OCPB34c4gyy9vY9ihgO5c5Laq0ok43mVDSm1rzd wSkV5jUxyDGp3P0yRMLK30v1vOxg347tCfv3GQw6g5pVKg1mCVOWdmMVukOoPKLxKHhP 9v2SUzF3Z1V1X/7iQulzKuMe4S9FHgR1s8YnKIxrFi9zY2EBlDDxcX/ffnWQ1NJa3dmi yL2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+bRYkBAn8sJsc8S2sn1YixNkNlBLK97NL9Q4uOqNbl8=; b=1wWjMTM9LYUGQIPquw9sgZXmoIqF+adyhLSZL4kDqccorbzYeo4FfkHRLaLDAte2VV w2Zvxnp6sx/uLCPR+0HBTjY89dm74cONoNeKVnPZmGnmnf56rKIUXuWaSU6Z0dgkNmrg qMRuAeRw0ofaNBnp5iw74wcPz1uNdPAq9IH7+mFNe0t+OfTdE26j1FDaC+P/snMZB/7Y POPg62AD1TO2yn6Awnht/GVAP9yHlo8mp8wYEsfVp0Hx0iBBvx3v/cDxYE9ecXPH1xyO oZc9Ai5kshSuSLFjzgF2OkbLKfWB083DPbG63rkWLbr0Ntp/GzwEP6x1YSEKnoz5+67e RhFA== X-Gm-Message-State: AOAM531SxIOi7ikBhNDa+CG0VOLHvtaqCMOCAKLV9LlOB6x4sS7lhA1K 8PMkghhK2mxgWjIgJIqhjRjFZJyWnTHVig== X-Google-Smtp-Source: ABdhPJylAV5y97CjPKk6ZjamGuPD2bl7abNODAPfaYuKP1LaIVk/UKUAWnSA93i5CUWcJx8BlG2U6Q== X-Received: by 2002:a1c:2542:0:b0:38e:b64c:6afb with SMTP id l63-20020a1c2542000000b0038eb64c6afbmr15255147wml.65.1650873492893; Mon, 25 Apr 2022 00:58:12 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id p125-20020a1c2983000000b0038e6c62f527sm9572862wmp.14.2022.04.25.00.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 00:58:12 -0700 (PDT) Date: Mon, 25 Apr 2022 08:58:10 +0100 From: Lee Jones To: Rob Herring Cc: Krzysztof Kozlowski , Peter Rosin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: Drop undocumented i.MX iomuxc-gpr bindings in examples Message-ID: References: <20220422192121.2592030-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220422192121.2592030-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 22 Apr 2022, Rob Herring wrote: > The i.MX iomuxc-gpr bindings are undocumented and a mess. Drop their use > from the examples. > > The problem with the binding beyond the just random variations is that > the iomuxc-gpr is not a separate block, but registers within the iomuxc > block containing random leftover controls. As a separate DT node, it > creates nodes with overlapping memory addresses. > > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 8 -------- > Documentation/devicetree/bindings/mux/reg-mux.yaml | 1 - > 2 files changed, 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 13baa452cc9d..fb784045013f 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -100,12 +100,4 @@ examples: > compatible = "allwinner,sun8i-h3-system-controller", "syscon"; > reg = <0x01c00000 0x1000>; > }; > - > - - | > - gpr: iomuxc-gpr@20e0000 { > - compatible = "fsl,imx6q-iomuxc-gpr", "syscon"; > - reg = <0x020e0000 0x38>; > - hwlocks = <&hwlock1 1>; > - }; > - > ... > diff --git a/Documentation/devicetree/bindings/mux/reg-mux.yaml b/Documentation/devicetree/bindings/mux/reg-mux.yaml > index 60d5746eb39d..df4db96b5391 100644 > --- a/Documentation/devicetree/bindings/mux/reg-mux.yaml > +++ b/Documentation/devicetree/bindings/mux/reg-mux.yaml > @@ -96,7 +96,6 @@ examples: > > #include > syscon@1000 { > - compatible = "fsl,imx7d-iomuxc-gpr", "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd"; > reg = <0x1000 0x100>; Is leaving no compatible the correct solution here? Do we have another (working) platform that we can use in its place? Does it make sense to leave the "syscon" and "simple-mfd" entries? > mux2: mux-controller { -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog