From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6F4C433FE for ; Mon, 25 Apr 2022 15:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242660AbiDYPG5 (ORCPT ); Mon, 25 Apr 2022 11:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242704AbiDYPGy (ORCPT ); Mon, 25 Apr 2022 11:06:54 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7533344C2 for ; Mon, 25 Apr 2022 08:03:48 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id t6so17856192wra.4 for ; Mon, 25 Apr 2022 08:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ewfzCt6PMLpZiYFpWwQvEOwRWap5vYUC7ioVDl1T6I4=; b=KXMKgSm99MB0M6aq9IZrvVG+SM0iCs6ImfcpCqmSy7f0sn2r+J0AGfOo1g5I13uHE1 FRIEgN9KfW/EBqiYOlHFwQeYr44TcUf3g+pJj8qeFnyaeGrHHcldtpOa1OoopaFvGQsD 1yMDUA3yLCimvMHfD16/OVThtJWNW6skR1XFaAwJFtoRN5B1bpJSzcxRKdhMHqU1aBdV nS6zpKjyJUHgLL9jKHDlOB+vYN7sp9x0aY3P4yslp4hbnoMHeAM/S2wXbxbNPk95mnag /HmwlN4Tzf+phhG924ocFLcUEnm31xMiqSprMTEaB4BEfzHVzJ9OAKmSzQxtvtAF5BSF Iskg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ewfzCt6PMLpZiYFpWwQvEOwRWap5vYUC7ioVDl1T6I4=; b=w+shykMdsleFAuUjEWiWajeqlbxuIsJhIP97xl+mQ1TOBraM7WJkZlWAnMHEQuntdo k/I2QIoYh9H5tvdcBWbxS/rP3/+5+FggK/QRdfJht7nRIuTYfAeuDDjNPpxJFV83LERo GdX2Q1o54IN/LYejSPgeeOaaQO2wpx4USQlz2OgojUMCJkYSeVBaoIVNHIkNZbHMvOx7 iGB7JMSOSP2FtRIhrBTEbA4MtMF32Iq/b3UsNP+w9V8UHdmmcc5Eo8wHEuWn93F91ilm 91oN2i7dpH6RfxW+nbhyO3RhsB4IrnoThblCnVwBaHQnjbq9mtf2KOLquFi4z7FIUoVY O4EQ== X-Gm-Message-State: AOAM531K9i5H//OEBh/EiccIMN+gIIXZAYRHhGBobzumNmx/7fY/1fu7 DD2mVJRhrTiGnpTrvGO9zFUMHw== X-Google-Smtp-Source: ABdhPJwUMHiW+olBZWfHEn1Lyj8Ba6MBbFi2T8we3fA/RXD5a2zwfdAtdxvNu9TPPOGi4MzyRKlIYg== X-Received: by 2002:a5d:5309:0:b0:20a:cee3:9e3f with SMTP id e9-20020a5d5309000000b0020acee39e3fmr10981313wrv.570.1650899026767; Mon, 25 Apr 2022 08:03:46 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id v6-20020a056000144600b0020a9a1627e2sm9315232wrx.15.2022.04.25.08.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 08:03:45 -0700 (PDT) Date: Mon, 25 Apr 2022 16:03:43 +0100 From: Lee Jones To: Caleb Connolly Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org, amit.pundir@linaro.org, john.stultz@linaro.org, Krzysztof Kozlowski , Dmitry Baryshkov Subject: Re: [PATCH v13 2/9] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients Message-ID: References: <20220323162820.110806-1-caleb@connolly.tech> <20220323162820.110806-3-caleb@connolly.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220323162820.110806-3-caleb@connolly.tech> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 23 Mar 2022, Caleb Connolly wrote: > From: Caleb Connolly > > Some PMIC functions such as the RRADC need to be aware of the PMIC > chip revision information to implement errata or otherwise adjust > behaviour, export the PMIC information to enable this. > > This is specifically required to enable the RRADC to adjust > coefficients based on which chip fab the PMIC was produced in, > this can vary per unique device and therefore has to be read at > runtime. > > Signed-off-by: Caleb Connolly > Reviewed-by: Dmitry Baryshkov > Tested-by: Dmitry Baryshkov > --- > drivers/mfd/qcom-spmi-pmic.c | 261 +++++++++++++++++++----------- > include/soc/qcom/qcom-spmi-pmic.h | 60 +++++++ > 2 files changed, 231 insertions(+), 90 deletions(-) > create mode 100644 include/soc/qcom/qcom-spmi-pmic.h Apologies for the delay. I've been snowed under. > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index 1cacc00aa6c9..d8e54d9d3448 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -3,11 +3,16 @@ > * Copyright (c) 2014, The Linux Foundation. All rights reserved. > */ > > +#include > +#include > +#include > #include > #include > #include > +#include > #include > #include > +#include > > #define PMIC_REV2 0x101 > #define PMIC_REV3 0x102 > @@ -17,106 +22,151 @@ > > #define PMIC_TYPE_VALUE 0x51 > > -#define COMMON_SUBTYPE 0x00 > -#define PM8941_SUBTYPE 0x01 > -#define PM8841_SUBTYPE 0x02 > -#define PM8019_SUBTYPE 0x03 > -#define PM8226_SUBTYPE 0x04 > -#define PM8110_SUBTYPE 0x05 > -#define PMA8084_SUBTYPE 0x06 > -#define PMI8962_SUBTYPE 0x07 > -#define PMD9635_SUBTYPE 0x08 > -#define PM8994_SUBTYPE 0x09 > -#define PMI8994_SUBTYPE 0x0a > -#define PM8916_SUBTYPE 0x0b > -#define PM8004_SUBTYPE 0x0c > -#define PM8909_SUBTYPE 0x0d > -#define PM8028_SUBTYPE 0x0e > -#define PM8901_SUBTYPE 0x0f > -#define PM8950_SUBTYPE 0x10 > -#define PMI8950_SUBTYPE 0x11 > -#define PM8998_SUBTYPE 0x14 > -#define PMI8998_SUBTYPE 0x15 > -#define PM8005_SUBTYPE 0x18 > -#define PM660L_SUBTYPE 0x1A > -#define PM660_SUBTYPE 0x1B > -#define PM8150_SUBTYPE 0x1E > -#define PM8150L_SUBTYPE 0x1f > -#define PM8150B_SUBTYPE 0x20 > -#define PMK8002_SUBTYPE 0x21 > -#define PM8009_SUBTYPE 0x24 > -#define PM8150C_SUBTYPE 0x26 > -#define SMB2351_SUBTYPE 0x29 > +struct qcom_spmi_dev { > + int num_usids; > + struct qcom_spmi_pmic pmic; > +}; > + > +#define N_USIDS(n) ((void *)n) > > static const struct of_device_id pmic_spmi_id_table[] = { > - { .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE }, > - { .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE }, > - { .compatible = "qcom,pm8004", .data = (void *)PM8004_SUBTYPE }, > - { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, > - { .compatible = "qcom,pm8019", .data = (void *)PM8019_SUBTYPE }, > - { .compatible = "qcom,pm8028", .data = (void *)PM8028_SUBTYPE }, > - { .compatible = "qcom,pm8110", .data = (void *)PM8110_SUBTYPE }, > - { .compatible = "qcom,pm8150", .data = (void *)PM8150_SUBTYPE }, > - { .compatible = "qcom,pm8150b", .data = (void *)PM8150B_SUBTYPE }, > - { .compatible = "qcom,pm8150c", .data = (void *)PM8150C_SUBTYPE }, > - { .compatible = "qcom,pm8150l", .data = (void *)PM8150L_SUBTYPE }, > - { .compatible = "qcom,pm8226", .data = (void *)PM8226_SUBTYPE }, > - { .compatible = "qcom,pm8841", .data = (void *)PM8841_SUBTYPE }, > - { .compatible = "qcom,pm8901", .data = (void *)PM8901_SUBTYPE }, > - { .compatible = "qcom,pm8909", .data = (void *)PM8909_SUBTYPE }, > - { .compatible = "qcom,pm8916", .data = (void *)PM8916_SUBTYPE }, > - { .compatible = "qcom,pm8941", .data = (void *)PM8941_SUBTYPE }, > - { .compatible = "qcom,pm8950", .data = (void *)PM8950_SUBTYPE }, > - { .compatible = "qcom,pm8994", .data = (void *)PM8994_SUBTYPE }, > - { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE }, > - { .compatible = "qcom,pma8084", .data = (void *)PMA8084_SUBTYPE }, > - { .compatible = "qcom,pmd9635", .data = (void *)PMD9635_SUBTYPE }, > - { .compatible = "qcom,pmi8950", .data = (void *)PMI8950_SUBTYPE }, > - { .compatible = "qcom,pmi8962", .data = (void *)PMI8962_SUBTYPE }, > - { .compatible = "qcom,pmi8994", .data = (void *)PMI8994_SUBTYPE }, > - { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE }, > - { .compatible = "qcom,pmk8002", .data = (void *)PMK8002_SUBTYPE }, > - { .compatible = "qcom,smb2351", .data = (void *)SMB2351_SUBTYPE }, > - { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE }, > + { .compatible = "qcom,pm660", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm660l", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8004", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8005", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8019", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8028", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8110", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8150", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8150b", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8150c", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8150l", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8226", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8841", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8901", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8909", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8916", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8941", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8950", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8994", .data = N_USIDS(2) }, > + { .compatible = "qcom,pm8998", .data = N_USIDS(2) }, > + { .compatible = "qcom,pma8084", .data = N_USIDS(2) }, > + { .compatible = "qcom,pmd9635", .data = N_USIDS(2) }, > + { .compatible = "qcom,pmi8950", .data = N_USIDS(2) }, > + { .compatible = "qcom,pmi8962", .data = N_USIDS(2) }, > + { .compatible = "qcom,pmi8994", .data = N_USIDS(2) }, > + { .compatible = "qcom,pmi8998", .data = N_USIDS(2) }, > + { .compatible = "qcom,pmk8002", .data = N_USIDS(2) }, > + { .compatible = "qcom,smb2351", .data = N_USIDS(2) }, > + { .compatible = "qcom,spmi-pmic", .data = N_USIDS(1) }, > { } > }; > > -static void pmic_spmi_show_revid(struct regmap *map, struct device *dev) > +#undef N_USIDS Why is this here? Can't we use a unique macro instead? > +/* > + * A PMIC can be represented by multiple SPMI devices, but > + * only the base PMIC device will contain a reference to > + * the revision information. > + * > + * This function takes a pointer to a function device and > + * returns a pointer to the base PMIC device. > + * > + * This only supports PMICs with 1 or 2 USIDs. > + */ > +static struct spmi_device *qcom_pmic_get_base_usid(struct device *dev) > { > - unsigned int rev2, minor, major, type, subtype; > - const char *name = "unknown"; > - int ret, i; > + struct spmi_device *sdev; > + struct qcom_spmi_dev *ctx; > + struct device_node *spmi_bus; > + struct device_node *other_usid = NULL; > + int function_parent_usid, ret; > + u32 pmic_addr; > > - ret = regmap_read(map, PMIC_TYPE, &type); > - if (ret < 0) > - return; > + if (!of_match_device(pmic_spmi_id_table, dev)) > + return ERR_PTR(-EINVAL); Can this happen? How else would the device have been enumerated? > + sdev = to_spmi_device(dev); > + ctx = spmi_device_get_drvdata(sdev); This function looks like abstraction for the sake of abstraction. Why not just use dev_get_drvdata()? > + /* > + * Quick return if the function device is already in the base > + * USID. This will always be hit for PMICs with only 1 USID. > + */ > + if (sdev->usid % ctx->num_usids == 0) > + return sdev; > + > + function_parent_usid = sdev->usid; > + > + /* > + * Walk through the list of PMICs until we find the sibling USID. > + * The goal is to find the first USID which is less than the > + * number of USIDs in the PMIC away, e.g. for a PMIC with 2 USIDs "array" perhaps? > + * where the function device is under USID 3, we want to find the > + * device for USID 2. > + */ > + spmi_bus = of_get_parent(sdev->dev.of_node); > + do { > + other_usid = of_get_next_child(spmi_bus, other_usid); '\n' > + ret = of_property_read_u32_index(other_usid, "reg", 0, &pmic_addr); > + if (ret) > + return ERR_PTR(ret); '\n' > + sdev = spmi_device_from_of(other_usid); > + if (sdev == NULL) { if (!sdev) > + /* > + * If the base USID for this PMIC hasn't probed yet > + * but the secondary USID has, then we need to defer > + * the function driver so that it will attempt to > + * probe again when the base USID is ready. > + */ > + if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) Double " ". Over-bracketing of statements with matching operands. > + return ERR_PTR(-EPROBE_DEFER); > + > + continue; > + } > + > + if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) > + return sdev; Wouldn't it be better written like this: > + if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) { > + sdev = spmi_device_from_of(other_usid); > + if (!sdev) > + /* > + * If the base USID for this PMIC hasn't probed yet > + * but the secondary USID has, then we need to defer > + * the function driver so that it will attempt to > + * probe again when the base USID is ready. > + */ > + return ERR_PTR(-EPROBE_DEFER); > + return sdev; > + } [...] > + } while (other_usid->sibling); > + > + return ERR_PTR(-ENODATA); > +} > + > +static inline void pmic_print_info(struct device *dev, struct qcom_spmi_pmic *pmic) > +{ > + dev_dbg(dev, "%x: %s v%d.%d\n", > + pmic->subtype, pmic->name, pmic->major, pmic->minor); > +} More abstraction for no apparent reason. > - if (type != PMIC_TYPE_VALUE) > - return; > +static int pmic_spmi_load_revid(struct regmap *map, struct device *dev, > + struct qcom_spmi_pmic *pmic) > +{ > + int ret; > > - ret = regmap_read(map, PMIC_SUBTYPE, &subtype); > + ret = regmap_read(map, PMIC_TYPE, &pmic->type); > if (ret < 0) > - return; > + return ret; > > - for (i = 0; i < ARRAY_SIZE(pmic_spmi_id_table); i++) { > - if (subtype == (unsigned long)pmic_spmi_id_table[i].data) > - break; > - } > + if (pmic->type != PMIC_TYPE_VALUE) > + return ret; > > - if (i != ARRAY_SIZE(pmic_spmi_id_table)) > - name = pmic_spmi_id_table[i].compatible; > + ret = regmap_read(map, PMIC_SUBTYPE, &pmic->subtype); > + if (ret < 0) > + return ret; > + > + pmic->name = of_match_device(pmic_spmi_id_table, dev)->compatible; > > - ret = regmap_read(map, PMIC_REV2, &rev2); > + ret = regmap_read(map, PMIC_REV2, &pmic->rev2); > if (ret < 0) > - return; > + return ret; > > - ret = regmap_read(map, PMIC_REV3, &minor); > + ret = regmap_read(map, PMIC_REV3, &pmic->minor); > if (ret < 0) > - return; > + return ret; > > - ret = regmap_read(map, PMIC_REV4, &major); > + ret = regmap_read(map, PMIC_REV4, &pmic->major); > if (ret < 0) > - return; > + return ret; > > /* > * In early versions of PM8941 and PM8226, the major revision number > @@ -124,15 +174,34 @@ static void pmic_spmi_show_revid(struct regmap *map, struct device *dev) > * Increment the major revision number here if the chip is an early > * version of PM8941 or PM8226. > */ > - if ((subtype == PM8941_SUBTYPE || subtype == PM8226_SUBTYPE) && > - major < 0x02) > - major++; > + if ((pmic->subtype == PM8941_SUBTYPE || pmic->subtype == PM8226_SUBTYPE) && > + pmic->major < 0x02) Please define this magic number while you're at it. > + pmic->major++; > + > + if (pmic->subtype == PM8110_SUBTYPE) > + pmic->minor = pmic->rev2; > + > + pmic_print_info(dev, pmic); > > - if (subtype == PM8110_SUBTYPE) > - minor = rev2; > + return 0; > +} > + > +/** > + * qcom_pmic_get() - Get a pointer to the base PMIC device > + * > + * @dev: the pmic function device > + * @return: the struct qcom_spmi_pmic* pointer associated with the function device > + */ > +inline const struct qcom_spmi_pmic *qcom_pmic_get(struct device *dev) > +{ > + struct spmi_device *sdev = qcom_pmic_get_base_usid(dev->parent); > > - dev_dbg(dev, "%x: %s v%d.%d\n", subtype, name, major, minor); > + if (IS_ERR(sdev)) > + return ERR_CAST(sdev); > + > + return &((struct qcom_spmi_dev *)spmi_device_get_drvdata(sdev))->pmic; This is horrible. Please expand it out. > } > +EXPORT_SYMBOL(qcom_pmic_get); > > static const struct regmap_config spmi_regmap_config = { > .reg_bits = 16, > @@ -144,14 +213,26 @@ static const struct regmap_config spmi_regmap_config = { > static int pmic_spmi_probe(struct spmi_device *sdev) > { > struct regmap *regmap; > + struct qcom_spmi_dev *ctx; > + int ret; > > regmap = devm_regmap_init_spmi_ext(sdev, &spmi_regmap_config); > if (IS_ERR(regmap)) > return PTR_ERR(regmap); > > + ctx = devm_kzalloc(&sdev->dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + ctx->num_usids = (long)of_device_get_match_data(&sdev->dev); Why does this need to be long? In fact, it's not is it? It's an int: +struct qcom_spmi_dev { + int num_usids; + struct qcom_spmi_pmic pmic; +}; > /* Only the first slave id for a PMIC contains this information */ > - if (sdev->usid % 2 == 0) > - pmic_spmi_show_revid(regmap, &sdev->dev); > + if (sdev->usid % ctx->num_usids == 0) { > + ret = pmic_spmi_load_revid(regmap, &sdev->dev, &ctx->pmic); > + if (ret < 0) > + return ret; > + } > + spmi_device_set_drvdata(sdev, ctx); > > return devm_of_platform_populate(&sdev->dev); > } > diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h > new file mode 100644 > index 000000000000..5400e6509fe8 > --- /dev/null > +++ b/include/soc/qcom/qcom-spmi-pmic.h > @@ -0,0 +1,60 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* Copyright (c) 2021 Linaro. All rights reserved. > + * Copyright (c) 2021 Caleb Connolly Your very own Copyright? Why? Any not Author: instead? > + */ > + > +#ifndef __QCOM_SPMI_PMIC_H__ > +#define __QCOM_SPMI_PMIC_H__ > + > +#define COMMON_SUBTYPE 0x00 > +#define PM8941_SUBTYPE 0x01 > +#define PM8841_SUBTYPE 0x02 > +#define PM8019_SUBTYPE 0x03 > +#define PM8226_SUBTYPE 0x04 > +#define PM8110_SUBTYPE 0x05 > +#define PMA8084_SUBTYPE 0x06 > +#define PMI8962_SUBTYPE 0x07 > +#define PMD9635_SUBTYPE 0x08 > +#define PM8994_SUBTYPE 0x09 > +#define PMI8994_SUBTYPE 0x0a > +#define PM8916_SUBTYPE 0x0b > +#define PM8004_SUBTYPE 0x0c > +#define PM8909_SUBTYPE 0x0d > +#define PM8028_SUBTYPE 0x0e > +#define PM8901_SUBTYPE 0x0f > +#define PM8950_SUBTYPE 0x10 > +#define PMI8950_SUBTYPE 0x11 > +#define PM8998_SUBTYPE 0x14 > +#define PMI8998_SUBTYPE 0x15 > +#define PM8005_SUBTYPE 0x18 > +#define PM660L_SUBTYPE 0x1A > +#define PM660_SUBTYPE 0x1B > +#define PM8150_SUBTYPE 0x1E > +#define PM8150L_SUBTYPE 0x1f > +#define PM8150B_SUBTYPE 0x20 > +#define PMK8002_SUBTYPE 0x21 > +#define PM8009_SUBTYPE 0x24 > +#define PM8150C_SUBTYPE 0x26 > +#define SMB2351_SUBTYPE 0x29 > + > +#define PMI8998_FAB_ID_SMIC 0x11 > +#define PMI8998_FAB_ID_GF 0x30 > + > +#define PM660_FAB_ID_GF 0x0 > +#define PM660_FAB_ID_TSMC 0x2 > +#define PM660_FAB_ID_MX 0x3 > + > +struct qcom_spmi_pmic { > + unsigned int type; > + unsigned int subtype; > + unsigned int major; > + unsigned int minor; > + unsigned int rev2; > + const char *name; > +}; > + > +struct device; Can't you just include the correct header? > +inline const struct qcom_spmi_pmic *qcom_pmic_get(struct device *dev); > + > +#endif /* __QCOM_SPMI_PMIC_H__ */ -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog