* [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop unneeded minItems
2022-04-24 15:03 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Krzysztof Kozlowski
@ 2022-04-24 15:03 ` Krzysztof Kozlowski
2022-04-25 16:20 ` Rob Herring
2022-04-25 23:53 ` Alim Akhtar
2022-04-24 15:03 ` [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-24 15:03 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Rob Herring, Krzysztof Kozlowski,
Alim Akhtar, Michal Simek, linux-kernel, devicetree,
linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski
There is no need to add minItems when it is equal to maxItems.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
index 1584944c7ac4..0e28d9bdb8cb 100644
--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
@@ -35,7 +35,6 @@ properties:
- const: samsung,exynos4210-mct
clocks:
- minItems: 2
maxItems: 2
clock-names:
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop unneeded minItems
2022-04-24 15:03 ` [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: " Krzysztof Kozlowski
@ 2022-04-25 16:20 ` Rob Herring
2022-04-25 23:53 ` Alim Akhtar
1 sibling, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-04-25 16:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
Thomas Gleixner, Daniel Lezcano, Michal Simek, Alim Akhtar,
Rob Herring, linux-kernel, linux-samsung-soc
On Sun, 24 Apr 2022 17:03:32 +0200, Krzysztof Kozlowski wrote:
> There is no need to add minItems when it is equal to maxItems.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop unneeded minItems
2022-04-24 15:03 ` [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: " Krzysztof Kozlowski
2022-04-25 16:20 ` Rob Herring
@ 2022-04-25 23:53 ` Alim Akhtar
1 sibling, 0 replies; 11+ messages in thread
From: Alim Akhtar @ 2022-04-25 23:53 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Daniel Lezcano',
'Thomas Gleixner', 'Rob Herring',
'Krzysztof Kozlowski', 'Michal Simek',
linux-kernel, devicetree, linux-arm-kernel, linux-samsung-soc
Hello Krzysztof
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, April 24, 2022 8:34 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Michal Simek <michal.simek@xilinx.com>;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop
>unneeded minItems
>
>There is no need to add minItems when it is equal to maxItems.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
>index 1584944c7ac4..0e28d9bdb8cb 100644
>--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>@@ -35,7 +35,6 @@ properties:
> - const: samsung,exynos4210-mct
>
> clocks:
>- minItems: 2
> maxItems: 2
>
> clock-names:
>--
>2.32.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order
2022-04-24 15:03 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Krzysztof Kozlowski
2022-04-24 15:03 ` [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: " Krzysztof Kozlowski
@ 2022-04-24 15:03 ` Krzysztof Kozlowski
2022-04-25 23:59 ` Alim Akhtar
2022-04-26 18:14 ` Rob Herring
2022-04-26 0:01 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Alim Akhtar
` (2 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-24 15:03 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Rob Herring, Krzysztof Kozlowski,
Alim Akhtar, Michal Simek, linux-kernel, devicetree,
linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski
The DTS should always have fixed clock order, even if it comes with
clock-names property. Drop the pattern to make the order strict.
Existing DTS already match this.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
index 0e28d9bdb8cb..9c81d00b12e0 100644
--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
@@ -39,8 +39,8 @@ properties:
clock-names:
items:
- - pattern: "^(fin_pll|mct)$"
- - pattern: "^(fin_pll|mct)$"
+ - const: fin_pll
+ - const: mct
reg:
maxItems: 1
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* RE: [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order
2022-04-24 15:03 ` [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order Krzysztof Kozlowski
@ 2022-04-25 23:59 ` Alim Akhtar
2022-04-26 18:14 ` Rob Herring
1 sibling, 0 replies; 11+ messages in thread
From: Alim Akhtar @ 2022-04-25 23:59 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Daniel Lezcano',
'Thomas Gleixner', 'Rob Herring',
'Krzysztof Kozlowski', 'Michal Simek',
linux-kernel, devicetree, linux-arm-kernel, linux-samsung-soc
Hello Krzysztof,
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, April 24, 2022 8:34 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Michal Simek <michal.simek@xilinx.com>;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define
>strict clock order
>
>The DTS should always have fixed clock order, even if it comes with clock-
>names property. Drop the pattern to make the order strict.
>Existing DTS already match this.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
>index 0e28d9bdb8cb..9c81d00b12e0 100644
>--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yam
>+++ l
>@@ -39,8 +39,8 @@ properties:
>
> clock-names:
> items:
>- - pattern: "^(fin_pll|mct)$"
>- - pattern: "^(fin_pll|mct)$"
>+ - const: fin_pll
>+ - const: mct
>
> reg:
> maxItems: 1
>--
>2.32.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order
2022-04-24 15:03 ` [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order Krzysztof Kozlowski
2022-04-25 23:59 ` Alim Akhtar
@ 2022-04-26 18:14 ` Rob Herring
1 sibling, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-04-26 18:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, linux-arm-kernel, devicetree, Alim Akhtar,
Thomas Gleixner, Michal Simek, linux-samsung-soc, Rob Herring,
Daniel Lezcano, Krzysztof Kozlowski
On Sun, 24 Apr 2022 17:03:33 +0200, Krzysztof Kozlowski wrote:
> The DTS should always have fixed clock order, even if it comes with
> clock-names property. Drop the pattern to make the order strict.
> Existing DTS already match this.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems
2022-04-24 15:03 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Krzysztof Kozlowski
2022-04-24 15:03 ` [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: " Krzysztof Kozlowski
2022-04-24 15:03 ` [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order Krzysztof Kozlowski
@ 2022-04-26 0:01 ` Alim Akhtar
2022-04-26 18:14 ` Rob Herring
2022-05-06 8:28 ` Krzysztof Kozlowski
4 siblings, 0 replies; 11+ messages in thread
From: Alim Akhtar @ 2022-04-26 0:01 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Daniel Lezcano',
'Thomas Gleixner', 'Rob Herring',
'Krzysztof Kozlowski', 'Michal Simek',
linux-kernel, devicetree, linux-arm-kernel, linux-samsung-soc
Hello Krzysztof,
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, April 24, 2022 8:34 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Michal Simek <michal.simek@xilinx.com>;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems
>
>There is no need to add minItems when it is equal to maxItems.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>index c3386076a98c..7d821fd480f6 100644
>--- a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>+++ b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>@@ -17,7 +17,6 @@ properties:
> maxItems: 1
>
> interrupts:
>- minItems: 3
> maxItems: 3
> description: |
> A list of 3 interrupts; one per timer channel.
>--
>2.32.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems
2022-04-24 15:03 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-04-26 0:01 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Alim Akhtar
@ 2022-04-26 18:14 ` Rob Herring
2022-05-06 8:28 ` Krzysztof Kozlowski
4 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-04-26 18:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, Krzysztof Kozlowski, Rob Herring,
Thomas Gleixner, Alim Akhtar, Daniel Lezcano, Michal Simek,
linux-kernel, linux-samsung-soc, devicetree
On Sun, 24 Apr 2022 17:03:31 +0200, Krzysztof Kozlowski wrote:
> There is no need to add minItems when it is equal to maxItems.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems
2022-04-24 15:03 ` [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-04-26 18:14 ` Rob Herring
@ 2022-05-06 8:28 ` Krzysztof Kozlowski
2022-05-19 20:40 ` Rob Herring
4 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-06 8:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, Daniel Lezcano, Thomas Gleixner
Cc: Krzysztof Kozlowski, Alim Akhtar, Michal Simek, linux-kernel,
devicetree, linux-arm-kernel, linux-samsung-soc, Rob Herring
On 24/04/2022 17:03, Krzysztof Kozlowski wrote:
> There is no need to add minItems when it is equal to maxItems.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
> 1 file changed, 1 deletion(-)
Hi Daniel, Thomas,
The patchset was acked by Rob, so he expects you will pick it up. Could
you let me know if there is anything stopping or you expect the other
way (via DT-tree)?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems
2022-05-06 8:28 ` Krzysztof Kozlowski
@ 2022-05-19 20:40 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-05-19 20:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski, Alim Akhtar,
Michal Simek, linux-kernel, devicetree, linux-arm-kernel,
linux-samsung-soc
On Fri, May 06, 2022 at 10:28:52AM +0200, Krzysztof Kozlowski wrote:
> On 24/04/2022 17:03, Krzysztof Kozlowski wrote:
> > There is no need to add minItems when it is equal to maxItems.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> Hi Daniel, Thomas,
>
> The patchset was acked by Rob, so he expects you will pick it up. Could
> you let me know if there is anything stopping or you expect the other
> way (via DT-tree)?
Looks like still not applied, so I've applied to DT tree.
Rob
^ permalink raw reply [flat|nested] 11+ messages in thread