From: Rob Herring <robh@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <tdas@codeaurora.org>,
Ansuel Smith <ansuelsmth@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
Date: Mon, 25 Apr 2022 15:23:03 -0500 [thread overview]
Message-ID: <YmcDJw6T7p4dtFYc@robh.at.kernel.org> (raw)
In-Reply-To: <20220425193253.06828C385A4@smtp.kernel.org>
On Mon, Apr 25, 2022 at 12:32:51PM -0700, Stephen Boyd wrote:
> Quoting Rob Herring (2022-04-25 06:35:27)
> > The compatible string should be 'qcom,gcc-apq8064', not
> > 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
> >
> > Cc: Ansuel Smith <ansuelsmth@gmail.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > index 97936411b6b4..9910a3e033bb 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > @@ -25,7 +25,7 @@ description: |
> >
> > properties:
> > compatible:
> > - const: qcom,gcc-apq8084
> > + const: qcom,gcc-apq8064
>
> This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
> that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
> simplify qcom,gcc-apq8064 Documentation") took the more than just the
> compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
> removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
> the apq8064 file with the single compatible changed.
IDK, can someone (Ansuel?) fix this properly?
Rob
next prev parent reply other threads:[~2022-04-25 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 13:35 [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string Rob Herring
2022-04-25 18:13 ` Krzysztof Kozlowski
2022-04-25 19:32 ` Stephen Boyd
2022-04-25 20:23 ` Rob Herring [this message]
2022-04-25 20:31 ` Krzysztof Kozlowski
2022-04-25 20:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmcDJw6T7p4dtFYc@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).