Re: [PATCH v4 1/2] dt-bindings: sound: Add generic serial MIDI device

[Rob Herring <robh@kernel.org>]

On Mon, Apr 25, 2022 at 02:16:02PM -0500, Daniel Kaehn wrote:
> Adds dt-binding for snd-serial-generic serial MIDI driver

Bindings are for h/w and there's no such thing as generic h/w. There are 
some exceptions but you'll have to justify why this is special.


> Signed-off-by: Daniel Kaehn <kaehndan@gmail.com>
> ---
>  .../devicetree/bindings/sound/serialmidi.yaml | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/serialmidi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/serialmidi.yaml b/Documentation/devicetree/bindings/sound/serialmidi.yaml
> new file mode 100644
> index 000000000000..38ef49a0c2f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/serialmidi.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/serialmidi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic Serial MIDI Device
> +
> +maintainers:
> +  - Daniel Kaehn <kaehndan@gmail.com>
> +
> +description: |

Don't need '|' unless there is formatting to preserve.

> +  Generic MIDI interface using a serial device. Can only be set to use standard speeds
> +  corresponding to supported baud rates of the underlying serial device. If standard MIDI
> +  speed of 31.25 kBaud is needed, configure the clocks of the underlying serial device
> +  so that a requested speed of 38.4 kBaud resuts in the standard MIDI baud rate.
> +
> +properties:
> +  compatible:
> +    const: serialmidi
> +
> +  speed:

Not a standard property and we already have 2 of them concerning baud 
rate.

> +    maxItems: 1
> +    description: |
> +      Speed to set the serial port to when the MIDI device is opened.
> +      If not specified, the underlying serial device is allowed to use its configured default speed.
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    serial {
> +        midi {
> +            compatible = "serialmidi";
> +            speed = <38400>;
> +        };
> +    };
> -- 
> 2.33.0
> 
>