From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061C9C433FE for ; Tue, 26 Apr 2022 18:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351264AbiDZS16 (ORCPT ); Tue, 26 Apr 2022 14:27:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351261AbiDZS1w (ORCPT ); Tue, 26 Apr 2022 14:27:52 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2FF2197F9D for ; Tue, 26 Apr 2022 11:24:43 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id y21so11773078wmi.2 for ; Tue, 26 Apr 2022 11:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+SCJtuLLPCBIugzhmGROyOenrWlaIWVL1GHx1RKXQ04=; b=nntI83QQTS/o0PgqWKe78Wr/Fs7Rm4Eskmyw6Fc9ZUnLXEOEzdwyZ4D9skbnKDbf1I PaGaX7HxqO4WvGXMqz28D5yOrFtObmRpnP/7aL+ypyEKGi70g+DZBVCB5tuweBllAyOD /vT3/SyWlkJeaeo5SCcoedvh9KBVPgls0+VEecJNwud2dU0fmwnnYG+D4u4o6r+ocx7k Vsn7mz7BQcsEek2QZJqcz2GwyR9Wt16Zkq10n9tiRtM9OKx1ZFI57S0OhQ1ZuNRqiAJy UPQixnwjYm0CiEt5CWRFhEKn0nnI0oPn837Ny7wrD7WzyqK5KzwRqRop4m0ydqI1MnyH LL/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+SCJtuLLPCBIugzhmGROyOenrWlaIWVL1GHx1RKXQ04=; b=Wo5SlG4TNjCcjwCkz73dYP1ZpERtbSOF1T3Vs5FJhFQ/bL7OeR1SZFmAOHoxDZkh38 uH2Wq00VzY8kfTxeCANyztnoPIWkAFCDpyPrfMS7B9N4EJzatf/Fc+ZyFpIw0rtnR7ac n9+ykwlGMnhvA0XbBGbo/zNEQEWcGHkZhvGG5nYUxh7oqRRyosr7+6Gs2ds1ItF5OS9C McXqq/ipzQjq8UaCx4STljX3ffBAOynFgq92ZnQhDinZMPjQ0YhzvhsjErHLubG0g+y/ 2FL48426Fj3OGXvNXVx/rJxd1I+ASu6jdl6EzPqh2s2w1p6zj8UKK632DAUWOC2Cwpqo I58A== X-Gm-Message-State: AOAM531TKVQ1OUr8/QsoWxF/yvx+TsDUsH+3kROrNzXrwc3kB7LgrAe/ lCpJ/0h0SEzrLRBT4TLZPo7ljA== X-Google-Smtp-Source: ABdhPJwz//6x4ICwKAzGCmmXVVYSEtHxdDp9dLUNvkRfLP6WxyjweH5Q18HN37vwRJIIiCxDpbUDqQ== X-Received: by 2002:a7b:c0d0:0:b0:392:a02c:28ab with SMTP id s16-20020a7bc0d0000000b00392a02c28abmr31509324wmh.2.1650997482193; Tue, 26 Apr 2022 11:24:42 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c1d8e00b0038ecb2d2feasm11567536wms.4.2022.04.26.11.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:24:41 -0700 (PDT) Date: Tue, 26 Apr 2022 19:24:39 +0100 From: Lee Jones To: Caleb Connolly Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org, amit.pundir@linaro.org, Krzysztof Kozlowski , Dmitry Baryshkov Subject: Re: [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs Message-ID: References: <20220323162820.110806-1-caleb@connolly.tech> <20220323162820.110806-4-caleb@connolly.tech> <10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 26 Apr 2022, Caleb Connolly wrote: > On 25/04/2022 16:05, Lee Jones wrote: > > On Wed, 23 Mar 2022, Caleb Connolly wrote: > > > > > From: Caleb Connolly > > > > > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like > > > the RRADC to calibrate ADC values. > > > > > > Signed-off-by: Caleb Connolly > > > Reviewed-by: Dmitry Baryshkov > > > Tested-by: Dmitry Baryshkov > > > --- > > > drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ > > > include/soc/qcom/qcom-spmi-pmic.h | 1 + > > > 2 files changed, 8 insertions(+) > > > > Please change the Subject line to match the style of the sub-system? > Hi, sorry if this is a silly question, I don't quite understand what you > want me to change here, the subject line is in the same "mfd: driver:" > format as other patches in the subsystem? mfd: qcom-spmi-pmic: Read fab ID on supported PMICs What's 'fab' should that be capitalised too? > > Once changed: > > > > Acked-by: Lee Jones > > > -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog