From: Rob Herring <robh@kernel.org>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>
Cc: matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
chunkuang.hu@kernel.org, jitao.shi@mediatek.com,
linux-kernel@vger.kernel.org, airlied@linux.ie,
krzysztof.kozlowski+dt@linaro.org, daniel@ffwll.ch,
xinlei.lee@mediatek.com, devicetree@vger.kernel.org,
p.zabel@pengutronix.de, linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, cellopoint.kai@gmail.com
Subject: Re: [PATCH v5 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
Date: Fri, 29 Apr 2022 15:06:30 -0500 [thread overview]
Message-ID: <YmxFRuBWmPaCyw0I@robh.at.kernel.org> (raw)
In-Reply-To: <9f601c458bd3401b216992e8dd72485a10f34597.camel@mediatek.com>
On Fri, Apr 29, 2022 at 09:55:37AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-04-28 at 15:33 -0500, Rob Herring wrote:
> > On Thu, 28 Apr 2022 21:37:50 +0800, Rex-BC Chen wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Convert mediatek,dsi.txt to mediatek,dsi.yaml format
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > > ---
> > > .../display/mediatek/mediatek,dsi.txt | 62 ---------
> > > .../display/mediatek/mediatek,dsi.yaml | 122
> > > ++++++++++++++++++
> > > 2 files changed, 122 insertions(+), 62 deletions(-)
> > > delete mode 100644
> > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > > create mode 100644
> > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam
> > > l
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for
> > dtbs_check.
> > This will change in the future.
> >
> > Full log is available here:
> > https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/__;!!CTRNKA9wMg0ARbw!wKbRsUmeUS_4mtOwj1t30buVNEilHYYhsUmEd5MvZ7P9VyDXg6cikERof47mkwETQzFL$
> >
> >
> >
> > dsi@1400c000: compatible: ['mediatek,mt7623-dsi', 'mediatek,mt2701-
> > dsi'] is too long
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb
> > arch/arm/boot/dts/mt7623n-rfb-emmc.dtb
> >
> > dsi@14014000: #address-cells:0:0: 2 was expected
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-
> > sku2.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku6.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku7.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-
> > sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> >
> > dsi@14014000: 'port' is a required property
> > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-
> > sku2.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku6.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku7.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-
> > sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> >
> > dsi@14014000: #size-cells:0:0: 2 was expected
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-
> > sku2.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku6.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-
> > sku7.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-
> > sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-
> > sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> >
> > dsi@1401b000: 'port' is a required property
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb
> >
>
> Hello Rob,
>
> Thanks for your comments.
> The purpose of this series is not to fix dts for previous SoCs.
> Therefore, if there is a chance, we could send another series to fix
> them.
Conversions often find that the actual dts files vary a bit more than
the binding doc said. You should look at the warnings and decide if they
should be fixed or the schema relaxed. It's a judgement call. I have no
idea if you did that already or not, so I send this out on conversions.
The check runs automatically, but sending it I review briefly.
Rob
next prev parent reply other threads:[~2022-04-29 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 13:37 [PATCH v5 0/4] Add mt8186 dsi compatoble & Convert dsi_dtbinding to .yaml Rex-BC Chen
2022-04-28 13:37 ` [PATCH v5 1/4] dt-bindings: display: mediatek: dsi: " Rex-BC Chen
2022-04-28 20:33 ` Rob Herring
2022-04-29 1:55 ` Rex-BC Chen
2022-04-29 20:06 ` Rob Herring [this message]
2022-05-03 9:48 ` Rex-BC Chen
2022-05-03 18:01 ` Rob Herring
2022-05-04 8:05 ` Rex-BC Chen
2022-05-04 8:15 ` Rex-BC Chen
2022-04-28 13:37 ` [PATCH v5 2/4] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186 Rex-BC Chen
2022-04-28 13:37 ` [PATCH v5 3/4] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c Rex-BC Chen
2022-04-28 13:37 ` [PATCH v5 4/4] drm/mediatek: Add MT8186 DSI compatible for mtk_drm_drv.c Rex-BC Chen
2022-04-29 2:29 ` Rex-BC Chen
2022-05-04 8:06 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmxFRuBWmPaCyw0I@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=cellopoint.kai@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).