devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	agross@kernel.org, robh+dt@kernel.org,
	bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	marcel@holtmann.org, johan.hedberg@gmail.com
Cc: kbuild-all@lists.01.org, mka@chromium.org,
	linux-bluetooth@vger.kernel.org, quic_hemantg@quicinc.com,
	quic_saluvala@quicinc.com, quic_rjliao@quicinc.com,
	mcchou@chromium.org,
	Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
Subject: [PATCH] Bluetooth: hci_qca: fix excluded_middle.cocci warnings
Date: Sat, 30 Apr 2022 06:59:54 +0800	[thread overview]
Message-ID: <Ymxt6qICRLDgUjAA@4bf0d7f47e85> (raw)
In-Reply-To: <1651228073-1999-4-git-send-email-quic_bgodavar@quicinc.com>

From: kernel test robot <lkp@intel.com>

drivers/bluetooth/hci_qca.c:1633:42-44: WARNING !A || A && B is equivalent to !A || B


 Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

CC: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/intel-lab-lkp/linux/commits/Balakrishna-Godavarthi/WAR-to-handle-WCN6750-hardware-issue/20220429-193129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

 drivers/bluetooth/hci_qca.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1630,7 +1630,7 @@ static int qca_regulator_init(struct hci
 		msleep(50);
 	}
 
-	if (!qcadev->wlan_en || (qcadev->wlan_en && gpiod_get_value_cansleep(qcadev->wlan_en)))
+	if (!qcadev->wlan_en || gpiod_get_value_cansleep(qcadev->wlan_en))
 		gpiod_set_value_cansleep(qcadev->bt_en, 1);
 
 	if (qcadev->wlan_en && !gpiod_get_value_cansleep(qcadev->wlan_en)) {

  parent reply	other threads:[~2022-04-29 23:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 10:27 [PATCH v1 0/3] WAR to handle WCN6750 hardware issue Balakrishna Godavarthi
2022-04-29 10:27 ` [PATCH v1 1/3] dt-bindings: net: bluetooth: Add wlan-gpio entry for wcn6750 Balakrishna Godavarthi
2022-04-29 14:50   ` Marcel Holtmann
2022-05-04 20:31   ` Rob Herring
2022-04-29 10:27 ` [PATCH v1 2/3] arm64: dts: qcom: sc7280: Add wlan enable gpio to bluetooth node Balakrishna Godavarthi
2022-04-29 10:27 ` [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue Balakrishna Godavarthi
2022-04-29 14:54   ` Marcel Holtmann
2022-04-30  3:09     ` Balakrishna Godavarthi (QUIC)
2022-05-10  3:17       ` Miao-chen Chou
2022-06-22  7:27         ` Balakrishna Godavarthi (QUIC)
2022-10-13 19:11           ` mka
2022-10-13 20:06             ` Luiz Augusto von Dentz
2022-10-13 20:12               ` mka
2022-04-29 22:59   ` kernel test robot [this message]
2022-04-29 23:05   ` kernel test robot
2022-06-22  7:33 ` [PATCH v1 0/3] WAR to handle WCN6750 hardware issue Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymxt6qICRLDgUjAA@4bf0d7f47e85 \
    --to=lkp@intel.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mcchou@chromium.org \
    --cc=mka@chromium.org \
    --cc=quic_bgodavar@quicinc.com \
    --cc=quic_hemantg@quicinc.com \
    --cc=quic_rjliao@quicinc.com \
    --cc=quic_saluvala@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).