Re: [PATCH 1/2] dt-bindings: usb: usb251xb: add documentation for reset-delay-us

[Rob Herring <robh@kernel.org>]

On Tue, Apr 26, 2022 at 12:33:47PM +0000, Daniels Umanovskis wrote:
> Next patch implements support for this property

Not a great reason why you need this. This patch should stand on its 
own.

My first question is whether this is board specific? If the default or 
what the reference manual says is 500us, but you have a case needing 
600us, why not just change the driver. I don't think this really needs 
tuning to each board unless the delay becomes noticeable.

> 
> Signed-off-by: Daniels Umanovskis <du@axentia.se>
> ---
>  Documentation/devicetree/bindings/usb/usb251xb.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt
> index 1a934eab175e..d95c8ae518e7 100644
> --- a/Documentation/devicetree/bindings/usb/usb251xb.txt
> +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt
> @@ -12,6 +12,8 @@ Required properties :
>  
>  Optional properties :
>   - reset-gpios : Should specify the gpio for hub reset
> + - reset-delay-us: Specifies delay in microseconds after reset deassert
> +        on hub power-up. (32 bit, default is 500us)
>   - vdd-supply : Should specify the phandle to the regulator supplying vdd
>   - skip-config : Skip Hub configuration, but only send the USB-Attach command
>   - vendor-id : Set USB Vendor ID of the hub (16 bit, default is 0x0424)
> -- 
> 2.30.2
> 
>