public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Leitner - SKIDATA <Richard.Leitner@skidata.com>
To: Daniels Umanovskis <du@axentia.se>
Cc: Rob Herring <robh@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: usb: usb251xb: add documentation for reset-delay-us
Date: Tue, 3 May 2022 09:21:10 +0000	[thread overview]
Message-ID: <YnDz/q7hqlTbRqYR@ltleri2> (raw)
In-Reply-To: <75ed6e33-0d67-c50f-4d3a-7345d5f058b4@axentia.se>

On Tue, May 03, 2022 at 09:49:36AM +0200, Daniels Umanovskis wrote:
> On 5/3/22 2:20 AM, Rob Herring wrote:
> > My first question is whether this is board specific? If the default or
> > what the reference manual says is 500us, but you have a case needing
> > 600us, why not just change the driver. I don't think this really needs
> > tuning to each board unless the delay becomes noticeable.
> 
> This isn't a board specific issue. I detected the issue on a board we've
> been using for a long time, it's due to a specific batch of USB2512 hubs.
> We've had several batches of these hubs that were fine, but more recently
> received a batch produced in late 2021 and the hubs in this batch do not
> become responsive to I2C within the expected 500us.

What's the maximum timeout you've observed?

I guess it would be the simpler and "better" approach to just increase
the timeout in the driver (if it's not too much above the 500µs).

> 
> I arrived at that by using an oscilloscope to observe how soon after
> deasserting the reset signal the USB hub is able to respond to I2C. Most of
> the 2512s we have do that within 500us, the latest batch doesn't.
> 

regards;rl

  reply	other threads:[~2022-05-03  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 12:33 [PATCH 0/2] usb: usb251xb: configurable reset delay Daniels Umanovskis
2022-04-26 12:33 ` [PATCH 1/2] dt-bindings: usb: usb251xb: add documentation for reset-delay-us Daniels Umanovskis
2022-04-27  7:37   ` Richard Leitner - SKIDATA
2022-05-03  0:20   ` Rob Herring
2022-05-03  7:49     ` Daniels Umanovskis
2022-05-03  9:21       ` Richard Leitner - SKIDATA [this message]
2022-05-03  9:41         ` Daniels Umanovskis
2022-05-04 14:09           ` Rob Herring
2022-04-26 12:34 ` [PATCH 2/2] usb: usb251xb: make power-up reset delay configurable in device tree Daniels Umanovskis
2022-04-26 12:46   ` Greg KH
2022-04-26 13:06     ` Daniels Umanovskis
2022-04-26 13:56       ` Greg KH
2022-04-27  7:38   ` Richard Leitner - SKIDATA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnDz/q7hqlTbRqYR@ltleri2 \
    --to=richard.leitner@skidata.com \
    --cc=devicetree@vger.kernel.org \
    --cc=du@axentia.se \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox