From: Matthias Kaehlcke <mka@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org,
dianders@chromium.org, swboyd@chromium.org,
judyhsiao@chromium.org,
Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [PATCH v11 04/12] arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0/2.0 and IDP boards
Date: Wed, 4 May 2022 14:32:46 -0700 [thread overview]
Message-ID: <YnLw/tw1FzAPtKSo@google.com> (raw)
In-Reply-To: <1651664649-25290-5-git-send-email-quic_srivasam@quicinc.com>
On Wed, May 04, 2022 at 05:14:01PM +0530, Srinivasa Rao Mandadapu wrote:
> Add wcd9385 codec node for audio use case on sc7280 based platforms
> of revision 3, 4 (aka CRD 1.0 and 2.0) and IDP boards.
> Add tlmm gpio property for switching CTIA/OMTP Headset.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Carrying over from v10:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Coming back to my earlier comments about per-patch change logs:
The cover letter change log looks like this:
Changes Since V10:
-- Modify digital macro codecs pin control labels.
-- Updated dependency list.
Changes Since V9:
-- Move wcd codec and digital codec nodes to sc7280-qcard file.
-- Modify the reg property as per link number in sound node.
-- Fix the us-euro pin control usage in wcd codec node.
-- Move wcd pin control nodes to specific crd board files.
-- Sort max98360a codec node in alphabetical order.
-- Modify the commit messages.
...
There is no mention in which patches changes were made, in some cases
you can guess it, in others not, in any case you are placing the
burden to figure that out on the reviewers even though you already
have that information. So please send future series (this one is
hopefully close to landing) with per-patch change logs.
next prev parent reply other threads:[~2022-05-04 21:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 11:43 [PATCH v11 00/12] Add soundcard support for sc7280 based platforms Srinivasa Rao Mandadapu
2022-05-04 11:43 ` [PATCH v11 01/12] arm64: dts: qcom: sc7280: Add nodes for soundwire and va tx rx digital macro codecs Srinivasa Rao Mandadapu
2022-05-04 11:43 ` [PATCH v11 02/12] arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD 1.0/2.0 and IDP boards Srinivasa Rao Mandadapu
2022-05-04 21:17 ` Matthias Kaehlcke
2022-05-04 11:44 ` [PATCH v11 03/12] arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD 3.0/3.1 Srinivasa Rao Mandadapu
2022-05-04 21:21 ` Matthias Kaehlcke
2022-05-04 11:44 ` [PATCH v11 04/12] arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0/2.0 and IDP boards Srinivasa Rao Mandadapu
2022-05-04 21:32 ` Matthias Kaehlcke [this message]
2022-05-04 11:44 ` [PATCH v11 05/12] arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 3.0/3.1 Srinivasa Rao Mandadapu
2022-05-04 21:34 ` Matthias Kaehlcke
2022-05-04 11:44 ` [PATCH v11 06/12] arm64: dts: qcom: sc7280: Add max98360a codec for CRD 1.0/2.0 and IDP boards Srinivasa Rao Mandadapu
2022-05-04 11:44 ` [PATCH v11 07/12] arm64: dts: qcom: sc7280: herobrine: Add max98360a codec node Srinivasa Rao Mandadapu
2022-05-04 21:38 ` Matthias Kaehlcke
2022-05-04 11:44 ` [PATCH v11 08/12] arm64: dts: qcom: sc7280: Add lpass cpu node Srinivasa Rao Mandadapu
2022-05-04 11:44 ` [PATCH v11 09/12] arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 1.0/2.0 and IDP boards Srinivasa Rao Mandadapu
2022-05-04 11:44 ` [PATCH v11 10/12] arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 3.0/3.1 Srinivasa Rao Mandadapu
2022-05-04 11:44 ` [PATCH v11 11/12] arm64: dts: qcom: sc7280: Add sound node for CRD 1.0/2.0 and IDP boards Srinivasa Rao Mandadapu
2022-05-04 21:42 ` Matthias Kaehlcke
2022-05-04 11:44 ` [PATCH v11 12/12] arm64: dts: qcom: sc7280: Add sound node for CRD 3.0/3.1 Srinivasa Rao Mandadapu
2022-05-04 21:42 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnLw/tw1FzAPtKSo@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_potturu@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).