From: Andrew Lunn <andrew@lunn.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Pavel Machek" <pavel@ucw.cz>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"John Crispin" <john@phrozen.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds
Date: Thu, 5 May 2022 14:17:12 +0200 [thread overview]
Message-ID: <YnPASLy4oWJ6BJDq@lunn.ch> (raw)
In-Reply-To: <235aa025-7c12-f7e1-d788-9a2ef97f664f@gmail.com>
On Thu, May 05, 2022 at 07:19:41AM +0200, Rafał Miłecki wrote:
> On 3.05.2022 17:36, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > This allows specifying multiple Ethernet speeds in a single DT uint32
> > value.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Ansuel please check if my patchset conflicts in any way with your work.
>
> Andrew suggested to combine both but right now I don't see it as
> necessary.
>
> I'd still appreciate your review of my work. Such binding may be
> required for some hardware controlled LEDs setup too I guess.
Please look at the LED binding. It is an LED you are trying to
control, so that is the binding you should be using. How do you
describe this functionality using that binding. Ansuel code will give
you the framework to actually do the implementation within.
Andrew
next prev parent reply other threads:[~2022-05-05 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 15:36 [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds Rafał Miłecki
2022-05-03 15:36 ` [PATCH 2/4] dt-bindings: net: allow Ethernet devices as LED triggers Rafał Miłecki
2022-05-03 15:36 ` [PATCH 3/4] dt-bindings: leds: add Ethernet triggered LEDs to example Rafał Miłecki
2022-05-03 15:36 ` [PATCH 4/4] ARM: dts: BCM5301X: Add triggers for Luxul XWR-1200 network LEDs Rafał Miłecki
2022-05-04 21:23 ` [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds Andrew Lunn
2022-05-05 5:19 ` Rafał Miłecki
2022-05-05 12:17 ` Andrew Lunn [this message]
2022-05-05 13:46 ` Rafał Miłecki
2022-05-05 14:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnPASLy4oWJ6BJDq@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jacek.anaszewski@gmail.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).