Re: [PATCH 3/8] dt-bindings: hwmon: Allow specifying channels for lm90

[Slawomir Stepien <sst@poczta.fm>]

On maj 24, 2022 19:59, Krzysztof Kozlowski wrote:
> On 24/05/2022 19:27, Slawomir Stepien wrote:
> >> Well ok, looks like this:
> >>
> >>       temperature-offset-millicelsius:
> >>         description: Temperature offset to be added to or subtracted from remote temperature measurements.
> >>         items:
> >>           items:
> 
> I think this is not an array, so items are not needed.
> 
> >>             type: integer
> 
> types are instead:
> $ref: /schemas/types.yaml#/definitions/int32
> but I think it still does not work.
> 
> >>             minimum: -128000
> >>             maximum: 127000
> > 
> > This isn't working...from what I've read we cannot just simply overwrite existing schemas.
> > 
> > Krzysztof, Guenter what I should do? Is there a way to match with uint32-array schema and with
> > schema that allows items in array to be below 0 (seems impossible to me)? I've tried a lot of
> > combinations today without any luck. Any helpful tips? Thanks!
> 
> However this still does not work. I changed in schema:
> 
>    # Temperature
> 
>    "-celsius$":

I'm using -millicelsius.

> -    $ref: "types.yaml#/definitions/uint32-array"
> 
> +    $ref: "types.yaml#/definitions/int32-array"

If I drop the "-millicelsius" and set the ref to types.yaml#/definitions/int32, all seems fine (the
sign is parsed correctly and the max/min are enforced correctly too).

> but that does not solve the problem that property is stored as uint32
> and parsed like uint32:
> 
>     4294967291 is greater than the maximum of 40
> 
> 
> Maybe Rob has some idea. Till then, you can skip minimum.

I will skip for now. I will send the new series and we can continue the discussion there. Thank you!

-- 
Slawomir Stepien