From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 901E4C433FE for ; Mon, 16 May 2022 15:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244846AbiEPPP2 (ORCPT ); Mon, 16 May 2022 11:15:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245093AbiEPPPZ (ORCPT ); Mon, 16 May 2022 11:15:25 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8EA3BA6E for ; Mon, 16 May 2022 08:15:23 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id l9-20020a056830268900b006054381dd35so10242196otu.4 for ; Mon, 16 May 2022 08:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aqUacUDD/fnqySsoi3HdJFEi/V1mTy/VfQQMnGzRza8=; b=dmfC0zUnM3Da4eBmHuwkOrpuYP643Dic9NsM1QhvrqzZggtptHBQDGNxfy6PdTxadp 0WuH6KV4+gkux/NZgj8EAnr7WeIeOjpQpaTch577VWirBI7CKJsjc/eySNgOlfbTA6+O vfF7AJ0JYNL8acPMBsHIbylCVcn8VAYVcqKGBCjy2bbjQSmniPC7FVH0oWqXWBc1CVE0 2E58YZqxk95IMCcPfWaPL/21THyhS7lvMivfJsDimueM5vMX0Tu4E0bb5R7nXiAnqGMG +SxQubBfyUDFkhNrgmoHlz90Pp0twEahIdAUh4C3BiFtparP46Mxgj1X0+UU/1PsunOs nE1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aqUacUDD/fnqySsoi3HdJFEi/V1mTy/VfQQMnGzRza8=; b=XJ/N1AXg9x0AAoJ4S3WsidJDXbV+dQu4icfjBSphhfRjVws6UJq6bWf5c/fX5mIjAY ZZukTNCWK3iMqAet8lVpChc+Gv8jzdfnpVg8BW8c/hPq2nY8e+J+mWRkVtZiR8R26hMR N9cMQq0CRYJtRgoI2a5ANSg/Y6lB2w5At5InQrPg9F8pm+pbKuQ91+wrnSB198DtQ8oH PBZFG0kZ1k/GMF8neV2IqIoNVKG0HmlNTzW3g4DiotXn7H4CRz4r2qU8llKKu5ANoqBs nM3l073N0jm+5Uyp3BmOqWdD3VruIc2yt4AOe8YjqUs8g8vqr87edxio8F+YtOWf2g4g mfIA== X-Gm-Message-State: AOAM533dxbKJLiGciilMuk+sr/eItyW5bJ2eNU47CkhzDoMhVly4M+YN 7KpDuAxZ/JmAsf/SO66cGQuEhA== X-Google-Smtp-Source: ABdhPJyxCbBtqQzZ9IoSbuL6c4zNV6p71BzBhppEUqHbNuekH9OptVw3cYCBHP8hn3HJmDptoqnELA== X-Received: by 2002:a9d:2f65:0:b0:609:a162:388d with SMTP id h92-20020a9d2f65000000b00609a162388dmr325956otb.331.1652714121253; Mon, 16 May 2022 08:15:21 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 23-20020a9d0317000000b006060322125asm4070722otv.42.2022.05.16.08.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 08:15:20 -0700 (PDT) Date: Mon, 16 May 2022 08:17:44 -0700 From: Bjorn Andersson To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, Linus Walleij , linux-gpio@vger.kernel.org, Venkata Prasad Potturu Subject: Re: [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets Message-ID: References: <1651672580-18952-1-git-send-email-quic_srivasam@quicinc.com> <1651672580-18952-3-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651672580-18952-3-git-send-email-quic_srivasam@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 04 May 06:56 PDT 2022, Srinivasa Rao Mandadapu wrote: > Add compatible string and lpi pinctrl variant data structure for adsp enabled > sc7280 platforms. This says what the change does, but gives no clue to what this compatible represents and why the clock is not optional. Could you please describe here what scenario this compatible is to be used for etc, so that when someone else adds support for the next platform they can use the git history to understand which case to follow. Thanks, Bjorn > > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu > --- > drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > index 2add9a4..c9e85d9 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > @@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = { > LPI_FUNCTION(wsa_swr_data), > }; > > +static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = { > + .pins = sc7280_lpi_pins, > + .npins = ARRAY_SIZE(sc7280_lpi_pins), > + .groups = sc7280_groups, > + .ngroups = ARRAY_SIZE(sc7280_groups), > + .functions = sc7280_functions, > + .nfunctions = ARRAY_SIZE(sc7280_functions), > + .is_clk_optional = false, > +}; > + > static const struct lpi_pinctrl_variant_data sc7280_lpi_data = { > .pins = sc7280_lpi_pins, > .npins = ARRAY_SIZE(sc7280_lpi_pins), > @@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = { > .compatible = "qcom,sc7280-lpass-lpi-pinctrl", > .data = &sc7280_lpi_data, > }, > + { > + .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl", > + .data = &sc7280_adsp_lpi_data, > + }, > { } > }; > MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match); > -- > 2.7.4 >