From: Matthias Kaehlcke <mka@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
dianders@chromium.org, cychiang@google.com, judyhsiao@google.com,
tzungbi@chromium.org, swboyd@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v1 1/3] arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S
Date: Thu, 19 May 2022 08:24:23 -0700 [thread overview]
Message-ID: <YoZhJ/3xPwzaBSUS@google.com> (raw)
In-Reply-To: <20220519084119.675990-2-judyhsiao@chromium.org>
On Thu, May 19, 2022 at 08:41:17AM +0000, Judy Hsiao wrote:
> Subject: arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S
>
> Add drive strength property for secondary MI2S on sc7280 based platforms
That's not an accurate description, this patch only adjust settings for
herobrine based boards. This should be reflected at list in the subject.
Besides setting the drive strengths this patch also disables the pulls
on some lines, so maybe better say something like "arm64: dts: qcom:
sc7280: herobrine: Add pinconf settings for mi2s1".
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 9cb1bc8ed6b5..6d8744e130b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> bias-disable;
> };
>
> +&mi2s1_data0 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_sclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_ws {
> + drive-strength = <6>;
> +};
> +
> &pcie1_clkreq_n {
> bias-pull-up;
> drive-strength = <2>;
> --
> 2.36.1.124.g0e6072fb45-goog
>
next prev parent reply other threads:[~2022-05-19 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 8:41 [v1 0/3] Add dtsi for sc7280 boards that using rt5682 codec Judy Hsiao
2022-05-19 8:41 ` [v1 1/3] arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S Judy Hsiao
2022-05-19 15:24 ` Matthias Kaehlcke [this message]
2022-05-20 2:53 ` kernel test robot
2022-05-19 8:41 ` [v1 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Judy Hsiao
2022-05-19 16:04 ` Matthias Kaehlcke
2022-05-19 8:41 ` [v1 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 Judy Hsiao
2022-05-19 16:07 ` Matthias Kaehlcke
2022-05-23 1:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZhJ/3xPwzaBSUS@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cychiang@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=judyhsiao@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).