From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org
Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
mka@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/5] platform/chrome: cros_kbd_led_backlight: separate ACPI backend
Date: Thu, 9 Jun 2022 07:45:07 +0000 [thread overview]
Message-ID: <YqGlA/5CK4lX95ge@google.com> (raw)
In-Reply-To: <20220523090822.3035189-3-tzungbi@kernel.org>
On Mon, May 23, 2022 at 05:08:19PM +0800, Tzung-Bi Shih wrote:
> cros_kbd_led_backlight uses ACPI_KEYBOARD_BACKLIGHT_WRITE and
> ACPI_KEYBOARD_BACKLIGHT_READ for setting and getting the brightness
> respectively.
>
> Separate ACPI operations for preparing the driver to support other
> backends.
The patch is the last one in the series that hasn't got a R-b tag.
I have tested the patch on an ADL-P-based chromebook and the keyboard
backlight works. Could anyone on the list help to review the patch?
next prev parent reply other threads:[~2022-06-09 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 9:08 [PATCH v4 0/5] platform/chrome: cros_kbd_led_backlight: add EC PWM backend Tzung-Bi Shih
2022-05-23 9:08 ` [PATCH v4 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically Tzung-Bi Shih
2022-05-23 9:08 ` [PATCH v4 2/5] platform/chrome: cros_kbd_led_backlight: separate ACPI backend Tzung-Bi Shih
2022-06-09 7:45 ` Tzung-Bi Shih [this message]
2022-06-09 12:44 ` Guenter Roeck
2022-05-23 9:08 ` [PATCH v4 3/5] dt-bindings: add google,cros-kbd-led-backlight Tzung-Bi Shih
2022-05-23 9:08 ` [PATCH v4 4/5] platform/chrome: cros_kbd_led_backlight: support OF match Tzung-Bi Shih
2022-05-24 20:08 ` Matthias Kaehlcke
2022-05-25 3:33 ` Tzung-Bi Shih
2022-05-25 15:11 ` Matthias Kaehlcke
2022-05-25 18:40 ` Prashant Malani
2022-05-23 9:08 ` [PATCH v4 5/5] platform/chrome: cros_kbd_led_backlight: support EC PWM backend Tzung-Bi Shih
2022-05-24 21:44 ` Matthias Kaehlcke
2022-05-24 0:50 ` [PATCH v4 0/5] platform/chrome: cros_kbd_led_backlight: add " patchwork-bot+chrome-platform
2022-05-24 1:28 ` Tzung-Bi Shih
2022-06-10 2:40 ` patchwork-bot+chrome-platform
2022-06-10 4:40 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqGlA/5CK4lX95ge@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).