From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 067D0C43334 for ; Fri, 10 Jun 2022 11:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346810AbiFJLxW (ORCPT ); Fri, 10 Jun 2022 07:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347365AbiFJLxU (ORCPT ); Fri, 10 Jun 2022 07:53:20 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 05AAE203D13 for ; Fri, 10 Jun 2022 04:53:18 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D3AA12FC for ; Fri, 10 Jun 2022 04:53:18 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4B2563F766 for ; Fri, 10 Jun 2022 04:53:18 -0700 (PDT) Date: Fri, 10 Jun 2022 12:53:11 +0100 From: Liviu Dudau To: Andre Przywara Cc: David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: display: arm,malidp: remove bogus RQOS property Message-ID: References: <20220609162729.1441760-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220609162729.1441760-1-andre.przywara@arm.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 09, 2022 at 05:27:29PM +0100, Andre Przywara wrote: > As Liviu pointed out, the arm,malidp-arqos-high-level property > mentioned in the original .txt binding was a mistake, and > arm,malidp-arqos-value needs to take its place. > > The binding commit ce6eb0253cba ("dt/bindings: display: Add optional > property node define for Mali DP500") mentions the right name in the > commit message, but has the wrong name in the diff. > Commit d298e6a27a81 ("drm/arm/mali-dp: Add display QoS interface > configuration for Mali DP500") uses the property in the driver, but uses > the shorter name. > > Remove the wrong property from the binding, and use the proper name in > the example. The actual property was already documented properly. > > Fixes: 2c8b082a3ab1 ("dt-bindings: display: convert Arm Mali-DP to DT schema") > Link: https://lore.kernel.org/linux-arm-kernel/YnumGEilUblhBx8E@e110455-lin.cambridge.arm.com/ > Signed-off-by: Andre Przywara > Reported-by: Liviu Dudau Reviewed-by: Liviu Dudau Thanks for cleaning this up! Best regards, Liviu > --- > Documentation/devicetree/bindings/display/arm,malidp.yaml | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/arm,malidp.yaml b/Documentation/devicetree/bindings/display/arm,malidp.yaml > index 795a08ac9f128..2a17ec6fc97c0 100644 > --- a/Documentation/devicetree/bindings/display/arm,malidp.yaml > +++ b/Documentation/devicetree/bindings/display/arm,malidp.yaml > @@ -71,11 +71,6 @@ properties: > - description: number of output lines for the green channel (G) > - description: number of output lines for the blue channel (B) > > - arm,malidp-arqos-high-level: > - $ref: /schemas/types.yaml#/definitions/uint32 > - description: > - integer describing the ARQoS levels of DP500's QoS signaling > - > arm,malidp-arqos-value: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > @@ -113,7 +108,7 @@ examples: > clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>; > clock-names = "pxlclk", "mclk", "aclk", "pclk"; > arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; > - arm,malidp-arqos-high-level = <0xd000d000>; > + arm,malidp-arqos-value = <0xd000d000>; > > port { > dp0_output: endpoint { > -- > 2.25.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯