From: Patrick Williams <patrick@stwcx.xyz>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Potin Lai <potin.lai@quantatw.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Update Facebook Bletchley BMC DTS
Date: Mon, 13 Jun 2022 11:54:45 -0500 [thread overview]
Message-ID: <Yqdr1ZS6d71QeACd@heinlein.stwcx.org.github.beta.tailscale.net> (raw)
In-Reply-To: <20220613095150.21917-1-potin.lai.pt@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Mon, Jun 13, 2022 at 05:51:46PM +0800, Potin Lai wrote:
> Update below items for Facebook Bletchley BMC devicetree.
>
> Potin Lai (4):
> ARM: dts: aspeed: bletchley: change LED sys_log_id to active low
> ARM: dts: aspeed: bletchley: disable GPIOV2 pull-down
> ARM: dts: aspeed: bletchley: bind presence-sledX pins via gpio-keys
> ARM: dts: aspeed: bletchley: update fusb302 nodes
>
> .../dts/aspeed-bmc-facebook-bletchley.dts | 197 +++++++++++++-----
> 1 file changed, 148 insertions(+), 49 deletions(-)
The whole patch set looks good to me as the closest domain expert to the
Bletchley system after Potin.
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-13 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 9:51 [PATCH 0/4] Update Facebook Bletchley BMC DTS Potin Lai
2022-06-13 9:51 ` [PATCH 1/4] ARM: dts: aspeed: bletchley: change LED sys_log_id to active low Potin Lai
2022-06-13 9:51 ` [PATCH 2/4] ARM: dts: aspeed: bletchley: disable GPIOV2 pull-down Potin Lai
2022-06-13 9:51 ` [PATCH 3/4] ARM: dts: aspeed: bletchley: bind presence-sledX pins via gpio-keys Potin Lai
2022-06-13 9:51 ` [PATCH 4/4] ARM: dts: aspeed: bletchley: update fusb302 nodes Potin Lai
2022-06-13 16:54 ` Patrick Williams [this message]
2022-06-22 14:36 ` [PATCH 0/4] Update Facebook Bletchley BMC DTS Potin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqdr1ZS6d71QeACd@heinlein.stwcx.org.github.beta.tailscale.net \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).