From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 249EDCCA473 for ; Wed, 15 Jun 2022 10:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347232AbiFOKJo (ORCPT ); Wed, 15 Jun 2022 06:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346476AbiFOKJn (ORCPT ); Wed, 15 Jun 2022 06:09:43 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE13649938 for ; Wed, 15 Jun 2022 03:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=ONJnBXu6t4zF8NFHPUMTOY/c4b3k CKbK/S/MH3jepMo=; b=zvrfXKeOW4l0ubRQcvx6RZ39t/9w00DZSEy6CJn8yqWl e8uJf8AUcamd7DZCpbuEawNVFPUXhkuj1ukGv2fkdFZT/+TGkPtdGXKYw6xA2U3a TcRNXgb593WpgGlaNpSgtkgZhAmAbwKzsParp/WzdTxhYwKHDO6qlcgycwGS1KE= Received: (qmail 2072654 invoked from network); 15 Jun 2022 12:09:39 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 15 Jun 2022 12:09:39 +0200 X-UD-Smtp-Session: l3s3148p1@0cYUuHnhYW1ZD+7R Date: Wed, 15 Jun 2022 12:09:39 +0200 From: Wolfram Sang To: Geert Uytterhoeven Cc: Linux-Renesas , Niklas =?utf-8?Q?S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Subject: Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Message-ID: Mail-Followup-To: Wolfram Sang , Geert Uytterhoeven , Linux-Renesas , Niklas =?utf-8?Q?S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List References: <20220610201701.7946-1-wsa+renesas@sang-engineering.com> <20220610201701.7946-2-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Wx79W/Vpvtk065FE" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --Wx79W/Vpvtk065FE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > What about splitting this in two separate checks at the top level: > > > - one for regs (R-Car V3U vs. the world), and > > > - a second for interrupts (R-Car V3U+S4-8 vs. the world)? > > > > This task seems too much for my YAML-foo :( I couldn't get it to work. > > Can we leave it as-is for now? >=20 > You just need an allOf with two if statements, cfr. e.g. > Documentation/devicetree/bindings/media/renesas,vin.yaml? First, I don't think the negative logic is as bad here because there is no 'else' block which is far away. Second, I think we need a 'not' anyhow because the condition is: 'if not r8a779f0 then required interrupts' Third, I still think we can fix it incrementally later if we want. The new board has enough issues to take care of. For now, I'd rather investigate those than YAML ;) --Wx79W/Vpvtk065FE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmKpr98ACgkQFA3kzBSg KbZS3A//Vv1st2Dr/K5iI3fgTRG5fR5kAvsNf1rSb2Oa6Vfr0qL2KNeWKOhVwnFH n8R4myFDto8c5Exs3p9vuyVDGizGQlPfBxk6C2QX0kVW/AA0QDgbxFStfvkEQr64 SubiEf0eGY3ds+7PG+nk21GBqn//sna1k0SdOxKpEADj5R3HCJRqaN1v4FPiwZ23 74GbZsbns997EW5XjU6FwrTQV6TidTGjLTl5+DnnR9OVOV8WVsSBnphShl0RdOv1 Gs7i3JqKRKG7iN6xU+4ZfPhyNBB7iW0VaXBpcCOikhMxwD5QzBCim7vx5HPRIjCm HAGSgSnBSbnRcnGkEEiAP+2LIif9g9nn9ST1QSQYUS57iIuZIGw2G+5kXABem4LB OwcUMUAnrMxnrjYA2L43qDjHQVxT4Na0CI+qtxShvrGgTWTB7zX54AI02FMUiQcM 12RwN+Jy8tnd1bSKPSAzqQaxe5BQpPPJjK7YAe8hr24lJpXxdZmz0HsCWDCNCbw7 fNFcB3i7CWDr3U+QXjQbuupHCrD/CL/SHkB//N+cx/UqqFGyIIf7en6HZJl1+fB7 cfUHZQg25PcpVh3dER5SvWysS+fhfO18Lja4xxVP+G3EtStY01rQm9kSUHHFQbJy ZB89mXAo5b/wiDYHqKd6nHEZhlxeTOegKbHA4J3kf2MTWSOvHRQ= =9reG -----END PGP SIGNATURE----- --Wx79W/Vpvtk065FE--