From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD274C433EF for ; Wed, 15 Jun 2022 21:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239985AbiFOVss (ORCPT ); Wed, 15 Jun 2022 17:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348444AbiFOVsh (ORCPT ); Wed, 15 Jun 2022 17:48:37 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BED736334 for ; Wed, 15 Jun 2022 14:48:35 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id x4so12579858pfj.10 for ; Wed, 15 Jun 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FZSDdV6mNRQiDJWSYS9igOAu0wbjoocy2kuoW1xZJug=; b=ZpEJrFA438ZSkfTtEVYExa6cnAWhsvmUfpjsXYhT3+RglSUp+BETn8FrcoVEUH1Xf3 w89oj7m1+dvWYEBxZTzq8TOIK8k7osRT9F74IS6tONgVl/5eeyTXRDi4TNMcOvgrgGyK vtqC3QS4kuPYkPGwcJ41fbjaNm+v47aPMQA70fUDHFmvVcvy3Fq8Id2wO6YPLQhbfk+m ObQQZHAfWJStEW2KMHfeluBeHBzPldcOqfOXoL4LybCKsNNGImxL7J0tQj3XW1OJ/Cs7 RYDFS/eBia5pw8WTh0ft13K/OGlBMrdMbKZ1B0ZXhfp2CZOsjSsA4O/eFJ6WV9w/PsIp 2IyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FZSDdV6mNRQiDJWSYS9igOAu0wbjoocy2kuoW1xZJug=; b=ILxPsvqpR7EEtAREL164NPTbKQniN1VOjt0/AW4JtIyHF8SswX4Sg/0T+Dwz8/uLHc V7OErwC6nKE6O6G/nLRVZ5Xsss/0jeg9Vo5o+ZAuthYmRoT4nSeJAcp3w05a14GJIN1Z TDMay9ssH3XgPQKBkR60qaTNbMuUYe0O95t0h752/nXqMuw1HbBWWrgDwUU8EF1VZ5Ct UZMFx+sX0nFD/3lTZgN6370xTq+to/tagH0KcB7GKKm6roogTNg3g5by5XWMgxVStz48 BhrpWdEM6KY623eLp8c+f1FoPj9rsjCfnknSURrC1cLaT11RGuDjYR+XjvCHdYbcgJ5w YvbQ== X-Gm-Message-State: AJIora9dyT6vP9eyAa5gNIPYUK0Eb8/cOCXgP5Mza/PjoBSZcv7qvFGS 4z+olTeSheLQqHBK7b8lxbrZDQ== X-Google-Smtp-Source: AGRyM1vkhWHhrlIjk/HHd51WfK5Or24gmvhP0SqUbOiKWv1kc7ZmeBlxTK44Ul6iywlD0zO883LPZg== X-Received: by 2002:aa7:94a6:0:b0:51b:ddb8:1fcf with SMTP id a6-20020aa794a6000000b0051bddb81fcfmr1411308pfl.23.1655329714602; Wed, 15 Jun 2022 14:48:34 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id u1-20020a170903124100b00163f8ddf160sm97347plh.161.2022.06.15.14.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 14:48:34 -0700 (PDT) Date: Wed, 15 Jun 2022 22:48:31 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys Message-ID: References: <20220520124617.228808-1-angelogioacchino.delregno@collabora.com> <20220520124617.228808-2-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220520124617.228808-2-angelogioacchino.delregno@collabora.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote: > MT6331 is a multifunction device, providing RTC, keys and more: add No such thing as an MFD. What does the data-sheet call it? What "more"? > the necessary compatibles to start implementing the basics. > > Signed-off-by: AngeloGioacchino Del Regno > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index d59063503b0d..2a9533c47365 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -30,6 +30,7 @@ Optional subnodes: > - rtc > Required properties: Should be one of follows > - compatible: "mediatek,mt6323-rtc" > + - compatible: "mediatek,mt6331-rtc" > - compatible: "mediatek,mt6358-rtc" > - compatible: "mediatek,mt6397-rtc" > For details, see ../rtc/rtc-mt6397.txt > @@ -55,6 +56,7 @@ Optional subnodes: > - keys > Required properties: > - compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys" > + or "mediatek,mt6331-keys" Please place these in a vertical list. > see ../input/mtk-pmic-keys.txt > > - power-controller -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog