From: Vinod Koul <vkoul@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Martin Povišer" <povik+lin@cutebit.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: apple,admac: Fix example interrupt parsing
Date: Thu, 16 Jun 2022 06:57:27 -0700 [thread overview]
Message-ID: <Yqs2x+BPbCxJvI6I@matsya> (raw)
In-Reply-To: <20220614152503.1410755-1-robh@kernel.org>
On 14-06-22, 09:25, Rob Herring wrote:
> Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning
> in its example:
>
> Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@238200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml
>
> The problem is the number of interrupt cells can't be guessed when
> there are empty '0' entries. So the example must have a valid interrupt
> controller defining the number of interrupt cells.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-06-16 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 15:25 [PATCH] dt-bindings: dma: apple,admac: Fix example interrupt parsing Rob Herring
2022-06-14 15:38 ` Martin Povišer
2022-06-16 13:57 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqs2x+BPbCxJvI6I@matsya \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=povik+lin@cutebit.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox