From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB512C433EF for ; Thu, 30 Jun 2022 03:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbiF3DB3 (ORCPT ); Wed, 29 Jun 2022 23:01:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbiF3DB2 (ORCPT ); Wed, 29 Jun 2022 23:01:28 -0400 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A037B34BA9 for ; Wed, 29 Jun 2022 20:01:26 -0700 (PDT) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-fb6b4da1dfso24079210fac.4 for ; Wed, 29 Jun 2022 20:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yCr9cRfs56yqMpVTk7a3xjU0D0ojSFJS/cwqqD+Mwz4=; b=ngUr5JbTktZVsE6b2wDE1emh5U9bmodR1UAxMTaBlSmDUGWfFYPF3wHBXMfWDLhXJP n/qR3sHWGifYOYsNOe74r8A7wqpV/cesxilsWLRghFsNRtAiSswOYuEwZCzpIZDM1mh4 cKfY1eb1jLbJ2Np34J5VHv9VzLSC+4/6Dxq/YDe6t6A1x7fdJOPt+wSNTOqPxh82hKFg LnoP6om9Tnfe576LjxKLp0K278QRD3f4+Vip0mBihn04GR101VPqaq56NsBtiFAiPmQb WImKFM4Yyk0gySnNu8yRXroRN8EUYk49/CXhSQYtGjNmsbDqPrrFaYqTevr3ohwuwQnH G3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yCr9cRfs56yqMpVTk7a3xjU0D0ojSFJS/cwqqD+Mwz4=; b=jC+HhotBxotFKR5b7tDMswN6HZpN4ZFP8DQEuJrDUakThjjw8SQQP450QJ0oTPLA4M VzrFJ/00b5AL1sWNij1r3nuqlzV2Eah+fjy3GEemPi+/XV7bjtCq3Ac8mqyZfHc9vCXB NGJjDzKAYjlLis1gOPxLNxSqxvVBIspsJ2z8vwVe5i2iu7DRCNjtcK5jXJnLfxvP+n40 sfObqOJkDJkvkhBwVa5vdEwukqpkqsEo7iCLeOkCcAvzhRiMLu3N6FpaVd5Ugo4OEsFK sTULCEkPhE+AuFQTAJwCSNsxjNBb1hrbqENbPIulBOst2Y2s6tU+mRRZKqhxIVQTqMgU YAqw== X-Gm-Message-State: AJIora+tAYyUm7YKAmx1ZVdL37sVuenr+9eOAMqtrio/7koOkpxbN8/W nEMcjTJax1gTcpLZHCopBSb7ag== X-Google-Smtp-Source: AGRyM1vxT3RmDtNp225rcfbgqMVN0MXLUHrf6ZTMF6e39DiFAQWayxlwxzX45ESPDVpd+TEJvUiPCg== X-Received: by 2002:a05:6870:cd06:b0:108:c466:4c7e with SMTP id qk6-20020a056870cd0600b00108c4664c7emr3752591oab.62.1656558085963; Wed, 29 Jun 2022 20:01:25 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id cm8-20020a056870b60800b00101d05c2245sm12219096oab.37.2022.06.29.20.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 20:01:24 -0700 (PDT) Date: Wed, 29 Jun 2022 22:01:22 -0500 From: Bjorn Andersson To: Stephan Gerhold Cc: Rob Herring , Krzysztof Kozlowski , Manivannan Sadhasivam , Jassi Brar , Johan Hovold , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: add SC8280XP platform Message-ID: References: <20220629041438.1352536-1-bjorn.andersson@linaro.org> <20220629041438.1352536-4-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 29 Jun 13:42 CDT 2022, Stephan Gerhold wrote: > On Tue, Jun 28, 2022 at 09:14:36PM -0700, Bjorn Andersson wrote: > > Introduce initial support for the Qualcomm SC8280XP platform, aka 8cx > > Gen 3. This initial contribution supports SMP, CPUfreq, CPU cluster > > idling, GCC, TLMM, SMMU, RPMh regulators, power-domains and clocks, > > interconnects, some QUPs, UFS, remoteprocs, USB, watchdog, LLCC and > > tsens. > > > > Signed-off-by: Bjorn Andersson > > Reviewed-by: Johan Hovold > > Reviewed-by: Konrad Dybcio > > Reviewed-by: Krzysztof Kozlowski > > --- > > > > Changes since v2: > > - Fixed include sort order > > - Dropped a stray newline in &CPU0 > > - Renamed reserved-memory regions > > - Dropped clock-frequency of the timers node > > - Reduced #address-cells and #size-cells to 1 in timer node > > > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2142 ++++++++++++++++++++++++ > > 1 file changed, 2142 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > new file mode 100644 > > index 000000000000..c9d608ac87fa > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > @@ -0,0 +1,2142 @@ > [...] > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = , > > + , > > + , > > + ; > > + clock-frequency = <19200000>; > > Please drop the "clock-frequency" here as well (if possible). > Sorry, missed that commend from your previous feedback. Will drop this as I'm applying the patches. Thanks, Bjorn