From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EBEC43334 for ; Thu, 30 Jun 2022 11:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235027AbiF3Lgl (ORCPT ); Thu, 30 Jun 2022 07:36:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230363AbiF3Lgk (ORCPT ); Thu, 30 Jun 2022 07:36:40 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98F7E5A446; Thu, 30 Jun 2022 04:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YUegSAtrHJuf++oLd2AkDHyUJS1bF226T9zeUPibzdI=; b=a7IyqWkdA70BWwqXqNN4nS6fTV 52K3yOWMROiMYthiioE0NOH9Ir1XwJG5ltYsjVradu9PNBobke0xtZqhLqFjls/9RKQR56sB49MrW UYUziAQa0i7ekm0yvuTbY0H2eeMjLvComguGJCv7m4g410lnooasvXKDqntBVQx98MsSy9rP+DFtH o2EK19blD/VcqDrCuffcK/Up1avcHPtMBF1Aa1x01aIlWqtC+C7emT76eSYTUdp08/x4ZNczFdWPL dRPwpftJN3R++G3Ac//nPYu5d3WJDfL8VpUNVA+p/YzfUMztYnIBtQrIWQySDu3wOyE55YtMIPaB4 pFXs5xRg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33114) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o6sTI-0004Lw-8e; Thu, 30 Jun 2022 12:36:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1o6sTB-0006kW-4c; Thu, 30 Jun 2022 12:36:25 +0100 Date: Thu, 30 Jun 2022 12:36:25 +0100 From: "Russell King (Oracle)" To: Arun Ramadoss Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Subject: Re: [Patch net-next v14 10/13] net: dsa: microchip: lan937x: add phylink_get_caps support Message-ID: References: <20220630102041.25555-1-arun.ramadoss@microchip.com> <20220630102041.25555-11-arun.ramadoss@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630102041.25555-11-arun.ramadoss@microchip.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 30, 2022 at 03:50:38PM +0530, Arun Ramadoss wrote: > The internal phy of the LAN937x are capable of 100Mbps speed. And the Good English grammar suggests never to start a sentence with "And". > xMII port of switch is capable of 10/100/1000Mbps. ... and supports flow control? > +void lan937x_phylink_get_caps(struct ksz_device *dev, int port, > + struct phylink_config *config) > +{ > + config->mac_capabilities = MAC_100FD; > + > + if (dev->info->supports_rgmii[port]) { > + /* MII/RMII/RGMII ports */ > + config->mac_capabilities |= MAC_ASYM_PAUSE | MAC_SYM_PAUSE | > + MAC_100HD | MAC_10 | MAC_1000FD; And SGMII too? (Which seems to be a given because from your list in the series cover message, SGMII ports also support RGMII). Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!