From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF20CCA473 for ; Thu, 30 Jun 2022 21:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236933AbiF3V4t (ORCPT ); Thu, 30 Jun 2022 17:56:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237370AbiF3V4s (ORCPT ); Thu, 30 Jun 2022 17:56:48 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE76B564FC for ; Thu, 30 Jun 2022 14:56:45 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id s13-20020a0568301e0d00b00616ad12fee7so413224otr.10 for ; Thu, 30 Jun 2022 14:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8CS533fsVHbJlembFtrJaJOunJ/hjtVlmQosQykPOVU=; b=S/NpE6Kmx1CbuLYF7W63lIhTpwApNv2nYfn5k5hCaG3+u2eXBUGmP4fIq1dUGisMTw Z6TQkg5prg5MB0VGbx9nu39MvWpSFbdJ1IrFg5Q2urI0X65FMnfcAfjTMGnjMurkDFXL mdRJfacHhU6owX7jQL2PfmlJ+MMb0y/YegKjxg+VP8ppTBvgEUKR4LSdhAEgHeByL+dO /OFZCk5YDGbsigwdkuje2nI7PEPlHeX/BsG5isNHPTyxPT4GeRfjOypgmegh4jSEstao 5cDNQrLoivLUoQgFZ1Wr3/wwZpEzvT59MTfLSNRjIsQkZiK+5KhOAZEM6E5JhwQMyvHZ gENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8CS533fsVHbJlembFtrJaJOunJ/hjtVlmQosQykPOVU=; b=Q9ka2TJJACS4D/fxKmN9CUIeb9/XY/vD4Pd07sk4QLTevhYWchi0qBAPZYZP1W8kuy dibG7DER2dWEReyQVLN+eCyMKaS0baJAxrKS9UDSAzH3qtE9wrUJ8jwiExWH38ReeOFy IzcE0yQB1GSuZ+LnPId2G6tpDBueKKeXwKU6v1ba9Ce8+8fWXOFJ2y2g3NfXgGqMHqtq QJpOsTXw8Y3YpKfJUcyFlVCd7hf1A3y33U+zhNg9g8J0kSioxJrjIaA1oR7nnllTopbw fz0ad8dlwJdU0PXVpXIPSj1XnT9SR9wtWtm2aZZqkTcS7UL0oN0xfqTfZQneGsYIb5u/ LRKQ== X-Gm-Message-State: AJIora/M2nuXUBrXaOwaEwKw0QE/YwDS5fy86RbTSTmFj2im/DUVpWvP 8+Kvc7MwxgH90ffJriMb9Nmc6A== X-Google-Smtp-Source: AGRyM1tTcC8XQCvCGbbV3733NDMYY/C1kLs9792XFAckdaiHz/q/E2fq1m/b7ST5yNLUq66kTwVARA== X-Received: by 2002:a9d:2f25:0:b0:616:9255:2ff with SMTP id h34-20020a9d2f25000000b00616925502ffmr5006588otb.87.1656626205292; Thu, 30 Jun 2022 14:56:45 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r6-20020a056870580600b001089aef1815sm8952855oap.20.2022.06.30.14.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 14:56:44 -0700 (PDT) Date: Thu, 30 Jun 2022 16:56:42 -0500 From: Bjorn Andersson To: Dylan Van Assche Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom/sdm845-shift-axolotl: Enable pmi9889 LPG LED Message-ID: References: <20220512054439.13971-1-me@dylanvanassche.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512054439.13971-1-me@dylanvanassche.be> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 12 May 00:44 CDT 2022, Dylan Van Assche wrote: > Enables the RGB notification LED on the SHIFT 6mq (sdm845-shift-axolotl) > with the Qualcomm Light Pulse Generator bindings by Bjorn Andersson [1]. > Patches are merged in for-next branch of linux-leds. > Tested these changes on the SHIFT 6mq. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=a8e53db46f19f67be6a26488aafb7d10c78e33bd > > Signed-off-by: Dylan Van Assche > --- > .../boot/dts/qcom/sdm845-shift-axolotl.dts | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > index 847f6217a77b..af412ac2c9d0 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > @@ -2,11 +2,13 @@ > /* > * Copyright (c) 2022, Alexander Martinz > * Copyright (c) 2022, Caleb Connolly > + * Copyright (c) 2022, Dylan Van Assche > */ > > /dts-v1/; > > #include > +#include > #include > #include "sdm845.dtsi" > #include "pm8998.dtsi" > @@ -554,6 +556,33 @@ &pmi8998_smb2 { > monitored-battery = <&battery>; > }; > > +&pmi8998_lpg { We don't have this node, because no one has reviewed https://lore.kernel.org/all/20220505022706.1692554-1-bjorn.andersson@linaro.org/#t yet. If anyone could take a look I'd be happy to merge this as well. Thanks, Bjorn > + status = "okay"; > + > + multi-led { > + color = ; > + function = LED_FUNCTION_STATUS; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@3 { > + reg = <3>; > + color = ; > + }; > + > + led@4 { > + reg = <4>; > + color = ; > + }; > + > + led@5 { > + reg = <5>; > + color = ; > + }; > + }; > +}; > + > &qup_uart9_default { > pinconf-rx { > pins = "gpio5"; > -- > 2.36.1 >