From: LABBE Corentin <clabbe@baylibre.com>
To: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, m.reichl@fivetechno.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
stable@kernel.org
Subject: Re: [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering off the board during boot
Date: Mon, 20 Jun 2022 21:52:44 +0200 [thread overview]
Message-ID: <YrDQDLOXQKtPVgzU@Red> (raw)
In-Reply-To: <20220620110407.2393644-1-clabbe@baylibre.com>
Le Mon, Jun 20, 2022 at 11:04:07AM +0000, Corentin Labbe a écrit :
> The rk3399-roc-pc never finish booting because it is powered off when probing
> fusb302.
>
> The type c port is disabled because not present in DT as can seen in dmesg:
> OF: graph: no port node found in /i2c@ff3d0000/usb-typec@22
>
> So adding the port in DT (as needed by the device tree schema of
> fusb302), permits the board to survive and finish booting.
>
> CC: stable@kernel.org # 5.10+
> Fixes: 8bb878cf20ae ("arm64: dts: rockchip: add support for ROC-RK3399-PC board")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> This patch is tested on 5.10.123, 5.15.48 and next-20220614
>
Please ignore this for now, it fixes the issue but
[ 31.653778] typec_fusb302 7-0022: cannot register tcpm port, ret=-22
[ 31.659415] typec_fusb302: probe of 7-0022 failed with error -22
So while having a board which boot fine is better, having everything well probed will be better.
For fixing the probe error, adding the following is sufficiant:
@@ -558,6 +559,9 @@ connector {
data-role = "host";
label = "USB-C";
power-role = "dual";
+ op-sink-microwatt = <1000000>;
+ sink-pdos = <PDO_FIXED(5000, 2500, PDO_FIXED_USB_COMM)>;
+ source-pdos = <PDO_FIXED(5000, 1400, PDO_FIXED_USB_COMM)>;
ports {
#address-cells = <1>;
But this bring the initial issue, the board is still dont booting...
prev parent reply other threads:[~2022-06-20 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 11:04 [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering off the board during boot Corentin Labbe
2022-06-20 19:52 ` LABBE Corentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrDQDLOXQKtPVgzU@Red \
--to=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=robh+dt@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).