From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, vz@mleia.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
lukas@wunner.de, p.rosenberger@kunbus.com,
Lino Sanfilippo <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH 3/8] serial: core: move sanitizing of RS485 delays into own function
Date: Thu, 23 Jun 2022 19:25:07 +0300 [thread overview]
Message-ID: <YrST4zDJjSo5aNZh@smile.fi.intel.com> (raw)
In-Reply-To: <20220622154659.8710-4-LinoSanfilippo@gmx.de>
On Wed, Jun 22, 2022 at 05:46:54PM +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>
> Move the sanitizing of RS485 delays out of uart_sanitize_serial_rs485()
> into the new function uart_sanitize_serial_rs485_delays().
...
> + /* pick sane settings if the user hasn't */
Be consistent with the style (capitalization) of one-line comments. It might
require another patch to make it all consistent.
(Below is left for a context)
> /* Return clean padding area to userspace */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-23 16:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 15:46 [PATCH 0/8] Fixes and cleanup for RS485 Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 1/8] serial: core: only get RS485 termination gpio if supported Lino Sanfilippo
2022-06-22 17:04 ` Andy Shevchenko
2022-06-23 1:59 ` Lino Sanfilippo
2022-06-23 9:45 ` Andy Shevchenko
2022-06-23 16:08 ` Lino Sanfilippo
2022-06-23 16:32 ` Andy Shevchenko
2022-06-23 20:19 ` Lino Sanfilippo
2022-06-25 19:49 ` Lukas Wunner
2022-06-27 9:05 ` Ilpo Järvinen
2022-07-02 16:50 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 2/8] serial: core, 8250: set RS485 termination gpio in serial core Lino Sanfilippo
2022-06-22 17:06 ` Andy Shevchenko
2022-06-23 2:03 ` Lino Sanfilippo
2022-06-25 10:40 ` Ilpo Järvinen
2022-06-26 15:41 ` Lino Sanfilippo
2022-06-25 19:58 ` Lukas Wunner
2022-06-26 13:36 ` Lino Sanfilippo
2022-06-28 8:31 ` Ilpo Järvinen
2022-06-22 15:46 ` [PATCH 3/8] serial: core: move sanitizing of RS485 delays into own function Lino Sanfilippo
2022-06-23 16:25 ` Andy Shevchenko [this message]
2022-06-23 20:17 ` Lino Sanfilippo
2022-06-25 9:37 ` Ilpo Järvinen
2022-06-22 15:46 ` [PATCH 4/8] serial: core: sanitize RS485 delays read from device tree Lino Sanfilippo
2022-06-25 10:05 ` Ilpo Järvinen
2022-06-26 14:25 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 5/8] dt_bindings: rs485: Correct delay values Lino Sanfilippo
2022-06-23 16:29 ` Andy Shevchenko
2022-06-23 20:17 ` Lino Sanfilippo
2022-06-25 9:54 ` Ilpo Järvinen
2022-06-27 9:23 ` Ilpo Järvinen
2022-06-28 10:03 ` Andy Shevchenko
2022-06-29 23:50 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 6/8] serial: 8250_dwlib: remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-06-25 10:21 ` Ilpo Järvinen
2022-06-22 15:46 ` [PATCH 7/8] serial: ar933x: Remove redundant assignment in rs485_config Lino Sanfilippo
2022-06-25 10:14 ` Ilpo Järvinen
2022-06-26 14:09 ` Lino Sanfilippo
2022-06-27 8:14 ` Ilpo Järvinen
2022-06-30 0:33 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 8/8] serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-06-25 10:18 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrST4zDJjSo5aNZh@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=p.rosenberger@kunbus.com \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).