From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9E1C433EF for ; Mon, 27 Jun 2022 20:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239143AbiF0Uk1 (ORCPT ); Mon, 27 Jun 2022 16:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235320AbiF0Uk0 (ORCPT ); Mon, 27 Jun 2022 16:40:26 -0400 Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF523DED5 for ; Mon, 27 Jun 2022 13:40:25 -0700 (PDT) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-101ab23ff3fso14489578fac.1 for ; Mon, 27 Jun 2022 13:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jmzqCLZEusFvK30GUvwarTPAI/2hAGgafpqukT2uCeY=; b=F0+f2j6fH/kSwW8e/OqSf1WkPdi/HOLnWsY5Wc11wwGJIJHoHKiCOiRdy0CBi4xpC/ UjF8PzFLbSdglDlCkSvxR23w6DYPoR4VC8KvlNg6/+q8nXASFfihtjl1ntPTBtdvm0hp GYW7SbFIoQ+kMeMbgcn3KJ6yRldtsLD7RvVe72K27HWOXBi/cgvEqJnn82d7Ikcsntuz 028Xoy0Q2Xzlfvvt+U8FwqmrZrIrhlL1GME62bwBqNf1FA8+Rz1/h5EJ2CowyRJs9ZPp w5xofn+9XZmS2+3Y1W8XMNNk1lyHpBoy5T17Xt6Ut2iQT1WpCXXMG27pNoRSBx4Ic4CC jslA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jmzqCLZEusFvK30GUvwarTPAI/2hAGgafpqukT2uCeY=; b=em/Yg7tvv1FkqBg39DTbEdojlsR3euNtnSuU+LFW/FoAEk9SZcPLJfGGFBk3BH1Ke5 Bxgg/NTxOOmk7Sc/NM78q5ZWdzqt1dJ4RqZ9lNCTZ6pgV/McKJI9Y99qWKEPz97r1I1P X1mfIkgPkip90kfQjq4rgCDvorIELoPF+mJ5NK4o0t0DwVM2InVYQzLMHo9zkjyXYZ9c ujXyARou9eunsaWVzykiRWc1LhZOsOMlX8WsI4FplXf88SyDRyIV7zpXbMucO5eRt2d9 J2JxICNaegFyfzcjK9yNH+45hI+qUADAnU3KhwVGwfC9NF7Cn56tTzn+Ecq1NR6MtN4i 28+w== X-Gm-Message-State: AJIora+OSsc/z9KWckt3l75vBuQinUgUcFe4czBDZaogwvykpC9OTpNH BtKHJhorojH8P+ZmvcvMqvf9Vw== X-Google-Smtp-Source: AGRyM1t6hiie7pEhqg3xvsIsHHhFpIuSUQyQD0JXZnqL06hesjet/y04wFsLleqR34mUqH2RbK0jUQ== X-Received: by 2002:a05:6870:f616:b0:f2:dac0:e339 with SMTP id ek22-20020a056870f61600b000f2dac0e339mr11702877oab.116.1656362425179; Mon, 27 Jun 2022 13:40:25 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c13-20020aca1c0d000000b003351dbf5e36sm5835177oic.43.2022.06.27.13.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 13:40:24 -0700 (PDT) Date: Mon, 27 Jun 2022 15:40:22 -0500 From: Bjorn Andersson To: Bryan O'Donoghue , Liam Girdwood , Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , srinivas.kandagatla@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] ASoC: qcom: lpass: Fix apq8016 compat string to match yaml Message-ID: References: <20220429220349.1142759-1-bryan.odonoghue@linaro.org> <20220429220349.1142759-2-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429220349.1142759-2-bryan.odonoghue@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 29 Apr 17:03 CDT 2022, Bryan O'Donoghue wrote: Adding the sound maintainers to To/Cc, please advice if you would prefer Bryan to resubmit the patch with proper recipients. > The documented yaml compat string for the apq8016 is > "qcom,apq8016-lpass-cpu" not "qcom,lpass-cpu-apq8016". Looking at the other > lpass compat strings the general form is "qcom,socnum-lpass-cpu". > > We need to fix both the driver and dts to match. > > Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support") > Reviewed-by: Srinivas Kandagatla > Signed-off-by: Bryan O'Donoghue Reviewed-by: Bjorn Andersson Once this patch is picked up I can merge the dts change. Regards, Bjorn > --- > sound/soc/qcom/lpass-apq8016.c | 1 + > sound/soc/qcom/lpass-cpu.c | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c > index 3efa133d1c64..abaf694ee9a3 100644 > --- a/sound/soc/qcom/lpass-apq8016.c > +++ b/sound/soc/qcom/lpass-apq8016.c > @@ -293,6 +293,7 @@ static struct lpass_variant apq8016_data = { > > static const struct of_device_id apq8016_lpass_cpu_device_id[] __maybe_unused = { > { .compatible = "qcom,lpass-cpu-apq8016", .data = &apq8016_data }, > + { .compatible = "qcom,apq8016-lpass-cpu", .data = &apq8016_data }, > {} > }; > MODULE_DEVICE_TABLE(of, apq8016_lpass_cpu_device_id); > diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c > index e6846ad2b5fa..53f9bf6581d3 100644 > --- a/sound/soc/qcom/lpass-cpu.c > +++ b/sound/soc/qcom/lpass-cpu.c > @@ -1102,6 +1102,11 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) > if (!match || !match->data) > return -EINVAL; > > + if (of_device_is_compatible(dev->of_node, "qcom,lpass-cpu-apq8016")) { > + dev_warn(dev, "%s compatible is deprecated\n", > + match->compatible); > + } > + > drvdata->variant = (struct lpass_variant *)match->data; > variant = drvdata->variant; > > -- > 2.35.1 >