From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D037C43334 for ; Mon, 27 Jun 2022 20:55:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231700AbiF0Uy7 (ORCPT ); Mon, 27 Jun 2022 16:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiF0Uy6 (ORCPT ); Mon, 27 Jun 2022 16:54:58 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7D502ACD for ; Mon, 27 Jun 2022 13:54:56 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id u9so14467136oiv.12 for ; Mon, 27 Jun 2022 13:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+wu8FbJfJ+Q9MxmPPrAR91FAjnYekUfFagsceeKXjh0=; b=loSSV131mIFKt3HpYTok7q4CoL9EKNUepLdX1KxCRXfu8a57sYL2uzn14dMUx/gSSk VFxRQ53JaaPjOhxKg5QR/5lW7P6NuePeUVL8A45QCT0xNOi9ZcH2Kag49Pz3PQOddYhD 832ct3sFqIPJsHlWcoVfdoi5ySm8yAflN71laKCOlM331XmwE5gKW29jvnTW8ZJ/bk+F Kmo+p5JbqhBZM1+smuwJ7F6i3aM5zbHfZieorgBQGA4UCHs99cTdVgIKqBI1s1EwBena Q9rzvAN5ccj9luYtSSME8+YZ/NhcLOf60XnbyjjhH/mkAhE2aJe7mQR5szplNQzUh3rP vzwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+wu8FbJfJ+Q9MxmPPrAR91FAjnYekUfFagsceeKXjh0=; b=ZFKawAYcr7zwI7VXSQRr2NUPNgCEMnmDmZ6C8s2q3toj7V1M/amOsrbSsq2yzHxfum kilZ8+Mgt9QiUCWfghaK3sbUgHYq5xMVrjCH4HWsX6lX3ikNSa1I5kbH2Q3QCcl/ZKxD k2SImSXjiWhCpgQ0HUGQ6NVK9pEj3DILiPUKKP7LwkzYC3HqHd876xlY7y5MISgZDYxx NCp1w0tDF6aAM6el7yzHuiGe01U0UsE4tHAjQhfxblKuXKKUcK7CESNCPwxUAk3721JK Ys/W6JgshXu+upg3b1niiJaHMBCRn0Wptu11c4IJ++URKvtqMd0sI0nksOHuj3LT6K4a AhQQ== X-Gm-Message-State: AJIora8TqKHpkyxcY4hys4l/ELAfX2AwuL386USIxJT8ysKlQOCc30qo YswKekZqR5FnmiS9UBUOXxBG1wI3ohmymw== X-Google-Smtp-Source: AGRyM1tgbmKXwzWoirqUL53jUbbUZ64FHe+zsXVc527cYaSy3639GImZYXL6jCmaQhREfAnBhkhhDg== X-Received: by 2002:a05:6808:1202:b0:2f9:c7b4:fd56 with SMTP id a2-20020a056808120200b002f9c7b4fd56mr8925688oil.55.1656363296088; Mon, 27 Jun 2022 13:54:56 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w12-20020a056870a2cc00b000f33624baa4sm7751272oak.18.2022.06.27.13.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 13:54:55 -0700 (PDT) Date: Mon, 27 Jun 2022 15:54:53 -0500 From: Bjorn Andersson To: Ansuel Smith Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Andy Gross , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml Message-ID: References: <20220430060125.9124-1-ansuelsmth@gmail.com> <20220430060125.9124-4-ansuelsmth@gmail.com> <626d4cbf.1c69fb81.e6965.76b4@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <626d4cbf.1c69fb81.e6965.76b4@mx.google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat 30 Apr 02:42 CDT 2022, Ansuel Smith wrote: > On Sat, Apr 30, 2022 at 04:40:54PM +0200, Krzysztof Kozlowski wrote: > > On 30/04/2022 08:01, Ansuel Smith wrote: > > > Convert kpss-gcc driver Documentation to yaml. > > > Add #clock-cells additional binding to required bindings and example > > > as it's a required binding for clock-output-names. > > > > > > Signed-off-by: Ansuel Smith > > > > > > (...) > > > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - qcom,kpss-gcc-ipq8064 > > > + - qcom,kpss-gcc-apq8064 > > > + - qcom,kpss-gcc-msm8974 > > > + - qcom,kpss-gcc-msm8960 > > > + - const: qcom,kpss-gcc > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: phandle to pll8_vote > > > + - description: phandle to pxo_board > > > + > > > + clock-names: > > > + items: > > > + - const: pll8_vote > > > + - const: pxo > > > + > > > + clock-output-names: > > > + const: acpu_l2_aux > > > > It does not make sense having a constant output name. What is the > > meaning this property in such case? The original binding did not enforce it. > > > > > > > > Best regards, > > Krzysztof > > Mh. Should I just drop the const and put a description referring to an > advised name? The driver with the kpss-gcc hardcode the name to > acpu_l2_aux that's why I thought it was a correct conversion using a > const but I assume this is another problem of not making a correct 1:1 > conversion and adding fixes on pure conversion. > Think I should drop it and put a description to it. (and then later fix > it when I will push the other series with all the tweaks) > > What do you think? > The typical reason for using clock-output-names is that we have some consumer that finds the clock based on global name lookup. Over time we've been moving these to use .fw_name or .index based lookup, which removes this problem. But I don't see that being the case here. So my suggestion is that you just drop clock-output-names from the binding, which will solve Krzysztof's objection. >From there we can review what needs to be done in the Linux driver to work with the improved binding. Regards, Bjorn