From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F5CC43334 for ; Mon, 27 Jun 2022 23:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240984AbiF0XpP (ORCPT ); Mon, 27 Jun 2022 19:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235759AbiF0XpO (ORCPT ); Mon, 27 Jun 2022 19:45:14 -0400 Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F73013D5C for ; Mon, 27 Jun 2022 16:45:13 -0700 (PDT) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-101ec2d6087so14979560fac.3 for ; Mon, 27 Jun 2022 16:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JaMdLUpzUEQzCOSIwEtqS/GjUV8YB+oAIJlz8iaWB+8=; b=JghfqMZr64wnajx380Ff1UlvS6R6UvF/CHEiPFbxidjKIVe7Iw9MzbHFkYCLEI5I64 vSJeAU77bam22qw+2fkx55Nzg626PgmGZ1M/8BhjD8BPkEQC4atkUCnEXqk3D7FSqDIK ublEJGlYKx8h4gXRx2562uFAv/WOMEp+puSDKgQoPf9e0s6zYJPnULxn7tFippMOViKT rH6whOiSrqkRuqYKzaLsDxTkV54v1N9NUzuNIzz+7R9hcfRLoyWsBG9dgemfWqbC2j5M 9OUwy1CXkaS49Tw+68bmjYvQ3R/vuMFBvnG7202RPjZCyreNrY98EaNsHFd23Kp2dd3O jApg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JaMdLUpzUEQzCOSIwEtqS/GjUV8YB+oAIJlz8iaWB+8=; b=KRsh0Vw2looKhjY6fuOmoZlWXlywOeNUL2Vk8gsO49jNhznnSsMKBwWZ656wHGffSt aXGP2QdNJDuAtu3pbioSmufWtDcZ+1FbUvmkVWICpc37kz9APWRHk1qF50gMiRgBnSq0 FXdUieQczXmVCLzUCi8LqDbKHvkQrfzXLCKV2creLqeb/H5AmGi5E2mT8bH6a7o2r/Zc ul0GaJ8F/yNYZD8J4KS0EMpsKKjdBX2G+/0jD7KNkZeH9znGunpAeM7xKKY4c93wz2Jq XS9QpC8ua7eVVtEsrTIxsQXWwGIpeX2uSPcQwtdwDtJiz3v2SkYN95LyX/s7xwdQfQxD 237g== X-Gm-Message-State: AJIora/F/TGwGYpH2Mh6b0DPyt2f0IvpERYCQa9ORrLg8Tj0R9kpBaXV dPVxpQfkqetkdzs0vyvMaD7NCA== X-Google-Smtp-Source: AGRyM1sMuQmjxILi9LTtPRGd4OD0XjJ1elk6f1SJCAPbmrKGzSRTftlh28jUl3kkreE4f8lvUpo5Zw== X-Received: by 2002:a05:6870:c8f:b0:106:a09f:e79f with SMTP id mn15-20020a0568700c8f00b00106a09fe79fmr11663883oab.174.1656373512901; Mon, 27 Jun 2022 16:45:12 -0700 (PDT) Received: from baldur (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id p2-20020a05680811c200b0032e3ffc5513sm6177925oiv.4.2022.06.27.16.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 16:45:12 -0700 (PDT) Date: Mon, 27 Jun 2022 18:45:05 -0500 From: Bjorn Andersson To: Christian Marangi Cc: Stephen Boyd , Andy Gross , Dmitry Baryshkov , Krzysztof Kozlowski , Michael Turquette , Rob Herring , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] clk: qcom: gcc-ipq806x: use parent_data for the last remaining entry Message-ID: References: <20220620215150.1875557-1-dmitry.baryshkov@linaro.org> <20220624003714.918ACC3411D@smtp.kernel.org> <62b50863.1c69fb81.be104.158e@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62b50863.1c69fb81.be104.158e@mx.google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 23 Jun 19:42 CDT 2022, Christian Marangi wrote: > On Thu, Jun 23, 2022 at 05:37:12PM -0700, Stephen Boyd wrote: > > Quoting Stephen Boyd (2022-06-23 17:27:18) > > > Quoting Dmitry Baryshkov (2022-06-20 14:51:50) > > > > Use parent_data for the last remaining entry (pll4). This clock is > > > > provided by the lcc device. > > > > > > > > Fixes: cb02866f9a74 ("clk: qcom: gcc-ipq806x: convert parent_names to parent_data") > > > > Cc: Ansuel Smith > > > > Signed-off-by: Dmitry Baryshkov > > > > --- > > > > drivers/clk/qcom/gcc-ipq806x.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c > > > > index 718de17a1e60..6447f3e81b55 100644 > > > > --- a/drivers/clk/qcom/gcc-ipq806x.c > > > > +++ b/drivers/clk/qcom/gcc-ipq806x.c > > > > @@ -79,7 +79,9 @@ static struct clk_regmap pll4_vote = { > > > > .enable_mask = BIT(4), > > > > .hw.init = &(struct clk_init_data){ > > > > .name = "pll4_vote", > > > > - .parent_names = (const char *[]){ "pll4" }, > > > > + .parent_data = &(const struct clk_parent_data){ > > > > + .fw_name = "pll4", .name = "pll4", > > > > > > Is there a DT binding update? > > > > Also I'd appreciate clk patches be sent to my kernel.org email instead > > of chromium to help my filters. > > Sorry for the OT but as you mention... there are many series for ipq806x > all reviewed. Wonder if they can be picked or should I RESEND them? > Sorry about that, I'm hoping to catch up on the pending patches in the coming few days... Regards, Bjorn > Some of them are blocking me from sending other fixes as the current > dtsi have wrong definition that would cause kernel panic (if things are > correctly implemented on the driver side) > > -- > Ansuel