* [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration
@ 2022-04-21 18:59 Dario Binacchi
0 siblings, 0 replies; 6+ messages in thread
From: Dario Binacchi @ 2022-04-21 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Dmitry Torokhov, Krzysztof Kozlowski,
Marco Felsch, Michael Trimarchi, Oliver Graute, Rob Herring,
Stephan Gerhold, devicetree, linux-input
The series was born from the analysis and mitigation of a crc problem
raised by an M06 type device. The added sysfs attributes were helpful
in debugging the problem. Patches that change the report rate on driver
probing, mitigated crc errors on kernel bootup. The patch to get/set
report rate by sysfs for an M12 device, has been tested.
Changes in v4:
- Add Rob Herring 'Acked-by' tag.
Changes in v3:
- Add hz unit suffix.
- Add '|' to description.
- Check the lower and upper limits of the report-rate-hz value
- Convert the M06 report-rate-hz value
Changes in v2:
- Add Oliver Graute's 'Acked-by' tag to:
* Input: edt-ft5x06 - show model name by sysfs
* Input: edt-ft5x06 - show firmware version by sysfs
- Fix yaml file. Tested with `make DT_CHECKER_FLAGS=-m dt_binding_check'.
Dario Binacchi (6):
dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
Input: edt-ft5x06 - get/set M12 report rate by sysfs
Input: edt-ft5x06 - set report rate by dts property
Input: edt-ft5x06 - show model name by sysfs
Input: edt-ft5x06 - show firmware version by sysfs
Input: edt-ft5x06 - show crc and header errors by sysfs
.../input/touchscreen/edt-ft5x06.yaml | 8 ++
drivers/input/touchscreen/edt-ft5x06.c | 103 ++++++++++++++++--
2 files changed, 103 insertions(+), 8 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration
@ 2022-05-05 15:56 Dario Binacchi
0 siblings, 0 replies; 6+ messages in thread
From: Dario Binacchi @ 2022-05-05 15:56 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Dmitry Torokhov, Krzysztof Kozlowski,
Marco Felsch, Michael Trimarchi, Oliver Graute, Rob Herring,
Stephan Gerhold, devicetree, linux-input
The series was born from the analysis and mitigation of a crc problem
raised by an M06 type device. The added sysfs attributes were helpful
in debugging the problem. Patches that change the report rate on driver
probing, mitigated crc errors on kernel bootup. The patch to get/set
report rate by sysfs for an M12 device, has been tested.
Changes in v4:
- Add Rob Herring 'Acked-by' tag.
Changes in v3:
- Add hz unit suffix.
- Add '|' to description.
- Check the lower and upper limits of the report-rate-hz value
- Convert the M06 report-rate-hz value
Changes in v2:
- Add Oliver Graute's 'Acked-by' tag to:
* Input: edt-ft5x06 - show model name by sysfs
* Input: edt-ft5x06 - show firmware version by sysfs
- Fix yaml file. Tested with `make DT_CHECKER_FLAGS=-m dt_binding_check'.
Dario Binacchi (6):
dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
Input: edt-ft5x06 - get/set M12 report rate by sysfs
Input: edt-ft5x06 - set report rate by dts property
Input: edt-ft5x06 - show model name by sysfs
Input: edt-ft5x06 - show firmware version by sysfs
Input: edt-ft5x06 - show crc and header errors by sysfs
.../input/touchscreen/edt-ft5x06.yaml | 8 ++
drivers/input/touchscreen/edt-ft5x06.c | 103 ++++++++++++++++--
2 files changed, 103 insertions(+), 8 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration
@ 2022-06-07 9:55 Dario Binacchi
0 siblings, 0 replies; 6+ messages in thread
From: Dario Binacchi @ 2022-06-07 9:55 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Dmitry Torokhov, Krzysztof Kozlowski,
Marco Felsch, Michael Trimarchi, Oliver Graute, Rob Herring,
devicetree, linux-input
The series was born from the analysis and mitigation of a crc problem
raised by an M06 type device. The added sysfs attributes were helpful
in debugging the problem. Patches that change the report rate on driver
probing, mitigated crc errors on kernel bootup. The patch to get/set
report rate by sysfs for an M12 device, has been tested.
Changes in v4:
- Add Rob Herring 'Acked-by' tag.
Changes in v3:
- Add hz unit suffix.
- Add '|' to description.
- Check the lower and upper limits of the report-rate-hz value
- Convert the M06 report-rate-hz value
Changes in v2:
- Add Oliver Graute's 'Acked-by' tag to:
* Input: edt-ft5x06 - show model name by sysfs
* Input: edt-ft5x06 - show firmware version by sysfs
- Fix yaml file. Tested with `make DT_CHECKER_FLAGS=-m dt_binding_check'.
Dario Binacchi (6):
dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
Input: edt-ft5x06 - get/set M12 report rate by sysfs
Input: edt-ft5x06 - set report rate by dts property
Input: edt-ft5x06 - show model name by sysfs
Input: edt-ft5x06 - show firmware version by sysfs
Input: edt-ft5x06 - show crc and header errors by sysfs
.../input/touchscreen/edt-ft5x06.yaml | 8 ++
drivers/input/touchscreen/edt-ft5x06.c | 103 ++++++++++++++++--
2 files changed, 103 insertions(+), 8 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration
@ 2022-06-21 12:39 Dario Binacchi
2022-06-21 12:39 ` [RESEND PATCH v4 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Dario Binacchi
2022-06-29 5:08 ` [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration Dmitry Torokhov
0 siblings, 2 replies; 6+ messages in thread
From: Dario Binacchi @ 2022-06-21 12:39 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Dmitry Torokhov, Krzysztof Kozlowski,
Marco Felsch, Michael Trimarchi, Oliver Graute, Rob Herring,
devicetree, linux-input
The series was born from the analysis and mitigation of a crc problem
raised by an M06 type device. The added sysfs attributes were helpful
in debugging the problem. Patches that change the report rate on driver
probing, mitigated crc errors on kernel bootup. The patch to get/set
report rate by sysfs for an M12 device, has been tested.
Changes in v4:
- Add Rob Herring 'Acked-by' tag.
Changes in v3:
- Add hz unit suffix.
- Add '|' to description.
- Check the lower and upper limits of the report-rate-hz value
- Convert the M06 report-rate-hz value
Changes in v2:
- Add Oliver Graute's 'Acked-by' tag to:
* Input: edt-ft5x06 - show model name by sysfs
* Input: edt-ft5x06 - show firmware version by sysfs
- Fix yaml file. Tested with `make DT_CHECKER_FLAGS=-m dt_binding_check'.
Dario Binacchi (6):
dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
Input: edt-ft5x06 - get/set M12 report rate by sysfs
Input: edt-ft5x06 - set report rate by dts property
Input: edt-ft5x06 - show model name by sysfs
Input: edt-ft5x06 - show firmware version by sysfs
Input: edt-ft5x06 - show crc and header errors by sysfs
.../input/touchscreen/edt-ft5x06.yaml | 8 ++
drivers/input/touchscreen/edt-ft5x06.c | 103 ++++++++++++++++--
2 files changed, 103 insertions(+), 8 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH v4 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
2022-06-21 12:39 [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration Dario Binacchi
@ 2022-06-21 12:39 ` Dario Binacchi
2022-06-29 5:08 ` [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: Dario Binacchi @ 2022-06-21 12:39 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Michael Trimarchi, Rob Herring, Dmitry Torokhov,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-input
It allows to change the M06/M12 default scan rate.
Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v4:
- Add Rob Herring 'Acked-by' tag.
Changes in v3:
- Add hz unit suffix.
- Add '|' to description.
.../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index 2e8da7470513..46bc8c028fe6 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -85,6 +85,14 @@ properties:
minimum: 0
maximum: 80
+ report-rate-hz:
+ description: |
+ Allows setting the scan rate in Hertz.
+ M06 supports range from 30 to 140 Hz.
+ M12 supports range from 1 to 255 Hz.
+ minimum: 1
+ maximum: 255
+
touchscreen-size-x: true
touchscreen-size-y: true
touchscreen-fuzz-x: true
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration
2022-06-21 12:39 [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration Dario Binacchi
2022-06-21 12:39 ` [RESEND PATCH v4 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Dario Binacchi
@ 2022-06-29 5:08 ` Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2022-06-29 5:08 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, Krzysztof Kozlowski, Marco Felsch,
Michael Trimarchi, Oliver Graute, Rob Herring, devicetree,
linux-input
On Tue, Jun 21, 2022 at 02:39:31PM +0200, Dario Binacchi wrote:
> The series was born from the analysis and mitigation of a crc problem
> raised by an M06 type device. The added sysfs attributes were helpful
> in debugging the problem. Patches that change the report rate on driver
> probing, mitigated crc errors on kernel bootup. The patch to get/set
> report rate by sysfs for an M12 device, has been tested.
>
> Changes in v4:
> - Add Rob Herring 'Acked-by' tag.
>
> Changes in v3:
> - Add hz unit suffix.
> - Add '|' to description.
> - Check the lower and upper limits of the report-rate-hz value
> - Convert the M06 report-rate-hz value
>
> Changes in v2:
> - Add Oliver Graute's 'Acked-by' tag to:
> * Input: edt-ft5x06 - show model name by sysfs
> * Input: edt-ft5x06 - show firmware version by sysfs
> - Fix yaml file. Tested with `make DT_CHECKER_FLAGS=-m dt_binding_check'.
>
> Dario Binacchi (6):
> dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
> Input: edt-ft5x06 - get/set M12 report rate by sysfs
> Input: edt-ft5x06 - set report rate by dts property
> Input: edt-ft5x06 - show model name by sysfs
> Input: edt-ft5x06 - show firmware version by sysfs
> Input: edt-ft5x06 - show crc and header errors by sysfs
>
> .../input/touchscreen/edt-ft5x06.yaml | 8 ++
> drivers/input/touchscreen/edt-ft5x06.c | 103 ++++++++++++++++--
> 2 files changed, 103 insertions(+), 8 deletions(-)
Applied the lot with a few small adjustments, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-29 5:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-21 12:39 [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration Dario Binacchi
2022-06-21 12:39 ` [RESEND PATCH v4 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Dario Binacchi
2022-06-29 5:08 ` [RESEND PATCH v4 0/6] Input: edt-ft5x06 - Improve configuration Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2022-06-07 9:55 Dario Binacchi
2022-05-05 15:56 Dario Binacchi
2022-04-21 18:59 Dario Binacchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).