From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73118CCA487 for ; Tue, 12 Jul 2022 15:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233935AbiGLPEx (ORCPT ); Tue, 12 Jul 2022 11:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233936AbiGLPEJ (ORCPT ); Tue, 12 Jul 2022 11:04:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4AD63A8; Tue, 12 Jul 2022 08:00:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0553061221; Tue, 12 Jul 2022 15:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33461C341CF; Tue, 12 Jul 2022 15:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657638011; bh=4stto/0WdKGy1PAM7cobud0ZktYRhwuIUHvFotEri6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kuVF7pg7PKX53+paGnLUTnLYkCzxjavhSjkjkPKVKfMA6yBWwbCM0eCa78ysbYzNl /MNYBktPDvvt3nGQrZjSbRkLOf1ESWkBOaEbCBCeZl/LmGhdm0XazCO7iCzetTzxIX j/8bpJQgHZVljOZo/nXxlh/v2mhOWJCsztl4lFmK2yQEo4sZ8g+2UfzA712XvxDoOh RH1IEtLDCFibFK4/zR50dUYCyCc+ctEcCTnsu9SkDMSAvJRbzc4JN6vKWjCFQ2Mx6/ rzouqEz4GAccJHA9K1XFes2H5kROO5Ial9u2R0uNkybUoEdu5dxxGZ4jaU0P+kGh91 kGqYwjooNtovA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oBHMz-0002FB-38; Tue, 12 Jul 2022 17:00:13 +0200 Date: Tue, 12 Jul 2022 17:00:13 +0200 From: Johan Hovold To: Bjorn Andersson , Rob Herring Cc: Andy Gross , Konrad Dybcio , Johan Hovold , Rob Herring , Krzysztof Kozlowski , manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Add lost ranges for timer Message-ID: References: <20220707160858.3178771-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 12, 2022 at 04:53:48PM +0200, Johan Hovold wrote: > On Mon, Jul 11, 2022 at 07:28:26PM -0700, Bjorn Andersson wrote: > > On Mon 11 Jul 01:56 PDT 2022, Johan Hovold wrote: > > > > > On Thu, Jul 07, 2022 at 09:08:58AM -0700, Bjorn Andersson wrote: > > > > The timer node needs ranges specified to map the 1-cell children to the > > > > 2-cell address range used in /soc. This addition never made it into the > > > > patch that was posted and merged, so add it now. > > > > > > > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > > > Signed-off-by: Bjorn Andersson > > > > --- > > > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > > index 2bdb42c88311..37a4cd6f85b6 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > > @@ -1667,6 +1667,7 @@ timer@17c20000 { > > > > reg = <0x0 0x17c20000 0x0 0x1000>; > > > > #address-cells = <1>; > > > > #size-cells = <1>; > > > > + ranges = <0 0 0 0x20000000>; > > > > > > While addressing the current issue, this looks odd to me. Why not use a > > > non-zero parent bus address here instead? > > > > > > > I guess we could express the frames relative the timer range, but that > > would imply that anyone porting downstream dts snippets would have to > > translate these addresses - or more likely would end up just copying the > > existing cases. > > > > > And please use hex notation consistently for the addresses. > > > > That seems like a reasonable ask, I can fix that up. But on both > > accounts this matches what I merged for all the other platforms in: > > > > 458ebdbb8e5d ("arm64: dts: qcom: timer should use only 32-bit size") > > > > > > So I guess we'll also need to go back and fix up the style of all the > > other platforms - just because we're not allowed to express the frames > > in 64-bits according to the binding... > > Would have been easier to just amend the binding. I don't think that > #size-cells = 1 constraint is set in stone as it was added when > converting to DT schema. Ok, maybe it was done on purpose since Rob later merged c5c689d3221e ("dt-bindings: timer: Use non-empty ranges in example") which suggests we should use a non-empty ranges as I mentioned above. Any comments, Rob? > I also don't think you need to fixup the hex notation elsewhere, it's > quite inconsistent currently, but no need to make it worse. > > But you probably should amend the commit message and mention that this > fixes time keeping. I had recently noticed that something was off > (journals rotating, and erratic cursor blinking) but didn't realise that > timers were broken until you posted this. Johan