From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00571C433EF for ; Tue, 12 Jul 2022 21:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbiGLVZG (ORCPT ); Tue, 12 Jul 2022 17:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbiGLVZF (ORCPT ); Tue, 12 Jul 2022 17:25:05 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C5E6C48EE for ; Tue, 12 Jul 2022 14:25:03 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id y141so8544193pfb.7 for ; Tue, 12 Jul 2022 14:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y4UyLrACxlenLlhH0mDXEAxElGbIQd50zgnqB+nPHFw=; b=GmANklKAqlYga+Up5mAaU9+fI6zf3sB//UrPU0s2zl+KVDKC0txFhJMrPSjbRtmVTy vx5ecmLjUOydAneb9e/9/ULVEfBJsxSoFel3u7mGEbLqxvRw6IfWf+/IhFALTSnX6xVC A5yfUoFJFRrJTlHEROTlRSkrpObqa65sR3rfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y4UyLrACxlenLlhH0mDXEAxElGbIQd50zgnqB+nPHFw=; b=lwnRaRbynkr/VN6+QAyhQ/QKb4e8qDShLsAFzVLrE7RCwHOb2qJ3WZkmzgnN4Nnxql EMtdFujaUk2HuZBzLNV+sZQuilqc0R9BWINQWWCpv/7pShT6rPfzU//EZCV8dUWcDQKB fQaKX6AAcyPDyi0m6BFh2IdsTKb7zwF1LWEoQzaTR6xAdHcb25FKexWpkjJ53DYU62QE Ce3JPx5Gd0TWh1g0Uawxzf5udrFeYOFK5VnrN0UOGFu4eOgMlWJSSi5+i0kGveU6LNnd ROOfOGmLdZhoZcktM4dnFSp6kvKvzjvXfUgWq7u7UnRErt3WNPenjnl8JWPCUpfHpg2s Ibkg== X-Gm-Message-State: AJIora+5hJLDRNxIl9NQkB3Hp4Kb4k61ur5rSDO61/T2qnUyLw15Eupw lgt09AzXhFN79iLz+8V8ZT6kmw== X-Google-Smtp-Source: AGRyM1uN2kL6DXJZ5Sw8PvGJUBvehogbzgcBO1icN//Q5p9KLYMdEMvwpffnJSXd4umWZtlRNNYERw== X-Received: by 2002:a62:15cd:0:b0:528:bf80:37c1 with SMTP id 196-20020a6215cd000000b00528bf8037c1mr154760pfv.22.1657661102575; Tue, 12 Jul 2022 14:25:02 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:e036:8c0d:9cf:7a45]) by smtp.gmail.com with UTF8SMTPSA id w1-20020a1709026f0100b0016bd8fb1fafsm7220728plk.307.2022.07.12.14.25.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 14:25:02 -0700 (PDT) Date: Tue, 12 Jul 2022 14:25:00 -0700 From: Matthias Kaehlcke To: Krzysztof Kozlowski Cc: Alexander Stein , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: usb: Add binding for TI USB8041 hub controller Message-ID: References: <20220712150627.1444761-1-alexander.stein@ew.tq-group.com> <34e2a75a-b6dc-d5ae-4820-58cee2b0dd29@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <34e2a75a-b6dc-d5ae-4820-58cee2b0dd29@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 12, 2022 at 11:12:06PM +0200, Krzysztof Kozlowski wrote: > On 12/07/2022 19:25, Matthias Kaehlcke wrote: > > Hi Alexander, > > > > On Tue, Jul 12, 2022 at 05:06:25PM +0200, Alexander Stein wrote: > >> The TI USB8041 is a USB 3.0 hub controller with 4 ports. > >> > >> This initial version of the binding only describes USB related aspects > >> of the USB8041, it does not cover the option of connecting the controller > >> as an i2c slave. > >> > >> Signed-off-by: Alexander Stein > >> --- > >> Well, this is essentially a ripoff of > >> Documentation/devicetree/bindings/usb/realtek,rts5411.yaml with USB IDs > >> replaced, reset-gpio added and example adjusted. > >> IMHO this should be merged together with realtek,rts5411.yaml. Is it ok > >> to rename bindings files? I guess a common onboard-usb-hub.yaml matching > >> the driver seens reasonable. Any recommendations how to proceed? > > > > It's a tradeoff between keeping the individual bindings simple and avoid > > unnecessary duplication. The current RTS5411 and TI USB8041 bindings are > > very similar, which suggests combining them. However over time hubs with > > diverging features could be added (e.g. with multiple regulators, a link > > to an I2C/SPI bus, a clock, ...). With that a common binding might become > > too messy. > > > > From a quick look through Documentation/devicetree/bindings it doesn't > > seem common to have generic bindings that cover components from multiple > > vendors. In that sense I'm leaning towards separate bindings. > > > > Rob, do you have any particular preference or suggestion? > > Not Rob, but my suggestion is not to merge bindings of unrelated > devices, even if they are the same class. By unrelated I mean, made by > different companies, designed differently and having nothing in common > by design. Bindings can be still similar, but should not be merged just > because they are similar. Thanks for your advice, let's keep separate bindings then.