From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Joel Selvaraj <jo@jsfamily.in>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: sdm845-xiaomi-beryllium: rename beryllium.dts into beryllium-common.dtsi
Date: Wed, 13 Jul 2022 15:52:41 -0500 [thread overview]
Message-ID: <Ys8wmeMYnKFa9Iqv@builder.lan> (raw)
In-Reply-To: <MN2PR02MB7024359650A02554EF6ABEA5D9829@MN2PR02MB7024.namprd02.prod.outlook.com>
On Fri 08 Jul 06:12 CDT 2022, Joel Selvaraj wrote:
> The existing beryllium dts file is converted into a common dtsi file
> which the tianma and ebbg variant will inherit.
>
Applying this patch would cause the tree to fail to build until the last
patch is introduced. This would cause problems for people trying to use
git bisect to find regressions in the git history.
Could you please respin this patch such that it continues to build the
currently supported board and then you could add the new board/variant
in a separate commit.
Regards,
Bjorn
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
> ...5-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename arch/arm64/boot/dts/qcom/{sdm845-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} (100%)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> similarity index 100%
> rename from arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> rename to arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-07-13 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220708111207.85249-1-jo@jsfamily.in>
2022-07-08 11:12 ` [PATCH 1/5] arm64: dts: sdm845-xiaomi-beryllium: rename beryllium.dts into beryllium-common.dtsi Joel Selvaraj
2022-07-13 20:52 ` Bjorn Andersson [this message]
2022-07-14 17:27 ` Joel Selvaraj
2022-07-08 11:12 ` [PATCH 2/5] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: generalize the display panel node Joel Selvaraj
2022-07-13 20:53 ` Bjorn Andersson
2022-07-08 11:12 ` [PATCH 3/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: introduce tianma variant Joel Selvaraj
2022-07-08 11:12 ` [PATCH 4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: introduce ebbg variant Joel Selvaraj
2022-07-08 11:12 ` [PATCH 5/5] arm64: dts: qcom: Makefile: split beryllium into tianma and " Joel Selvaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys8wmeMYnKFa9Iqv@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jo@jsfamily.in \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).