From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A97C43334 for ; Wed, 13 Jul 2022 20:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237272AbiGMUwu (ORCPT ); Wed, 13 Jul 2022 16:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237249AbiGMUwp (ORCPT ); Wed, 13 Jul 2022 16:52:45 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105C33138C for ; Wed, 13 Jul 2022 13:52:44 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id j3so41768oif.8 for ; Wed, 13 Jul 2022 13:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2ykUFDJKpymYm5hCsAJ+Q7MiQQTFwssew2VYnA3ZdZY=; b=J+uEzqlW+auhEWVaicUqVAqenJlGy9Hwh6KlQHYrzJXEwp3+EeVIh50RVp8Gf39nyZ 1l+WB4bASoxi8ehROmXeofZQXV431Vjr3skA0Z2eR5+TIpsMA0f7MVIXXER4iPSWaUDz 0Km7HPD+6uEZz8Yb8BMBNXRojeH5Y91kjJwUbGc3uaqZZvBQFGCOroDbvXjEu9ogdsXX 66VF/QPAKsmf+HuSsKvvSpcNbXJ9JKBvCGz47KGB2IGRF6aK/gT7iPC2PRBP/tQ5dx9f QHKoakGz3lUFO2R/hqZW7taIa9Tj8VVyR2vs+qwiGMrDbVJ/l23glyeac07VeW//ajuh t1bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2ykUFDJKpymYm5hCsAJ+Q7MiQQTFwssew2VYnA3ZdZY=; b=1bP0/kUuacGl5naR2rknc+2yDQAN5xvIjO6inFBCAPjUZ5/oJkzmQ9Fu14gBQpNeG1 Ht77BSCFGP4YvBxY3Dq7h/SFO9JKgtbLQT/HgxtcJtVOh3GDADJx1kPmPztjz2PFyRrf XZJZAlaYzzY/VjZFFHXO/Qh422RPTM8OixqCEx+lyiVkhG19DuxlDgHKzotIdp3+Gne+ 1rnXSX3LSW8/x8H53QtP2kWaZO6jJNre7ytB+1C0a0zjrIwsSzgjQMkIvXqacmGqrl2a xhvX+UAew9lHtFlWuqQOmUwA3z4bEtRvxlFMcNK8C6hOMgL898bXHfTgGXIrqvKv4w3a d0pg== X-Gm-Message-State: AJIora/ac6lU29U2PJTv6ZmiZswLKT8c/h8U3Jg1CJTkTy6nxe9PT7DH TeF4mXvDeWnYngWaajqDLUHQJA== X-Google-Smtp-Source: AGRyM1vxfSoqykkHIcVnF4vZoC0MDmVbJ629P8d8bFXmakWLTxeWAvfc6mFEXLsLmOn6YDCOYQi3JA== X-Received: by 2002:a05:6808:144b:b0:337:aee7:b006 with SMTP id x11-20020a056808144b00b00337aee7b006mr2896659oiv.204.1657745563421; Wed, 13 Jul 2022 13:52:43 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id d1-20020a0568301b6100b0061c4b17c0b7sm3980864ote.43.2022.07.13.13.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 13:52:42 -0700 (PDT) Date: Wed, 13 Jul 2022 15:52:41 -0500 From: Bjorn Andersson To: Joel Selvaraj Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [PATCH 1/5] arm64: dts: sdm845-xiaomi-beryllium: rename beryllium.dts into beryllium-common.dtsi Message-ID: References: <20220708111207.85249-1-jo@jsfamily.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 08 Jul 06:12 CDT 2022, Joel Selvaraj wrote: > The existing beryllium dts file is converted into a common dtsi file > which the tianma and ebbg variant will inherit. > Applying this patch would cause the tree to fail to build until the last patch is introduced. This would cause problems for people trying to use git bisect to find regressions in the git history. Could you please respin this patch such that it continues to build the currently supported board and then you could add the new board/variant in a separate commit. Regards, Bjorn > Signed-off-by: Joel Selvaraj > --- > ...5-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename arch/arm64/boot/dts/qcom/{sdm845-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} (100%) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > similarity index 100% > rename from arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > rename to arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > -- > 2.36.1 >