From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50906C433EF for ; Tue, 5 Jul 2022 14:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbiGEOiP (ORCPT ); Tue, 5 Jul 2022 10:38:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiGEOiO (ORCPT ); Tue, 5 Jul 2022 10:38:14 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AA106367 for ; Tue, 5 Jul 2022 07:38:13 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id q9so17862086wrd.8 for ; Tue, 05 Jul 2022 07:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LEr7rAT/dnyEPQvdO9AbnDAZNWNC1MOMxzJEHX4ciRw=; b=yWHt0oSA5NN7wvK9dqmRUjAPfhTwMvVbR3r6dnaxMKKI3iMkztHCur6uCnCyDSZCnM CmQFiFwYbiciwfwbd0yAldFCuRJJ+vM8umXOumxOySv/8JzJLxVD2t7smbq/CKRbJMha ToZK+dtiLZlmjDobTzR8B5HTIB28hq53pn4OyjuWv9ud4k31Ns9dI3jMOEm3r0vcpTNu NogQrZ+Y1jkD8zKUmuIZDg7BnITD9m+pT3voh5hu05KR/LMPbRHABrmZOBAOfJn6Jluv DKwyOrMktNlhmN8aMySVT+XQuH0f9/kSEmDtFkc7oiB/erPXZpV4qirn/2sFsRrSXn7x OxRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LEr7rAT/dnyEPQvdO9AbnDAZNWNC1MOMxzJEHX4ciRw=; b=W2st87gz89KzHX5bbkkXg74vB87v5oqtMaCL5Mbjp8P3Vjng/l346lNYaojmg6WZiD M/ajWOLqh+c4whjChjxPbVzuVZg3HeG5z1bPgiGcbakS6pG1Dn/BZXvcftbA3FW85Ich v2FXkOAftThw7ecgjM7h1Iy+Iu7oE88aLa4qrn/k9MtPn5EVLTwRCao5AXvU66qhcgMo n6RkXkC8tjwgJuuJYzAi+iiSOfRWW6ynthb4Jj+E9s3mUEzoqv8ANxV2kh3n3/tAylc+ MTEb1/CqfZFIKdqKizo78vzhsCkdP6nE7SmcG9myvEmdNcA3cbSXeB5PjCflVxAHp8e/ TbaA== X-Gm-Message-State: AJIora94fa2Ma/cKFy1vZZnKfyAamg9WEIQ1MarkZrkDfavCqUJtJhPv Pm7bTL/g/nCPZ6WGE32z443zZw== X-Google-Smtp-Source: AGRyM1tjvSYRki+5ro8CHDLjpDR4wA1h8wunkn2tYRP1SfoMKQYJCzQ3sF7vShJ0hFSOY3ibuNwkfw== X-Received: by 2002:a5d:6d8b:0:b0:21b:9814:793d with SMTP id l11-20020a5d6d8b000000b0021b9814793dmr31966737wrs.344.1657031891814; Tue, 05 Jul 2022 07:38:11 -0700 (PDT) Received: from google.com ([2.26.241.96]) by smtp.gmail.com with ESMTPSA id z11-20020a5d654b000000b0021b8c554196sm33955336wrv.29.2022.07.05.07.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 07:38:11 -0700 (PDT) Date: Tue, 5 Jul 2022 15:38:08 +0100 From: Lee Jones To: Aidan MacDonald Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wens@csie.org, jic23@kernel.org, sre@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, lars@metafoo.de, quic_gurus@quicinc.com, sebastian.reichel@collabora.com, andy.shevchenko@gmail.com, michael@walle.cc, rdunlap@infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 06/15] mfd: axp20x: Add support for AXP192 Message-ID: References: <20220629143046.213584-1-aidanmacdonald.0x0@gmail.com> <20220629143046.213584-7-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 05 Jul 2022, Aidan MacDonald wrote: > > Lee Jones writes: > > > On Wed, 29 Jun 2022, Aidan MacDonald wrote: > > > >> The AXP192 PMIC is similar to the AXP202/AXP209, but with different > >> regulators, additional GPIOs, and a different IRQ register layout. > >> > >> Acked-for-MFD-by: Lee Jones > >> Signed-off-by: Aidan MacDonald > >> --- > >> drivers/mfd/axp20x-i2c.c | 2 + > >> drivers/mfd/axp20x.c | 152 +++++++++++++++++++++++++++++++++++++ > >> include/linux/mfd/axp20x.h | 84 ++++++++++++++++++++ > >> 3 files changed, 238 insertions(+) > >> [...] > >> +static const struct regmap_irq_chip axp192_regmap_irq_chip = { > >> + .name = "axp192_irq_chip", > >> + .status_base = AXP192_IRQ1_STATE, > >> + .ack_base = AXP192_IRQ1_STATE, > >> + .unmask_base = AXP192_IRQ1_EN, > >> + .init_ack_masked = true, > >> + .irqs = axp192_regmap_irqs, > >> + .num_irqs = ARRAY_SIZE(axp192_regmap_irqs), > >> + .num_regs = 5, > >> + .get_irq_reg = axp192_get_irq_reg, > > > > Fix me: > > > > drivers/mfd/axp20x.c:634:35: error: initialization of 'unsigned int (*)(struct regmap_irq_chip_data *, unsigned int, int)' from incompatible pointer type 'int (*)(unsigned int, int)' [-Werror=incompatible-pointer-types] > > 634 | .get_irq_reg = axp192_get_irq_reg, > > | ^~~~~~~~~~~~~~~~~~ > > drivers/mfd/axp20x.c:634:35: note: (near initialization for 'axp192_regmap_irq_chip.get_irq_reg') > > > > This doesn't need fixing. You are missing the prerequisite patches. > > -- snip -- > Changes in v4: > * Drop regmap-irq patches and rebase on top of the regmap-irq > refactoring series[1], which implements the same functionality. > > [1]: https://lore.kernel.org/lkml/20220623211420.918875-1-aidanmacdonald.0x0@gmail.com/ > -- snip -- > Perhaps I wasn't clear enough that it was a dependency, sorry for > any confusion. Any idea why the regmap-irq patches weren't in -next? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog