* [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets
@ 2022-07-07 13:45 Dmitry Baryshkov
2022-07-07 13:56 ` Johan Hovold
2022-07-12 19:51 ` Bjorn Helgaas
0 siblings, 2 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-07-07 13:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Jingoo Han, Gustavo Pimentel,
Lorenzo Pieralisi, Bjorn Helgaas, Stanimir Varbanov,
Manivannan Sadhasivam
Cc: Vinod Koul, linux-arm-msm, linux-pci, devicetree, Johan Hovold
Fix the typo (compatibles vs compatible) in the condition guarding the
resets being required everywhere except MSM8996.
Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 0b69b12b849e..9b3ebee938e8 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -614,7 +614,7 @@ allOf:
- if:
not:
properties:
- compatibles:
+ compatible:
contains:
enum:
- qcom,pcie-msm8996
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets
2022-07-07 13:45 [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets Dmitry Baryshkov
@ 2022-07-07 13:56 ` Johan Hovold
2022-07-07 14:05 ` Dmitry Baryshkov
2022-07-12 19:51 ` Bjorn Helgaas
1 sibling, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-07-07 13:56 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Jingoo Han, Gustavo Pimentel,
Lorenzo Pieralisi, Bjorn Helgaas, Stanimir Varbanov,
Manivannan Sadhasivam, Vinod Koul, linux-arm-msm, linux-pci,
devicetree
On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote:
> Fix the typo (compatibles vs compatible) in the condition guarding the
> resets being required everywhere except MSM8996.
>
> Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
I already posted a fix for this a week ago as you probably noticed as I
was the one pointing the issue out to you:
https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 0b69b12b849e..9b3ebee938e8 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -614,7 +614,7 @@ allOf:
> - if:
> not:
> properties:
> - compatibles:
> + compatible:
> contains:
> enum:
> - qcom,pcie-msm8996
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets
2022-07-07 13:56 ` Johan Hovold
@ 2022-07-07 14:05 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-07-07 14:05 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Jingoo Han, Gustavo Pimentel,
Lorenzo Pieralisi, Bjorn Helgaas, Stanimir Varbanov,
Manivannan Sadhasivam, Vinod Koul, linux-arm-msm, linux-pci,
devicetree
On 07/07/2022 16:56, Johan Hovold wrote:
> On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote:
>> Fix the typo (compatibles vs compatible) in the condition guarding the
>> resets being required everywhere except MSM8996.
>>
>> Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> I already posted a fix for this a week ago as you probably noticed as I
> was the one pointing the issue out to you:
>
> https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/
Please excuse me then for duplicating your work. I checked linux-next
and missed the mentioned patch. Bjorn, Lorenzo, could you please pick it up?
>> ---
>> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> index 0b69b12b849e..9b3ebee938e8 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> @@ -614,7 +614,7 @@ allOf:
>> - if:
>> not:
>> properties:
>> - compatibles:
>> + compatible:
>> contains:
>> enum:
>> - qcom,pcie-msm8996
>
> Johan
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets
2022-07-07 13:45 [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets Dmitry Baryshkov
2022-07-07 13:56 ` Johan Hovold
@ 2022-07-12 19:51 ` Bjorn Helgaas
2022-07-13 6:04 ` Johan Hovold
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2022-07-12 19:51 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Jingoo Han, Gustavo Pimentel,
Lorenzo Pieralisi, Bjorn Helgaas, Stanimir Varbanov,
Manivannan Sadhasivam, Vinod Koul, linux-arm-msm, linux-pci,
devicetree, Johan Hovold
On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote:
> Fix the typo (compatibles vs compatible) in the condition guarding the
> resets being required everywhere except MSM8996.
>
> Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Applied for v5.20, thanks!
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 0b69b12b849e..9b3ebee938e8 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -614,7 +614,7 @@ allOf:
> - if:
> not:
> properties:
> - compatibles:
> + compatible:
> contains:
> enum:
> - qcom,pcie-msm8996
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets
2022-07-12 19:51 ` Bjorn Helgaas
@ 2022-07-13 6:04 ` Johan Hovold
2022-07-13 14:59 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-07-13 6:04 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Jingoo Han, Gustavo Pimentel,
Lorenzo Pieralisi, Bjorn Helgaas, Stanimir Varbanov,
Manivannan Sadhasivam, Vinod Koul, linux-arm-msm, linux-pci,
devicetree
On Tue, Jul 12, 2022 at 02:51:37PM -0500, Bjorn Helgaas wrote:
> On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote:
> > Fix the typo (compatibles vs compatible) in the condition guarding the
> > resets being required everywhere except MSM8996.
> >
> > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Applied for v5.20, thanks!
Glad to see this fixed, Bjorn H, but was there any particular reason why
you picked this version over the patch I submitted a week earlier when
reporting the issue?
I posted a link to it earlier in this thread:
https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/
> > ---
> > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index 0b69b12b849e..9b3ebee938e8 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -614,7 +614,7 @@ allOf:
> > - if:
> > not:
> > properties:
> > - compatibles:
> > + compatible:
> > contains:
> > enum:
> > - qcom,pcie-msm8996
> > --
> > 2.35.1
> >
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets
2022-07-13 6:04 ` Johan Hovold
@ 2022-07-13 14:59 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2022-07-13 14:59 UTC (permalink / raw)
To: Johan Hovold
Cc: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Jingoo Han, Gustavo Pimentel,
Lorenzo Pieralisi, Bjorn Helgaas, Stanimir Varbanov,
Manivannan Sadhasivam, Vinod Koul, linux-arm-msm, linux-pci,
devicetree
On Wed, Jul 13, 2022 at 08:04:02AM +0200, Johan Hovold wrote:
> On Tue, Jul 12, 2022 at 02:51:37PM -0500, Bjorn Helgaas wrote:
> > On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote:
> > > Fix the typo (compatibles vs compatible) in the condition guarding the
> > > resets being required everywhere except MSM8996.
> > >
> > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms")
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >
> > Applied for v5.20, thanks!
>
> Glad to see this fixed, Bjorn H, but was there any particular reason why
> you picked this version over the patch I submitted a week earlier when
> reporting the issue?
Sorry, my mistake. I'll drop this and replace with your patch.
> I posted a link to it earlier in this thread:
>
> https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/
>
> > > ---
> > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > > index 0b69b12b849e..9b3ebee938e8 100644
> > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > > @@ -614,7 +614,7 @@ allOf:
> > > - if:
> > > not:
> > > properties:
> > > - compatibles:
> > > + compatible:
> > > contains:
> > > enum:
> > > - qcom,pcie-msm8996
> > > --
> > > 2.35.1
> > >
>
> Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-13 14:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-07 13:45 [PATCH] dt-bindings: PCI: qcom: fix typo in condition guarding resets Dmitry Baryshkov
2022-07-07 13:56 ` Johan Hovold
2022-07-07 14:05 ` Dmitry Baryshkov
2022-07-12 19:51 ` Bjorn Helgaas
2022-07-13 6:04 ` Johan Hovold
2022-07-13 14:59 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).